Where to contribute code to for JHttp and associated code

[Hayden Young]

Hi

I recently issued a pull request https://github.com/joomla/joomla-cms/pull/17187 to the joomla/joomla-cms github repository, suggesting modifications to the file libraries/joomla/http/transport/curl.php.

I have noticed it hasn't moved along at all and there is a single test which keeps failing, "continuous-integration/jenkins/pr-merge - This commit cannot be built".

I have issued a new upstream pull on joomla/joomla-cms and now notice that the libraries joomla/http and joomla/http/transport no longer exist; I'm assuming they have been moved out to some other repository since these classes are still available in the 3.7 installation. Therefore, I'm wondering which source code repository I should be issuing code changes to in order to modify the class JHttpTransportCurl? I see there is also a reference to a lib called joomla/application but I can't find the mos up-to-date repo for this code.

Any help much appreciated.


Hayden

[Allon Moritz]

They are namespaced now and can be found here https://github.com/joomla/joomla-cms/blob/staging/libraries/src/Http/Transport/CurlTransport.php.

Hayden

--
You received this message because you are subscribed to the Google Groups "Joomla! CMS Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to joomla-dev-cms+unsubscribe@googlegroups.com.
To post to this group, send an email to joomla-dev-cms@googlegroups.com.
Visit this group at https://groups.google.com/group/joomla-dev-cms.
For more options, visit https://groups.google.com/d/optout.

[Hayden Young]

Thanks. I missed that.

On Friday, August 11, 2017 at 7:23:49 PM UTC+8, Allon Moritz wrote:

They are namespaced now and can be found here https://github.com/joomla/joomla-cms/blob/staging/libraries/src/Http/Transport/CurlTransport.php.

On Fri, Aug 11, 2017 at 12:20 PM, Hayden Young <hay...@knowledgearc.com> wrote:

Hi

I recently issued a pull request https://github.com/joomla/joomla-cms/pull/17187 to the joomla/joomla-cms github repository, suggesting modifications to the file libraries/joomla/http/transport/curl.php.

I have noticed it hasn't moved along at all and there is a single test which keeps failing, "continuous-integration/jenkins/pr-merge - This commit cannot be built".

I have issued a new upstream pull on joomla/joomla-cms and now notice that the libraries joomla/http and joomla/http/transport no longer exist; I'm assuming they have been moved out to some other repository since these classes are still available in the 3.7 installation. Therefore, I'm wondering which source code repository I should be issuing code changes to in order to modify the class JHttpTransportCurl? I see there is also a reference to a lib called joomla/application but I can't find the mos up-to-date repo for this code.

Any help much appreciated.

Hayden

--
You received this message because you are subscribed to the Google Groups "Joomla! CMS Development" group.

To unsubscribe from this group and stop receiving emails from it, send an email to joomla-dev-cm...@googlegroups.com.
To post to this group, send an email to joomla-...@googlegroups.com.