Bad Return ? for Joomla Application login function

43 views
Skip to first unread message

Thomas PAPIN

unread,
Apr 11, 2016, 10:18:40 AM4/11/16
to joomla-dev-cms
            * @return  boolean  True on success.
public function login($credentials, $options = array())

....

 // OK, the credentials are authenticated and user is authorised.  Let's fire the onLogin event.
$results = $this->triggerEvent('onUserLogin', array((array) $response, $options));


/*
 * If any of the user plugins did not successfully complete the login routine
 * then the whole method fails.
 *
 * Any errors raised should be done in the plugin as this provides the ability
 * to provide much more information about why the routine may have failed.
  */

if (in_array(false, $results, true) == false)
{
                                $options['user'] = $user;
                                $options['responseType'] = $response->type;

                                if (isset($response->length) && isset($response->secure) && isset($response->lifetime))
                                {
                                        $options['length'] = $response->length;
                                        $options['secure'] = $response->secure;
                                        $options['lifetime'] = $response->lifetime;
                                }

                                // The user is successfully logged in. Run the after login events
                                $this->triggerEvent('onUserAfterLogin', array($options));
}

return true;


So return always True even if a onUserLogin return false

so when User is not activated (block = 1), the login function returns TRUE.

Is that normal ?


Reply all
Reply to author
Forward
0 new messages