Existing support for GitLab plugin is outdated
34 views
Skip to first unread message
Iulian Surugiu
Mar 29, 2018, 8:07:20 AM3/29/18
to job-dsl-plugin
Hi,
I just noticed that gitlabPush lacks support for the following:
- triggerOnClosedMergeRequest
- triggerOnAcceptedMergeRequest
- triggerOnApprovedMergeRequest
Is it the case for everyone or just me?
Thanks,
-Iulian
Darin Pantley
May 14, 2018, 3:45:08 PM5/14/18
to job-dsl-plugin
I just noticed the same problem. The GitLab plugin supports them but the Job DSL plugin does not. It looks like the gitlabPush function in TriggerContext.groovy needs to be updated: https://github.com/jenkinsci/job-dsl-plugin/blob/master/job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/triggers/TriggerContext.groovy#L181
Darin Pantley
May 14, 2018, 6:22:19 PM5/14/18
to job-dsl-plugin
I filed JIRA ticket 51311 and submitted a pull request: https://github.com/jenkinsci/job-dsl-plugin/pull/1127
-Darin
Reply all
Reply to author
Forward
0 new messages