DisplayedCalendar non present in CalendarTimeTextField

[samir.ha...@gmail.com]

Hi guys,

I saw that CalendarPicker has a "displayedCalendar" property that is very useful in order to show a certain range directly without selecting any values. And this feature is not available for the textfields, is there any reason?

Because in case the TextField is null, we show by default the current date. But it could be very useful to show something else just like the CalendarPicker.

If you think this could be a good idea, I'm ready to implement it. And by the way, what do you think of maybe create an abstractClass containing all the common properties of these DatePickers?

Because they all share the fact that they have at least a Locale, a Value (Calendar, LocalDate, LocalDateTime) and a valueValidationCallback.

And some more specific also have other properties in common like RangeCallBack , Mode, Formatter etc.

Thanks

[tbeernot]

No, not really. So I'm open to changes that improve the controls. Please note that since these controls are in JFXtras, I require TestFX tests to prevent regression. And if you change in existing code, stick to the coding style that the author (being me :-) is using.

Tom

--
You received this message because you are subscribed to the Google Groups "JFXtras Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jfxtras-dev...@googlegroups.com.
To post to this group, send email to jfxtr...@googlegroups.com.
Visit this group at http://groups.google.com/group/jfxtras-dev.
For more options, visit https://groups.google.com/d/optout.

[samir.ha...@gmail.com]

Allright Tom!

So I think I will first introduce the "displayedCalendar" into the TextFields.

When it will be merged, I will try to implement an abstract class for the most common properties. And if it is merged, we can try to go one step further by having abstract classes more specific to avoid code duplication.

I will add tests if necessary depending on my changes and I will try to stick to your coding style. If I make some mistakes, don't hesitate to correct me in the PR.

Thanks!

[tbeernot]

Sounds good!

[samir.ha...@gmail.com]

I have made the pull request with the changes :)