[JIRA] [core] (JENKINS-34745) Check Updates PeriodicWork dies horribly in the case of invalid signature

4 views
Skip to first unread message

o.v.nenashev@gmail.com (JIRA)

unread,
May 11, 2016, 6:29:01 PM5/11/16
to jenkinsc...@googlegroups.com
Oleg Nenashev created an issue
 
Jenkins / Bug JENKINS-34745
Check Updates PeriodicWork dies horribly in the case of invalid signature
Issue Type: Bug Bug
Assignee: Oleg Nenashev
Components: core
Created: 2016/May/11 10:28 PM
Environment: jenkins-2.2
Priority: Major Major
Reporter: Oleg Nenashev

Runtime exceptions should be handled at least

Stacktrace:

May 12, 2016 12:24:18 AM hudson.init.impl.InstallUncaughtExceptionHandler$DefaultUncaughtExceptionHandler uncaughtException
SEVERE: A thread (Download metadata thread/57) died unexpectedly due to an uncaught exception, this may leave your Jenkins in a bad way and is usually indicative of a bug in the code.
java.lang.IndexOutOfBoundsException: Index: 0, Size: 0
	at java.util.ArrayList.rangeCheck(ArrayList.java:653)
	at java.util.ArrayList.get(ArrayList.java:429)
	at jenkins.util.JSONSignatureValidator.verifySignature(JSONSignatureValidator.java:85)
	at hudson.model.UpdateSite.verifySignature(UpdateSite.java:224)
	at hudson.model.UpdateSite.updateData(UpdateSite.java:203)
	at hudson.model.UpdateSite.updateDirectlyNow(UpdateSite.java:175)
	at hudson.PluginManager.doCheckUpdatesServer(PluginManager.java:1408)
	at jenkins.model.DownloadSettings$DailyCheck.execute(DownloadSettings.java:121)
	at hudson.model.AsyncPeriodicWork$1.run(AsyncPeriodicWork.java:99)
	at java.lang.Thread.run(Thread.java:745)
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
Atlassian logo

scm_issue_link@java.net (JIRA)

unread,
May 14, 2016, 8:06:02 AM5/14/16
to jenkinsc...@googlegroups.com
SCM/JIRA link daemon commented on Bug JENKINS-34745
 
Re: Check Updates PeriodicWork dies horribly in the case of invalid signature

Code changed in jenkins
User: Oleg Nenashev
Path:
core/src/main/java/hudson/PluginManager.java
core/src/main/java/jenkins/util/JSONSignatureValidator.java
http://jenkins-ci.org/commit/jenkins/1e6afbae3b82936602f28c402379e04d0b00a47e
Log:
JENKINS-34745 - Prevent CheckUpdates PeriodicWork death if update site cert is missing (#2333)

  • JENKINS-34745 - Prevent CheckUpdates PeriodicWork death in the case of the missing update site signature
  • JENKINS-34745 - Fix the formatting of the validation message (cc @lanwen)

itaisanders@gmail.com (JIRA)

unread,
May 15, 2016, 5:28:02 AM5/15/16
to jenkinsc...@googlegroups.com
Itai Sanders updated an issue
 
Change By: Itai Sanders
Priority: Major Critical

itaisanders@gmail.com (JIRA)

unread,
May 15, 2016, 5:31:02 AM5/15/16
to jenkinsc...@googlegroups.com
Itai Sanders commented on Bug JENKINS-34745
 
Re: Check Updates PeriodicWork dies horribly in the case of invalid signature

this exceptions happens here on a daily basis, seems like some sort of idle process that throws it in a very different context.
the exception causes Jenkins to enter a java.lang.OutOfMemoryError: Java heap space spiral from this point onward until the service crashes and must be restarted manually.

change Priority to critical because of the daily crash.

o.v.nenashev@gmail.com (JIRA)

unread,
May 17, 2016, 6:17:02 AM5/17/16
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue
 
Change By: Oleg Nenashev
Labels: lts-candidate

o.v.nenashev@gmail.com (JIRA)

unread,
May 17, 2016, 6:17:02 AM5/17/16
to jenkinsc...@googlegroups.com

o.v.nenashev@gmail.com (JIRA)

unread,
May 17, 2016, 6:17:02 AM5/17/16
to jenkinsc...@googlegroups.com
Oleg Nenashev resolved as Fixed
 
Change By: Oleg Nenashev
Status: Open Resolved
Resolution: Fixed

scm_issue_link@java.net (JIRA)

unread,
May 25, 2016, 4:26:12 AM5/25/16
to jenkinsc...@googlegroups.com

Code changed in jenkins
User: Oleg Nenashev
Path:
core/src/main/java/hudson/PluginManager.java
core/src/main/java/jenkins/util/JSONSignatureValidator.java

JENKINS-34745 - Prevent CheckUpdates PeriodicWork death if update site cert is missing (#2333)
  • JENKINS-34745 - Prevent CheckUpdates PeriodicWork death in the case of the missing update site signature
  • JENKINS-34745 - Fix typo in the validator
  • JENKINS-34745 - Fix the formatting of the validation message (cc @lanwen)

(cherry picked from commit 1e6afbae3b82936602f28c402379e04d0b00a47e)

ogondza@gmail.com (JIRA)

unread,
May 25, 2016, 1:39:09 PM5/25/16
to jenkinsc...@googlegroups.com
Oliver Gondža updated an issue
 
Change By: Oliver Gondža
Labels: lts 1.651.3 - candidate fixed
Reply all
Reply to author
Forward
0 new messages