[JIRA] (JENKINS-37481) Upgrading from 1.20.0 to 1.21.0 causes github org webhooks not to work

3 views
Skip to first unread message

sasha@virtoway.com (JIRA)

unread,
Aug 17, 2016, 3:10:05 PM8/17/16
to jenkinsc...@googlegroups.com
Alexander Siniouguine created an issue
 
Jenkins / Improvement JENKINS-37481
Upgrading from 1.20.0 to 1.21.0 causes github org webhooks not to work
Issue Type: Improvement Improvement
Assignee: Kirill Merkushev
Components: github-plugin
Created: 2016/Aug/17 7:09 PM
Environment: Windows
Priority: Critical Critical
Reporter: Alexander Siniouguine

When upgrading to the latest 1.21.0 version having 1.20.0 installed, webhooks from github are stop working with an error trace below (500 error reported by github). Downgrading back to the 1.20 solves the problem so must be something with a new version.

java.lang.NullPointerException: Secret should be defined to compute sign
at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:204)
at org.jenkinsci.plugins.github.webhook.GHWebhookSignature.webhookSignature(GHWebhookSignature.java:41)
at org.jenkinsci.plugins.github.webhook.RequirePostWithGHHookPayload$Processor.shouldProvideValidSignature(RequirePostWithGHHookPayload.java:149)
at org.jenkinsci.plugins.github.webhook.RequirePostWithGHHookPayload$Processor.invoke(RequirePostWithGHHookPayload.java:74)
at org.kohsuke.stapler.PreInvokeInterceptedFunction.invoke(PreInvokeInterceptedFunction.java:26)
at org.kohsuke.stapler.Function.bindAndInvoke(Function.java:167)
at org.kohsuke.stapler.Function.bindAndInvokeAndServeResponse(Function.java:100)
at org.kohsuke.stapler.IndexDispatcher.dispatch(IndexDispatcher.java:26)
at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:746)
at org.kohsuke.stapler.Stapler.invoke(Stapler.java:876)
at org.kohsuke.stapler.MetaClass$11.dispatch(MetaClass.java:380)
at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:746)
at org.kohsuke.stapler.Stapler.invoke(Stapler.java:876)
at org.kohsuke.stapler.Stapler.invoke(Stapler.java:649)
at org.kohsuke.stapler.Stapler.service(Stapler.java:238)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:812)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1669)
at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:135)
at org.jenkinsci.plugins.modernstatus.ModernStatusFilter.doFilter(ModernStatusFilter.java:52)
at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:132)
at hudson.util.PluginServletFilter.doFilter(PluginServletFilter.java:126)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
at hudson.security.csrf.CrumbFilter.doFilter(CrumbFilter.java:49)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:84)
at hudson.security.UnwrapSecurityExceptionFilter.doFilter(UnwrapSecurityExceptionFilter.java:51)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
at jenkins.security.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:117)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
at org.acegisecurity.providers.anonymous.AnonymousProcessingFilter.doFilter(AnonymousProcessingFilter.java:125)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
at org.acegisecurity.ui.rememberme.RememberMeProcessingFilter.doFilter(RememberMeProcessingFilter.java:135)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
at org.acegisecurity.ui.AbstractProcessingFilter.doFilter(AbstractProcessingFilter.java:271)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
at jenkins.security.BasicHeaderProcessor.doFilter(BasicHeaderProcessor.java:93)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
at org.acegisecurity.context.HttpSessionContextIntegrationFilter.doFilter(HttpSessionContextIntegrationFilter.java:249)
at hudson.security.HttpSessionContextIntegrationFilter2.doFilter(HttpSessionContextIntegrationFilter2.java:67)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
at hudson.security.ChainedServletFilter.doFilter(ChainedServletFilter.java:76)
at hudson.security.HudsonFilter.doFilter(HudsonFilter.java:171)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
at org.kohsuke.stapler.compression.CompressionFilter.doFilter(CompressionFilter.java:49)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
at hudson.util.CharacterEncodingFilter.doFilter(CharacterEncodingFilter.java:82)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
at org.kohsuke.stapler.DiagnosticThreadNameFilter.doFilter(DiagnosticThreadNameFilter.java:30)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:585)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:553)
at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:223)
at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1127)
at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:515)
at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1061)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97)
at org.eclipse.jetty.server.Server.handle(Server.java:499)
at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:311)
at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:257)
at org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:544)
at winstone.BoundedExecutorService$1.run(BoundedExecutorService.java:77)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
Atlassian logo

sasha@virtoway.com (JIRA)

unread,
Aug 17, 2016, 4:16:05 PM8/17/16
to jenkinsc...@googlegroups.com
Change By: Alexander Siniouguine
Issue Type: Improvement Bug

lanwen@yandex.ru (JIRA)

unread,
Aug 18, 2016, 3:43:01 PM8/18/16
to jenkinsc...@googlegroups.com

lanwen@yandex.ru (JIRA)

unread,
Aug 18, 2016, 3:57:03 PM8/18/16
to jenkinsc...@googlegroups.com

Does your github webhooks contains secret?

lanwen@yandex.ru (JIRA)

unread,
Aug 18, 2016, 4:16:01 PM8/18/16
to jenkinsc...@googlegroups.com

sasha@virtoway.com (JIRA)

unread,
Aug 18, 2016, 4:18:03 PM8/18/16
to jenkinsc...@googlegroups.com

Don't think there is a secret defined

scm_issue_link@java.net (JIRA)

unread,
Aug 19, 2016, 5:57:03 AM8/19/16
to jenkinsc...@googlegroups.com

Code changed in jenkins
User: Kirill Merkushev
Path:
src/main/java/org/jenkinsci/plugins/github/webhook/RequirePostWithGHHookPayload.java
src/test/java/org/jenkinsci/plugins/github/webhook/RequirePostWithGHHookPayloadTest.java
http://jenkins-ci.org/commit/github-plugin/05ad7b42033c549e06b71884ed7ec761cfb832fb
Log:
JENKINS-37481 Ignore sign header if sign not defined in Jenkins

scm_issue_link@java.net (JIRA)

unread,
Aug 19, 2016, 5:57:04 AM8/19/16
to jenkinsc...@googlegroups.com

Code changed in jenkins
User: Merkushev Kirill
Path:
src/main/java/org/jenkinsci/plugins/github/webhook/RequirePostWithGHHookPayload.java
src/test/java/org/jenkinsci/plugins/github/webhook/RequirePostWithGHHookPayloadTest.java
http://jenkins-ci.org/commit/github-plugin/1ffc7ce0d4d49a258d2576cbd3e8f6886251ca1f
Log:
Merge pull request #136 from lanwen/ignore_hook_not_defined

JENKINS-37481 Ignore sign header if sign not defined in Jenkins

gentoo.integer@gmail.com (JIRA)

unread,
Aug 28, 2016, 8:03:01 PM8/28/16
to jenkinsc...@googlegroups.com
Kanstantsin Shautsou resolved as Fixed
 
Change By: Kanstantsin Shautsou
Status: Open Resolved
Resolution: Fixed
Reply all
Reply to author
Forward
0 new messages