[JIRA] (JENKINS-38015) @WithPlugins fail badly in case the plugin is not available in UC

1 view
Skip to first unread message

ogondza@gmail.com (JIRA)

unread,
Sep 7, 2016, 4:17:02 AM9/7/16
to jenkinsc...@googlegroups.com
Oliver Gondža created an issue
 
Jenkins / Improvement JENKINS-38015
@WithPlugins fail badly in case the plugin is not available in UC
Issue Type: Improvement Improvement
Assignee: Oliver Gondža
Components: acceptance-test-harness
Created: 2016/Sep/07 8:16 AM
Priority: Minor Minor
Reporter: Oliver Gondža

Stacktrace:

org.jenkinsci.test.acceptance.po.UpdateCenter$InstallationFailedException: failed, see log
	at org.jenkinsci.test.acceptance.po.UpdateCenter.isInstalled(UpdateCenter.java:50)
	at org.jenkinsci.test.acceptance.po.UpdateCenter$1.call(UpdateCenter.java:73)
	at org.jenkinsci.test.acceptance.po.UpdateCenter$1.call(UpdateCenter.java:70)
	at org.jenkinsci.test.acceptance.junit.Wait$1.apply(Wait.java:78)
	at org.openqa.selenium.support.ui.FluentWait.until(FluentWait.java:238)
	at org.jenkinsci.test.acceptance.junit.Wait.until(Wait.java:74)
	at org.jenkinsci.test.acceptance.po.UpdateCenter.waitForInstallationToComplete(UpdateCenter.java:70)
	at org.jenkinsci.test.acceptance.po.PluginManager.installPlugins(PluginManager.java:206)
	at org.jenkinsci.test.acceptance.junit.WithPlugins$RuleImpl$1.doInstall(WithPlugins.java:141)
	at org.jenkinsci.test.acceptance.junit.WithPlugins$RuleImpl$1.installPlugins(WithPlugins.java:121)
	at org.jenkinsci.test.acceptance.junit.WithPlugins$RuleImpl$1.evaluate(WithPlugins.java:92)
	at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
	at org.jenkinsci.test.acceptance.junit.JenkinsAcceptanceTestRule$1$2$1.evaluate(JenkinsAcceptanceTestRule.java:172)
	at org.jenkinsci.test.acceptance.junit.FilterRule$1.evaluate(FilterRule.java:63)
	at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
	at org.jenkinsci.test.acceptance.junit.JenkinsAcceptanceTestRule$1.evaluate(JenkinsAcceptanceTestRule.java:60)
...

Stdout:

...
master54727|Sep 03, 2016 9:30:38 PM hudson.PluginManager dynamicLoad
master54727|INFO: Attempting to dynamic load /scratch/jenkins/workspace/core/acceptance-test-harness-stable/jenkins6214212410789716894home/plugins/cloudbees-folder.jpi
master54727|Sep 03, 2016 9:30:38 PM hudson.model.UpdateCenter$DownloadJob run
master54727|SEVERE: Failed to install cloudbees-folder
master54727|java.io.IOException: Failed to dynamically deploy this plugin
master54727|	at hudson.model.UpdateCenter$InstallationJob._run(UpdateCenter.java:1883)
master54727|	at hudson.model.UpdateCenter$DownloadJob.run(UpdateCenter.java:1640)
master54727|	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
master54727|	at java.util.concurrent.FutureTask.run(FutureTask.java:262)
master54727|	at hudson.remoting.AtmostOneThreadExecutor$Worker.run(AtmostOneThreadExecutor.java:110)
master54727|	at java.lang.Thread.run(Thread.java:745)
master54727|Caused by: java.io.IOException: Failed to install cloudbees-folder plugin
master54727|	at hudson.PluginManager.dynamicLoad(PluginManager.java:873)
master54727|	at hudson.PluginManager.dynamicLoad(PluginManager.java:813)
master54727|	at hudson.model.UpdateCenter$InstallationJob._run(UpdateCenter.java:1879)
master54727|	... 5 more
master54727|Caused by: java.io.IOException: Folders Plugin v5.12 failed to load.
master54727| - Credentials Plugin v1.18 is older than required. To fix, install v2.0.4 or later.
master54727|	at hudson.PluginWrapper.resolvePluginDependencies(PluginWrapper.java:621)
master54727|	at hudson.PluginManager.dynamicLoad(PluginManager.java:863)
master54727|	... 7 more
...

I lean towards failing such test with better message instead of skipping as that can mask tests referring to plugins or their versions that does not exist (typo).

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
Atlassian logo

ogondza@gmail.com (JIRA)

unread,
Sep 7, 2016, 4:18:04 AM9/7/16
to jenkinsc...@googlegroups.com
Oliver Gondža updated an issue
Change By: Oliver Gondža
Stacktrace:
{noformat}

org.jenkinsci.test.acceptance.po.UpdateCenter$InstallationFailedException: failed, see log
at org.jenkinsci.test.acceptance.po.UpdateCenter.isInstalled(UpdateCenter.java:50)
at org.jenkinsci.test.acceptance.po.UpdateCenter$1.call(UpdateCenter.java:73)
at org.jenkinsci.test.acceptance.po.UpdateCenter$1.call(UpdateCenter.java:70)
at org.jenkinsci.test.acceptance.junit.Wait$1.apply(Wait.java:78)
at org.openqa.selenium.support.ui.FluentWait.until(FluentWait.java:238)
at org.jenkinsci.test.acceptance.junit.Wait.until(Wait.java:74)
at org.jenkinsci.test.acceptance.po.UpdateCenter.waitForInstallationToComplete(UpdateCenter.java:70)
at org.jenkinsci.test.acceptance.po.PluginManager.installPlugins(PluginManager.java:206)
at org.jenkinsci.test.acceptance.junit.WithPlugins$RuleImpl$1.doInstall(WithPlugins.java:141)
at org.jenkinsci.test.acceptance.junit.WithPlugins$RuleImpl$1.installPlugins(WithPlugins.java:121)
at org.jenkinsci.test.acceptance.junit.WithPlugins$RuleImpl$1.evaluate(WithPlugins.java:92)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
at org.jenkinsci.test.acceptance.junit.JenkinsAcceptanceTestRule$1$2$1.evaluate(JenkinsAcceptanceTestRule.java:172)
at org.jenkinsci.test.acceptance.junit.FilterRule$1.evaluate(FilterRule.java:63)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
at org.jenkinsci.test.acceptance.junit.JenkinsAcceptanceTestRule$1.evaluate(JenkinsAcceptanceTestRule.java:60)
...
{noformat}

Stdout:
{noformat}

...
master54727|Sep 03, 2016 9:30:38 PM hudson.PluginManager dynamicLoad
master54727|INFO: Attempting to dynamic load /scratch/jenkins/workspace/core/acceptance-test-harness-stable/jenkins6214212410789716894home/plugins/cloudbees-folder.jpi
master54727|Sep 03, 2016 9:30:38 PM hudson.model.UpdateCenter$DownloadJob run
master54727|SEVERE: Failed to install cloudbees-folder
master54727|java.io.IOException: Failed to dynamically deploy this plugin
master54727| at hudson.model.UpdateCenter$InstallationJob._run(UpdateCenter.java:1883)
master54727| at hudson.model.UpdateCenter$DownloadJob.run(UpdateCenter.java:1640)
master54727| at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
master54727| at java.util.concurrent.FutureTask.run(FutureTask.java:262)
master54727| at hudson.remoting.AtmostOneThreadExecutor$Worker.run(AtmostOneThreadExecutor.java:110)
master54727| at java.lang.Thread.run(Thread.java:745)
master54727|Caused by: java.io.IOException: Failed to install cloudbees-folder plugin
master54727| at hudson.PluginManager.dynamicLoad(PluginManager.java:873)
master54727| at hudson.PluginManager.dynamicLoad(PluginManager.java:813)
master54727| at hudson.model.UpdateCenter$InstallationJob._run(UpdateCenter.java:1879)
master54727| ... 5 more
master54727|Caused by: java.io.IOException: Folders Plugin v5.12 failed to load.
master54727| - Credentials Plugin v1.18 is older than required. To fix, install v2.0.4 or later.
master54727| at hudson.PluginWrapper.resolvePluginDependencies(PluginWrapper.java:621)
master54727| at hudson.PluginManager.dynamicLoad(PluginManager.java:863)
master54727| ... 7 more
...
{noformat}

I lean towards failing such test with better message instead of skipping as that can mask tests referring to plugins or their versions that does not exist
and never will (typo in annotation, etc. ).

jglick@cloudbees.com (JIRA)

unread,
Sep 7, 2016, 12:04:04 PM9/7/16
to jenkinsc...@googlegroups.com
Jesse Glick commented on Improvement JENKINS-38015
 
Re: @WithPlugins fail badly in case the plugin is not available in UC

Prefer to skip in cases where a snapshot was requested. This is how I would develop tests to match proposed changes.

Reply all
Reply to author
Forward
0 new messages