[JIRA] (JENKINS-37757) NPE on XStream serialization

0 views
Skip to first unread message

amuniz@cloudbees.com (JIRA)

unread,
Aug 29, 2016, 6:57:02 AM8/29/16
to jenkinsc...@googlegroups.com
Antonio Muñiz created an issue
 
Jenkins / Bug JENKINS-37757
NPE on XStream serialization
Issue Type: Bug Bug
Assignee: Unassigned
Components: core
Created: 2016/Aug/29 10:56 AM
Labels: xstream
Priority: Major Major
Reporter: Antonio Muñiz

Under some conditions (that I'm failing to diagnose) Converter.canConvert(Class type) is being called with null as argument on a converter which is not `NullConverter`, those calls lead to {{NullPointerException}}s.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
Atlassian logo

amuniz@cloudbees.com (JIRA)

unread,
Aug 29, 2016, 6:58:03 AM8/29/16
to jenkinsc...@googlegroups.com
Antonio Muñiz started work on Bug JENKINS-37757
 
Change By: Antonio Muñiz
Status: Open In Progress

amuniz@cloudbees.com (JIRA)

unread,
Aug 29, 2016, 6:58:04 AM8/29/16
to jenkinsc...@googlegroups.com
Antonio Muñiz assigned an issue to Antonio Muñiz
Change By: Antonio Muñiz
Assignee: Antonio Muñiz

amuniz@cloudbees.com (JIRA)

unread,
Aug 29, 2016, 6:59:03 AM8/29/16
to jenkinsc...@googlegroups.com
Antonio Muñiz updated an issue
Under some conditions (that I'm failing to diagnose) {{Converter.canConvert(Class type)}} is being called with {{null}} as argument on a converter which is not ` {{ NullConverter ` }} , those calls lead to {{NullPointerException}}s.

dbeck@cloudbees.com (JIRA)

unread,
Aug 30, 2016, 9:12:04 AM8/30/16
to jenkinsc...@googlegroups.com
Daniel Beck commented on Bug JENKINS-37757
 
Re: NPE on XStream serialization

Do you at least have stack traces?

amuniz@cloudbees.com (JIRA)

unread,
Aug 31, 2016, 2:51:01 PM8/31/16
to jenkinsc...@googlegroups.com

Yes:

java.lang.NullPointerException
  at java.lang.Class.isAssignableFrom(Native Method)
  at com.thoughtworks.xstream.converters.reflection.ExternalizableConverter.canConvert(ExternalizableConverter.java:73)
  at com.thoughtworks.xstream.core.DefaultConverterLookup.registerConverter(DefaultConverterLookup.java:74)
  at com.thoughtworks.xstream.XStream$2.registerConverter(XStream.java:502)
  ...

This is after a XStream constructor call, in one of the registerConverter call in the construction chain.

scm_issue_link@java.net (JIRA)

unread,
Sep 29, 2016, 6:14:01 AM9/29/16
to jenkinsc...@googlegroups.com

Code changed in jenkins
User: Oleg Nenashev
Path:
xstream/src/java/com/thoughtworks/xstream/core/DefaultConverterLookup.java
http://jenkins-ci.org/commit/xstream/8b101d44c69a1fc46d8020930502e22544ffbc2a
Log:
Merge pull request #5 from amuniz/fix-npe

JENKINS-37757 Protection against NullPointerException

Compare: https://github.com/jenkinsci/xstream/compare/d3a5bd430863...8b101d44c69a

o.v.nenashev@gmail.com (JIRA)

unread,
Mar 12, 2017, 7:55:01 AM3/12/17
to jenkinsc...@googlegroups.com

Antonio Muñiz any plans to get the fix released?

This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages