[JIRA] [core] (JENKINS-34548) InjectedTest failure: github plugin fails to start

11 views
Skip to first unread message

vivek.pandey@gmail.com (JIRA)

unread,
May 2, 2016, 6:13:01 PM5/2/16
to jenkinsc...@googlegroups.com
Vivek Pandey created an issue
 
Jenkins / Bug JENKINS-34548
InjectedTest failure: github plugin fails to start
Issue Type: Bug Bug
Assignee: Kirill Merkushev
Components: core, github-plugin
Created: 2016/May/02 10:12 PM
Environment: ubuntu:15.04, run inside docker container
Priority: Minor Minor
Reporter: Vivek Pandey

Our plugin has maven dependency on github plugin. 

        <dependency>
            <groupId>org.jenkins-ci.plugins</groupId>
            <artifactId>git</artifactId>
            <version>2.4.2</version>
        </dependency>

InjectedTest are run during test run and it fails with the following error. Failure is random so not easy to reproduce.

Running InjectedTest
Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 9.611 sec <<< FAILURE! - in InjectedTest
testPluginActive(org.jvnet.hudson.test.PluginAutomaticTestBuilder$OtherTests)  Time elapsed: 0.086 sec  <<< ERROR!
java.lang.Error: Plugin github failed to start
  at org.jvnet.hudson.test.PluginAutomaticTestBuilder$OtherTests.testPluginActive(PluginAutomaticTestBuilder.java:92)
Caused by: java.lang.NullPointerException

Tests run: 22, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 105.824 sec - in io.jenkins.blueocean.service.embedded.PipelineApiTest

Results :

Tests in error: 
  PluginAutomaticTestBuilder$OtherTests.testPluginActive:92  Plugin github faile...
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
Atlassian logo

lanwen@yandex.ru (JIRA)

unread,
May 3, 2016, 11:35:01 AM5/3/16
to jenkinsc...@googlegroups.com
 <dependency>
            <groupId>org.jenkins-ci.plugins</groupId>
            <artifactId>git</artifactId>
            <version>2.4.2</version>
</dependency>

is not github plugin

vivek.pandey@gmail.com (JIRA)

unread,
May 3, 2016, 12:09:01 PM5/3/16
to jenkinsc...@googlegroups.com
Vivek Pandey updated an issue
 
Change By: Vivek Pandey
Our plugin has maven dependency on github plugin. 

{code:xml}
        <dependency>
            <groupId>org.jenkins-ci.plugins</groupId>
            <artifactId> git github-branch-source </artifactId>
            <version> 2 1 . 4.2 6 </version>
        </dependency>
{code}

 Project dependency tree shows github-branch-source plugin has dependency on github plugin, that fails to load during InjectedTest  run.

{code}
[INFO] +- org.jenkins-ci.plugins:github-branch-source:jar:1.6:compile
[INFO] |  +- org.jenkins-ci.plugins:github-api:jar:1.75:compile
[INFO] |  |  +- org.kohsuke:github-api:jar:1.72:compile
[INFO] |  |  \- com.squareup.okhttp:okhttp-urlconnection:jar:2.5.0:compile
[INFO] |  |     \- com.squareup.okhttp:okhttp:jar:2.5.0:compile
[INFO] |  |        \- com.squareup.okio:okio:jar:1.6.0:compile
[INFO] |  \- com.coravy.hudson.plugins.github:github:jar:1.14.0:compile
[INFO] |     +- org.apache.commons:commons-lang3:jar:3.4:compile
[INFO] |     \- org.jenkins-ci.plugins:plain-credentials:jar:1.1:compile
{code}

InjectedTest  are run during test run and it fails with the following error. Failure is random so not easy to reproduce.

{code:java}

Running InjectedTest
Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 9.611 sec <<< FAILURE! - in InjectedTest
testPluginActive(org.jvnet.hudson.test.PluginAutomaticTestBuilder$OtherTests)  Time elapsed: 0.086 sec  <<< ERROR!
java.lang.Error: Plugin github failed to start
  at org.jvnet.hudson.test.PluginAutomaticTestBuilder$OtherTests.testPluginActive(PluginAutomaticTestBuilder.java:92)
Caused by: java.lang.NullPointerException

Tests run: 22, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 105.824 sec - in io.jenkins.blueocean.service.embedded.PipelineApiTest

Results :

Tests in error: 
  PluginAutomaticTestBuilder$OtherTests.testPluginActive:92  Plugin github faile...
{code}

vivek.pandey@gmail.com (JIRA)

unread,
May 3, 2016, 12:12:02 PM5/3/16
to jenkinsc...@googlegroups.com
Vivek Pandey commented on Bug JENKINS-34548
 
Re: InjectedTest failure: github plugin fails to start

Sorry about that, provided more details in the original description. Basically github-branch-source plugin has transitive dependency on github plugin. At one time we also had github plugin explicitly defined in our pom (to use newer version in hope this random load failure will go away) but it didn't help so we have only github-branch-source that reproduces the problem.

lanwen@yandex.ru (JIRA)

unread,
May 3, 2016, 12:31:04 PM5/3/16
to jenkinsc...@googlegroups.com

How did you defined github-plugin dependency in pom (before after dep to github-branch-source)? What is your core version?

vivek.pandey@gmail.com (JIRA)

unread,
May 3, 2016, 1:42:01 PM5/3/16
to jenkinsc...@googlegroups.com

In this case there is no explicit dependency defined. Its pulled in via transitive dependency of github-branch-source plugin ver 1.14.

In past we tried defining github plugin ver 1.18.2 and 1.19 together with github-branch-source but then removed explicit dependency on github.

lanwen@yandex.ru (JIRA)

unread,
May 3, 2016, 2:05:01 PM5/3/16
to jenkinsc...@googlegroups.com

yep, i know that branch-source has transitive dep. My question is how you have tried to override it (exactly)? And what core version do you have?

vivek.pandey@gmail.com (JIRA)

unread,
May 3, 2016, 3:22:01 PM5/3/16
to jenkinsc...@googlegroups.com

Its plugin version 2.6 and core 1.652.

I think I was not clear, we do not override github plugin dependency. It gets included transitively from github-branch-source. Basically just defining dependency on github-branch-source demonstrates this issue.

In the past we did override github plugin version with version 1.18.2 and this problem was present even then. The dependency was defined as:

        <dependency>
            <groupId>org.jenkins-ci.plugins</groupId>
            <artifactId>github-branch-source</artifactId>
            <version>1.5</version>
        </dependency>
        <dependency>
            <groupId>com.coravy.hudson.plugins.github</groupId>
            <artifactId>github</artifactId>
            <version>1.18.2</version>
        </dependency>

Hope it helps.

lanwen@yandex.ru (JIRA)

unread,
May 3, 2016, 3:29:01 PM5/3/16
to jenkinsc...@googlegroups.com

When you define dependency to github AFTER branch-source - you actually don't override it. Nothing changes. Please try to define first github dep and then branch-source. (see maven docs for explanation).

vivek.pandey@gmail.com (JIRA)

unread,
May 3, 2016, 4:42:02 PM5/3/16
to jenkinsc...@googlegroups.com

As I mentioned, we don't have explicit dependency on github plugin, only github-branch-source and there is this error so not sure what you are asking me to do.

lanwen@yandex.ru (JIRA)

unread,
May 3, 2016, 4:51:01 PM5/3/16
to jenkinsc...@googlegroups.com

github-branch-source has very old dep to github-plugin which may not work with latest core. But when you tried to override github dep manually, you've done it wrong. The order of dependencies in maven matters a lot. So i just ask you to check overriding in correct order.

lanwen@yandex.ru (JIRA)

unread,
May 3, 2016, 4:53:01 PM5/3/16
to jenkinsc...@googlegroups.com
Kirill Merkushev edited a comment on Bug JENKINS-34548
github-branch-source has very old dep to github-plugin which may not work with latest core. But when you tried to override github dep manually, you've done it wrong. The order of dependencies in maven matters a lot. So i just ask you to check overriding in correct order.


And if you don't use directly github plugin please don't fill github-plugin component next time.

lanwen@yandex.ru (JIRA)

unread,
May 3, 2016, 4:53:01 PM5/3/16
to jenkinsc...@googlegroups.com
Kirill Merkushev updated an issue
 
Change By: Kirill Merkushev
Component/s: github-branch-source-plugin
Component/s: core

lanwen@yandex.ru (JIRA)

unread,
May 3, 2016, 4:54:01 PM5/3/16
to jenkinsc...@googlegroups.com
Kirill Merkushev updated an issue
Our plugin has maven dependency on github -branch-source  plugin. 

{code:xml}

         <dependency>
            <groupId>org.jenkins-ci.plugins</groupId>
            <artifactId>github-branch-source</artifactId>
            <version>1.6</version>

vivek.pandey@gmail.com (JIRA)

unread,
May 3, 2016, 5:10:01 PM5/3/16
to jenkinsc...@googlegroups.com

recena@gmail.com (JIRA)

unread,
May 5, 2016, 3:58:03 AM5/5/16
to jenkinsc...@googlegroups.com

Kirill Merkushev

  1. github-branch-source has a dependency with github:1.14.0
  2. github-branch-source requires at least, Jenkins core 1.609.3
  3. github requieres at least 1.580

If github had any trouble with latest core, this should be happen too in github tests, right?

Vivek Panday

Why do not you add an exclude to github in the definition of the dependency to github-branch-source?

jglick@cloudbees.com (JIRA)

unread,
May 24, 2016, 2:49:01 PM5/24/16
to jenkinsc...@googlegroups.com
Jesse Glick resolved as Cannot Reproduce
 

Whatever the original error was, it would need to be diagnosed before it is useful to file an issue.
Change By: Jesse Glick
Status: Open Resolved
Resolution: Cannot Reproduce
Reply all
Reply to author
Forward
0 new messages