[JIRA] [cloudbees-folder-plugin] (JENKINS-33479) NPE from AbstractFolder.getView

1 view
Skip to first unread message

jglick@cloudbees.com (JIRA)

unread,
Mar 11, 2016, 7:39:01 AM3/11/16
to jenkinsc...@googlegroups.com
Jesse Glick created an issue
 
Jenkins / Bug JENKINS-33479
NPE from AbstractFolder.getView
Issue Type: Bug Bug
Assignee: Jesse Glick
Components: cloudbees-folder-plugin
Created: 11/Mar/16 12:38 PM
Labels: 2.0
Priority: Major Major
Reporter: Jesse Glick

After Kohsuke Kawaguchi's work on github-organization-folder, we get

java.lang.NullPointerException
	at com.cloudbees.hudson.plugins.folder.AbstractFolder.getView(AbstractFolder.java:380)
	at org.jenkinsci.plugins.orgfolder.github.MainLogic.applyRepo(MainLogic.java:121)
	at org.jenkinsci.plugins.orgfolder.github.ItemListenerImpl.maybeApply(ItemListenerImpl.java:44)
	at org.jenkinsci.plugins.orgfolder.github.ItemListenerImpl.onUpdated(ItemListenerImpl.java:27)
	at hudson.model.listeners.ItemListener$3.apply(ItemListener.java:195)
	at hudson.model.listeners.ItemListener$3.apply(ItemListener.java:193)
	at hudson.model.listeners.ItemListener.forAll(ItemListener.java:167)
	at hudson.model.listeners.ItemListener.fireOnUpdated(ItemListener.java:193)
	at com.cloudbees.hudson.plugins.folder.AbstractFolder.save(AbstractFolder.java:646)
	at hudson.model.View.save(View.java:334)
	at com.cloudbees.hudson.plugins.folder.AbstractFolder.initViews(AbstractFolder.java:236)
	at com.cloudbees.hudson.plugins.folder.AbstractFolder.init(AbstractFolder.java:196)
	at com.cloudbees.hudson.plugins.folder.computed.ComputedFolder.init(ComputedFolder.java:110)
	at com.cloudbees.hudson.plugins.folder.computed.ComputedFolder.<init>(ComputedFolder.java:105)
	at jenkins.branch.MultiBranchProject.<init>(MultiBranchProject.java:114)
	at ...

since getView is unexpectedly being called from inside initViews, when viewGroupMixIn is not yet set.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
Atlassian logo

jglick@cloudbees.com (JIRA)

unread,
Mar 11, 2016, 10:09:02 AM3/11/16
to jenkinsc...@googlegroups.com
Jesse Glick started work on Bug JENKINS-33479
 
Change By: Jesse Glick
Status: Open In Progress

scm_issue_link@java.net (JIRA)

unread,
Mar 11, 2016, 4:58:02 PM3/11/16
to jenkinsc...@googlegroups.com
SCM/JIRA link daemon commented on Bug JENKINS-33479
 
Re: NPE from AbstractFolder.getView

Code changed in jenkins
User: Jesse Glick
Path:
src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java
http://jenkins-ci.org/commit/cloudbees-folder-plugin/6537ed139bd84668a9da5d9fdac37318eb1448de
Log:
[FIXED JENKINS-33479] NPE caused by accessing viewGroupMixIn inside ctor before it was actually set.

scm_issue_link@java.net (JIRA)

unread,
Mar 11, 2016, 4:58:03 PM3/11/16
to jenkinsc...@googlegroups.com

Code changed in jenkins
User: Jesse Glick
Path:
src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java

scm_issue_link@java.net (JIRA)

unread,
Mar 11, 2016, 4:58:03 PM3/11/16
to jenkinsc...@googlegroups.com
SCM/JIRA link daemon resolved as Fixed
Change By: SCM/JIRA link daemon
Status: In Progress Resolved
Resolution: Fixed

scm_issue_link@java.net (JIRA)

unread,
Mar 16, 2016, 10:11:01 AM3/16/16
to jenkinsc...@googlegroups.com

Code changed in jenkins
User: Jesse Glick
Path:
src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java

http://jenkins-ci.org/commit/cloudbees-folder-plugin/4d316b9c67ee76c4507467b9b89850adc884ad12
Log:
Merge pull request #41 from jglick/initViews-no-save

JENKINS-33479 JENKINS-33480 Avoid calling `save` from within our own constructor

Compare: https://github.com/jenkinsci/cloudbees-folder-plugin/compare/8669336a8f43...4d316b9c67ee

Reply all
Reply to author
Forward
0 new messages