[JIRA] (JENKINS-41825) Page loads breaks when View.getItems fails

13 views
Skip to first unread message

jglick@cloudbees.com (JIRA)

unread,
Feb 7, 2017, 1:19:01 PM2/7/17
to jenkinsc...@googlegroups.com
Jesse Glick started work on Bug JENKINS-41825
 
Change By: Jesse Glick
Status: Open In Progress
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
Atlassian logo

jglick@cloudbees.com (JIRA)

unread,
Feb 7, 2017, 1:19:01 PM2/7/17
to jenkinsc...@googlegroups.com
Jesse Glick created an issue
 
Jenkins / Bug JENKINS-41825
Page loads breaks when View.getItems fails
Issue Type: Bug Bug
Assignee: Jesse Glick
Components: core
Created: 2017/Feb/07 6:18 PM
Labels: lts-candidate robustness
Priority: Minor Minor
Reporter: Jesse Glick

It is not uncommon for an error to be thrown from View.getItems. Currently Jenkins behaves poorly in this case: it displays an "oops" page with a cryptic stack trace

java.lang.NullPointerException: Cannot invoke method isEmpty() on null object
at org.codehaus.groovy.runtime.NullObject.invokeMethod(NullObject.java:77)
at org.codehaus.groovy.runtime.callsite.PogoMetaClassSite.call(PogoMetaClassSite.java:45)
at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:42)
at org.codehaus.groovy.runtime.callsite.NullCallSite.call(NullCallSite.java:32)
at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:42)
at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:108)
at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:112)
at hudson.model.View.main.run(main.groovy:6)

that has no relation to the real error.

jglick@cloudbees.com (JIRA)

unread,
Feb 7, 2017, 1:20:01 PM2/7/17
to jenkinsc...@googlegroups.com
Jesse Glick commented on Bug JENKINS-41825
 
Re: Page loads breaks when View.getItems fails

Linking to some examples of this, but from this search you can see there at least a dozen cases.

jglick@cloudbees.com (JIRA)

unread,
Feb 7, 2017, 1:23:01 PM2/7/17
to jenkinsc...@googlegroups.com

scm_issue_link@java.net (JIRA)

unread,
Feb 9, 2017, 5:26:02 PM2/9/17
to jenkinsc...@googlegroups.com
SCM/JIRA link daemon commented on Bug JENKINS-41825
 
Re: Page loads breaks when View.getItems fails

Code changed in jenkins
User: Jesse Glick
Path:
core/src/main/resources/hudson/model/View/main.groovy
core/src/main/resources/hudson/model/View/main.properties
test/src/test/java/hudson/model/ViewTest.java
http://jenkins-ci.org/commit/jenkins/fcf4ca7697b4a5293c95b221669f202621b178f7
Log:
[FIXED JENKINS-41825] Display an informative message, rather than a Groovy exception, when View.getItems fails.

jglick@cloudbees.com (JIRA)

unread,
Feb 10, 2017, 10:48:01 AM2/10/17
to jenkinsc...@googlegroups.com
Change By: Jesse Glick
Status: In Review Resolved
Resolution: Fixed

ogondza@gmail.com (JIRA)

unread,
Feb 15, 2017, 8:44:02 AM2/15/17
to jenkinsc...@googlegroups.com
Oliver Gondža updated an issue
Change By: Oliver Gondža
Labels: lts 2.32.3 - candidate fixed robustness

scm_issue_link@java.net (JIRA)

unread,
Feb 15, 2017, 9:05:03 AM2/15/17
to jenkinsc...@googlegroups.com

Code changed in jenkins
User: Jesse Glick
Path:
core/src/main/resources/hudson/model/View/main.groovy
core/src/main/resources/hudson/model/View/main.properties
test/src/test/java/hudson/model/ViewTest.java


Log:
[FIXED JENKINS-41825] Display an informative message, rather than a Groovy exception, when View.getItems fails.

(cherry picked from commit fcf4ca7697b4a5293c95b221669f202621b178f7)

Reply all
Reply to author
Forward
0 new messages