[JIRA] (JENKINS-37329) Bug in StatsMath.java DecimalFormat

[roropx3@googlemail.com (JIRA)]

Rolf Rother created an issue

Jenkins / JENKINS-37329 Bug in StatsMath.java DecimalFormat Issue Type: Bug Assignee: Yoann Dubreuil Components: build-metrics-plugin Created: 2016/Aug/11 7:09 AM Priority: Critical Reporter: Rolf Rother The implementation in statsmath.java results in an NumberFormatException when then LANG for the VM is set to another than EN: Caused by: java.lang.NumberFormatException: For input string: "19,16" at sun.misc.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:2043) at sun.misc.FloatingDecimal.parseDouble(FloatingDecimal.java:110) at java.lang.Double.parseDouble(Double.java:538) at java.lang.Double.valueOf(Double.java:502) at jenkins.plugins.build_metrics.stats.StatsMath.roundTwoDecimals(StatsMath.java:13) at jenkins.plugins.build_metrics.stats.StatsMath.getPercent(StatsMath.java:8) at jenkins.plugins.build_metrics.stats.StatsFactory.getFailureRate(StatsFactory.java:167) ... 135 more Please change: public static double roundTwoDecimals(double iVal) { DecimalFormat twoDForm = new DecimalFormat("#.##"); return Double.valueOf(twoDForm.format(iVal)); } to: public static double roundTwoDecimals(double iVal) { DecimalFormatSymbols decimalFormatSymbols = new DecimalFormatSymbols(Locale.getDefault()); DecimalFormat twoDForm = new DecimalFormat("#"+decimalFormatSymbols.getDecimalSeparator()+"##",decimalFormatSymbols); return Double.valueOf(twoDForm.format(iVal)); } Thanks Add Comment

This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)

[roropx3@googlemail.com (JIRA)]

Rolf Rother assigned an issue to Rolf Rother

Jenkins / JENKINS-37329 Bug in StatsMath.java DecimalFormat

Change By: Rolf Rother Assignee: Yoann Dubreuil Rolf Rother

Add Comment

[roropx3@googlemail.com (JIRA)]

Rolf Rother commented on JENKINS-37329

Re: Bug in StatsMath.java DecimalFormat Fixed and will be included in the next release

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-37329

Re: Bug in StatsMath.java DecimalFormat

Code changed in jenkins User: Rolf Rother Path: src/main/java/jenkins/plugins/build_metrics/stats/StatsMath.java http://jenkins-ci.org/commit/build-metrics-plugin/20d0608baaf25b94d5f13b3cd64bf6c1cc246d36 Log: [FIXED JENKINS-37329] Fixed DecimalFormat problem with VM language settings other than EN

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon resolved as Fixed

Jenkins / JENKINS-37329 Bug in StatsMath.java DecimalFormat

Change By: SCM/JIRA link daemon Status: Open Resolved Resolution: Fixed

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-37329

Re: Bug in StatsMath.java DecimalFormat

Code changed in jenkins User: Rolf Rother Path: src/main/java/jenkins/plugins/build_metrics/stats/StatsMath.java

src/test/java/jenkins/plugins/build_metrics/stats/StatsMathTest.java http://jenkins-ci.org/commit/build-metrics-plugin/b4486c4ae1a216e48029d36708c9fcb47be2f4f3 Log: Revert "JENKINS-37329 - Changed caluclation of RoundDecimal again." This reverts commit f22fe982feb30c5566eb665b423a6bb2806ed022.

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-37329

Re: Bug in StatsMath.java DecimalFormat

Code changed in jenkins User: Rolf Rother Path: src/main/java/jenkins/plugins/build_metrics/stats/StatsMath.java src/test/java/jenkins/plugins/build_metrics/stats/StatsMathTest.java

http://jenkins-ci.org/commit/build-metrics-plugin/f22fe982feb30c5566eb665b423a6bb2806ed022 Log:

JENKINS-37329 - Changed caluclation of RoundDecimal again.

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-37329

Re: Bug in StatsMath.java DecimalFormat

Code changed in jenkins User: Rolf Rother Path:

src/main/java/jenkins/plugins/build_metrics/stats/StatsFactory.java src/main/java/jenkins/plugins/build_metrics/stats/StatsMath.java src/main/java/jenkins/plugins/build_metrics/stats/StatsModel.java src/main/resources/jenkins/plugins/build_metrics/BuildMetricsPlugin/BuildStats.jelly http://jenkins-ci.org/commit/build-metrics-plugin/8ace1d0873af1ae523ebc25d7c269bd7ba048de8 Log: Revert "JENKINS-37329 - Changed caluclation of RoundDecimal again." This reverts commit f22fe982feb30c5566eb665b423a6bb2806ed022.

Add Comment