[JIRA] [drupal-developer-plugin] (JENKINS-35544) coder review

4 views
Skip to first unread message

jarodriguez@emergya.com (JIRA)

unread,
Jun 10, 2016, 5:42:02 AM6/10/16
to jenkinsc...@googlegroups.com
José Antonio Rodríguez created an issue
 
Jenkins / Bug JENKINS-35544
coder review
Issue Type: Bug Bug
Assignee: Feng Tan
Components: drupal-developer-plugin
Created: 2016/Jun/10 9:41 AM
Environment: Jenkins versión: 2.8
Installed plugins: Drupal development
System: Debian 7
Drush version: 7.1.0
PHP Version: 5.5
Priority: Blocker Blocker
Reporter: José Antonio Rodríguez

When I try execute The Coder review in a Drupal Installation (Version 7), I have the follow error:

Started by user Administrador
Building in workspace /var/lib/jenkins/prueba/www
[DRUPAL] Drush executable 'null' from installation 'Default' could not be found, fall back to 'drush'
[www] $ drush --yes --nocolor --root=/var/lib/jenkins/prueba/www pm-list --pipe --format=json --type=module
ERROR: Build step failed with exception
java.lang.NullPointerException
at org.jenkinsci.plugins.drupal.beans.DrushInvocation.getProjects(DrushInvocation.java:222)
at org.jenkinsci.plugins.drupal.beans.DrushInvocation.isModuleInstalled(DrushInvocation.java:233)
at org.jenkinsci.plugins.drupal.builders.DrupalReviewBuilder.perform(DrupalReviewBuilder.java:98)
at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:779)
at hudson.model.Build$BuildExecution.build(Build.java:205)
at hudson.model.Build$BuildExecution.doRun(Build.java:162)
at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:534)
at hudson.model.Run.execute(Run.java:1741)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:410)
Build step 'Review code on Drupal' marked build as failure
Finished: FAILURE
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
Atlassian logo

thomas1702@gmail.com (JIRA)

unread,
Jun 10, 2016, 10:25:01 AM6/10/16
to jenkinsc...@googlegroups.com
Feng Tan commented on Bug JENKINS-35544
 
Re: coder review

What happens when you open a shell and run this command:


drush --yes --nocolor --root=/var/lib/jenkins/prueba/www pm-list --pipe --format=json --type=module

?

romain.boutonnet@gmail.com (JIRA)

unread,
Jun 13, 2016, 4:03:02 AM6/13/16
to jenkinsc...@googlegroups.com
Romain boutonnet commented on Bug JENKINS-35544
 
Re: coder review

I have the same problem (drush 7.4 | debian 8 | jenkins 2.8 | php 5.6) :

[Drupal] $ /usr/local/src/drush/drush --yes --nocolor --root=/var/lib/jenkins/workspace/Drupal/src pm-list --pipe --format=json --type=module


ERROR: Build step failed with exception
java.lang.NullPointerException
at org.jenkinsci.plugins.drupal.beans.DrushInvocation.getProjects(DrushInvocation.java:222)
at org.jenkinsci.plugins.drupal.beans.DrushInvocation.isModuleInstalled(DrushInvocation.java:233)
at org.jenkinsci.plugins.drupal.builders.DrupalReviewBuilder.perform(DrupalReviewBuilder.java:98)
at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:779)
at hudson.model.Build$BuildExecution.build(Build.java:205)
at hudson.model.Build$BuildExecution.doRun(Build.java:162)
at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:534)
at hudson.model.Run.execute(Run.java:1741)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:410)
Build step 'Review code on Drupal' marked build as failure
Finished: FAILURE

When i run this command :drush --yes --nocolor --root=/var/lib/jenkins/workspace/Drupal/src pm-list --pipe --format=json --type=module

I have the list of modules in json format :
{
"actions_permissions":

{ "package": "Administration", "name": "Actions permissions (VBO) (actions_permissions)", "type": "Module", "status": "Not installed", "version": "7.x-3.3" }

,
"admin_devel":

{ "package": "Administration", "name": "Administration Development tools (admin_devel)", "type": "Module", "status": "Not installed", "version": "7.x-3.0-rc5" }

,
.........

thomas1702@gmail.com (JIRA)

unread,
Jun 13, 2016, 12:23:01 PM6/13/16
to jenkinsc...@googlegroups.com
Feng Tan commented on Bug JENKINS-35544
 
Re: coder review

Which version of Drupal do you use ?

What is the full output of drush --yes --nocolor --root=/var/lib/jenkins/workspace/Drupal/src pm-list --pipe --format=json --type=module ?

jarodriguez@emergya.com (JIRA)

unread,
Jun 14, 2016, 4:42:01 AM6/14/16
to jenkinsc...@googlegroups.com
José Antonio Rodríguez commented on Bug JENKINS-35544
 
Re: coder review

I have tested with Drush 6.7.0 and 7.2.0, with the same error.

This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
Atlassian logo

jvoisin@bashrc.fr (JIRA)

unread,
Jul 16, 2016, 12:58:01 PM7/16/16
to jenkinsc...@googlegroups.com
jeremy voisin commented on Bug JENKINS-35544
 
Re: coder review

Hi all,

Same problem on Centos 7, drush 7.3.0, Jenkins 2.13. The command /usr/local/bin/drush --yes --nocolor --root=/var/lib/jenkins/jobs/Drupal-dev/workspace/drupal pm-list --pipe --format=json --type=module is in error in the job log but works on the server as jenkins using cli.

Jérémy

jenkins@michaelpporter.com (JIRA)

unread,
Aug 1, 2016, 9:57:01 AM8/1/16
to jenkinsc...@googlegroups.com
Michael Porter updated an issue
Change By: Michael Porter
Attachment: drushoutput.txt

jenkins@michaelpporter.com (JIRA)

unread,
Aug 1, 2016, 9:58:01 AM8/1/16
to jenkinsc...@googlegroups.com
Michael Porter commented on Bug JENKINS-35544
 
Re: coder review

echoing the error...

  • Jenkins 2.16
  • Drupal 7.50
  • Drush 8.1.2 and 7.0.0-rc2
  • Ubuntu 14.04
  • Apache Webserver for Drupal site.
  • Output of /var/lib/jenkins/tools/drush/drush --yes --nocolor --root=/var/www/execadv/www pm-list --pipe --format=json --type=module --status=enabled drushoutput.txt

scm_issue_link@java.net (JIRA)

unread,
Aug 1, 2016, 11:07:07 PM8/1/16
to jenkinsc...@googlegroups.com
SCM/JIRA link daemon commented on Bug JENKINS-35544
 
Re: coder review

Code changed in jenkins
User: Fengtan 冯坦
Path:
src/main/java/org/jenkinsci/plugins/drupal/beans/DrushInvocation.java
http://jenkins-ci.org/commit/drupal-developer-plugin/7e538e8b494a79ff2c6446ab2974055cc645123e
Log:
JENKINS-35544 Fix NPE when module has no version.

thomas1702@gmail.com (JIRA)

unread,
Aug 1, 2016, 11:14:01 PM8/1/16
to jenkinsc...@googlegroups.com
Feng Tan commented on Bug JENKINS-35544
 
Re: coder review

Michael Porter: thanks for providing the output of the drush command !

It looks like the problem is caused by Drupal modules that do not have any version in their .info file. I have commited a fix – see message above. If some of you folks could test the fix that would be awesome !

jenkins@michaelpporter.com (JIRA)

unread,
Aug 2, 2016, 9:21:01 AM8/2/16
to jenkinsc...@googlegroups.com
Michael Porter updated an issue
Change By: Michael Porter
Attachment: About_Drupal_Developer__Jenkins_.png

jenkins@michaelpporter.com (JIRA)

unread,
Aug 2, 2016, 9:23:02 AM8/2/16
to jenkinsc...@googlegroups.com
Michael Porter commented on Bug JENKINS-35544
 
Re: coder review

Maybe I installed it wrong, same error:

That changed the time stamp on /var/lib/jenkins/plugins/drupal-developer.jpi
ran tests, it failed.

I copied [home]/drupal-developer-plugin/target/drupal-developer/META-INF and WEB-INF (leaving /var/lib/jenkins/plugins/drupal-developer/META-INF/maven)
ran tests, it failed.

Jenkins shows the id as 0.7-SNAPSHOT (see attached image)

mvn -version
Apache Maven 3.0.5
Maven home: /usr/share/maven
Java version: 1.7.0_80, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-7-oracle/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "3.13.0-85-generic", arch: "amd64", family: "unix"

/var/lib/jenkins/tools/drush/drush --yes --nocolor --root=/var/www/execadv/www pm-list --pipe --format=json --type=module

ERROR: Build step failed with exception
java.lang.NullPointerException
at org.jenkinsci.plugins.drupal.beans.DrushInvocation.getProjects(DrushInvocation.java:222)
at org.jenkinsci.plugins.drupal.beans.DrushInvocation.isModuleInstalled(DrushInvocation.java:233)
at org.jenkinsci.plugins.drupal.builders.DrupalReviewBuilder.perform(DrupalReviewBuilder.java:98)
at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:779)
at hudson.model.Build$BuildExecution.build(Build.java:205)
at hudson.model.Build$BuildExecution.doRun(Build.java:162)
at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:534)

at hudson.model.Run.execute(Run.java:1720)


at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)

at hudson.model.Executor.run(Executor.java:404)


Build step 'Review code on Drupal' marked build as failure

jenkins@michaelpporter.com (JIRA)

unread,
Aug 2, 2016, 10:42:05 AM8/2/16
to jenkinsc...@googlegroups.com
 
Re: coder review

Running on a clean Drupal setup of 7.50 with an apache site for the build works fine.

thomas1702@gmail.com (JIRA)

unread,
Aug 2, 2016, 9:18:02 PM8/2/16
to jenkinsc...@googlegroups.com
Feng Tan commented on Bug JENKINS-35544
 
Re: coder review

The title of the screenshot suggests that you are still using version 0.6.
Maybe uninstall the plugin, restart jenkins and then re-install version 0.7.

jenkins@michaelpporter.com (JIRA)

unread,
Aug 2, 2016, 10:38:01 PM8/2/16
to jenkinsc...@googlegroups.com
Michael Porter commented on Bug JENKINS-35544
 
Re: coder review

That fixed it. Thanks.

Had to restart after the install too.

thomas1702@gmail.com (JIRA)

unread,
Aug 12, 2016, 9:00:05 PM8/12/16
to jenkinsc...@googlegroups.com
Feng Tan closed an issue as Fixed
 

Rolled the fix into new release drupal-developer-0.8.
Change By: Feng Tan
Status: Open Closed
Resolution: Fixed
Reply all
Reply to author
Forward
0 new messages