[JIRA] [workflow-plugin] (JENKINS-28673) ISE from BuildTriggerListener.onDeleted

2 views
Skip to first unread message

jglick@cloudbees.com (JIRA)

unread,
Jun 1, 2015, 9:29:01 AM6/1/15
to jenkinsc...@googlegroups.com
Jesse Glick created an issue
 
Jenkins / Bug JENKINS-28673
ISE from BuildTriggerListener.onDeleted
Issue Type: Bug Bug
Assignee: Jesse Glick
Components: workflow-plugin
Created: 01/Jun/15 1:28 PM
Priority: Major Major
Reporter: Jesse Glick

Observed in a log file from 1.4 on 1.580.3:

... hudson.model.listeners.RunListener report
WARNING: RunListener failed
java.lang.IllegalStateException: broken flow
    at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.runInCpsVmThread(CpsFlowExecution.java:506)
    at org.jenkinsci.plugins.workflow.cps.CpsStepContext.scheduleNextRun(CpsStepContext.java:343)
    at org.jenkinsci.plugins.workflow.cps.CpsStepContext.onFailure(CpsStepContext.java:313)
    at org.jenkinsci.plugins.workflow.support.steps.build.BuildTriggerListener.onDeleted(BuildTriggerListener.java:33)
    at hudson.model.listeners.RunListener.fireDeleted(RunListener.java:244)
    at hudson.model.Run.delete(Run.java:1488)
    at hudson.maven.MavenModuleSetBuild.delete(MavenModuleSetBuild.java:438)
    at hudson.tasks.LogRotator.perform(LogRotator.java:129)
    at hudson.model.Job.logRotate(Job.java:447)
    at ...

This seems to be printed to the log even in the normal case that both upstream and downstream are long finished, and the downstream just got log-rotated. Probably onCompleted should delete BuildTriggerAction?

Note that fcff78cd04b7410dcaa2a7bd124750f2bda7ba08 in 1.7 addressed an ISE but from isCompleted, not scheduleNextRun. Probably CpsFlowExecution.runInCpsVmThread should also log a warning and return, rather than throw up ISE, if programPromise == null.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
Atlassian logo

jglick@cloudbees.com (JIRA)

unread,
May 18, 2016, 6:16:02 PM5/18/16
to jenkinsc...@googlegroups.com
Jesse Glick commented on Bug JENKINS-28673
 
Re: ISE from BuildTriggerListener.onDeleted

As of PR 109 you get a somewhat different warning:

… org.jenkinsci.plugins.workflow.cps.CpsStepContext onFailure
WARNING: already completed CpsStepContext[3]:Owner[us/1:us #1]
java.lang.IllegalStateException: hudson.AbortException: ds #1 was deleted
	at org.jenkinsci.plugins.workflow.cps.CpsStepContext.onFailure(CpsStepContext.java:320)
	at org.jenkinsci.plugins.workflow.support.steps.build.BuildTriggerListener.onDeleted(BuildTriggerListener.java:53)
	at hudson.model.listeners.RunListener.fireDeleted(RunListener.java:246)
	at hudson.model.Run.delete(Run.java:1483)
	at …

jglick@cloudbees.com (JIRA)

unread,
May 18, 2016, 6:16:02 PM5/18/16
to jenkinsc...@googlegroups.com
Jesse Glick started work on Bug JENKINS-28673
 
Change By: Jesse Glick
Status: Open In Progress

scm_issue_link@java.net (JIRA)

unread,
May 31, 2016, 6:47:02 PM5/31/16
to jenkinsc...@googlegroups.com
SCM/JIRA link daemon commented on Bug JENKINS-28673
 
Re: ISE from BuildTriggerListener.onDeleted

Code changed in jenkins
User: Jesse Glick
Path:
src/main/java/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerListener.java
src/test/java/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStepRestartTest.java
src/test/java/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStepTest.java
http://jenkins-ci.org/commit/pipeline-build-step-plugin/c869245bed52a6b0b9c35e9a38f4c6d3f843a1ff
Log:
[FIXED JENKINS-28673] ISE after deleting a downstream build.

scm_issue_link@java.net (JIRA)

unread,
May 31, 2016, 6:47:02 PM5/31/16
to jenkinsc...@googlegroups.com

Code changed in jenkins
User: Jesse Glick
Path:
src/main/java/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerListener.java
src/test/java/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStepRestartTest.java
src/test/java/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStepTest.java

JENKINS-28673 ISE after deleting a downstream build

scm_issue_link@java.net (JIRA)

unread,
May 31, 2016, 6:47:02 PM5/31/16
to jenkinsc...@googlegroups.com
SCM/JIRA link daemon resolved as Fixed
Change By: SCM/JIRA link daemon
Status: In Progress Resolved
Resolution: Fixed
Reply all
Reply to author
Forward
0 new messages