[JIRA] [workflow-plugin] (JENKINS-32476) Code Snippet Generator for 'step' should use class FQDN in case of collisions

23 views
Skip to first unread message

cleclerc@cloudbees.com (JIRA)

unread,
Jan 15, 2016, 11:15:04 AM1/15/16
to jenkinsc...@googlegroups.com
Cyrille Le Clerc created an issue
 
Jenkins / Improvement JENKINS-32476
Code Snippet Generator for 'step' should use class FQDN in case of collisions
Issue Type: Improvement Improvement
Assignee: Jesse Glick
Components: workflow-plugin
Created: 15/Jan/16 4:14 PM
Priority: Minor Minor
Reporter: Cyrille Le Clerc

Some plugins use the same shortname for their build step class such as CheckStylePublisher with the CheckStyle Plugin (hudson.plugins.checkstyle.CheckStylePublisher) and the JSHint Plugin (hudson.plugins.jshint.CheckStylePublisher).

The groovy code generated by the snipped generator is then invalid (see sample below).

It would be nice if the snippet generator could generate a syntax with the fully qualified class name or if an error message could be displayed in the workflow editor.

step([$class: 'CheckStylePublisher', pattern: '**/checkstyle-result.xml'])
java.lang.UnsupportedOperationException: CheckStylePublisher as a interface jenkins.tasks.SimpleBuildStep could mean either hudson.plugins.jshint.CheckStylePublisher or hudson.plugins.checkstyle.CheckStylePublisher
	at org.jenkinsci.plugins.workflow.structs.DescribableHelper.coerce(DescribableHelper.java:226)
	at org.jenkinsci.plugins.workflow.structs.DescribableHelper.buildArguments(DescribableHelper.java:185)
	at org.jenkinsci.plugins.workflow.structs.DescribableHelper.instantiate(DescribableHelper.java:91)
	at org.jenkinsci.plugins.workflow.steps.StepDescriptor.newInstance(StepDescriptor.java:103)
	at org.jenkinsci.plugins.workflow.cps.DSL.invokeMethod(DSL.java:133)
	at org.jenkinsci.plugins.workflow.cps.CpsScript.invokeMethod(CpsScript.java:112)
	...
	at java.lang.Thread.run(Thread.java:745)
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
Atlassian logo

jglick@cloudbees.com (JIRA)

unread,
Jun 24, 2016, 2:14:01 PM6/24/16
to jenkinsc...@googlegroups.com
Jesse Glick updated an issue
Change By: Jesse Glick
Component/s: structs-plugin
Component/s: workflow-plugin
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
Atlassian logo

jglick@cloudbees.com (JIRA)

unread,
Jun 24, 2016, 2:14:02 PM6/24/16
to jenkinsc...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages