[JIRA] (JENKINS-38344) Catch and log any uncaught exceptions

Catch and log any uncaught exceptions

Issue Type:	Bug
Assignee:	stephenconnolly
Components:	remoting
Created:	2016/Sep/19 11:08 AM
Priority:	Minor
Reporter:	stephenconnolly

Found following stack traces when preparing for my Jenkins World talk:

 
                                                                Sep 09, 2016 2:17:07 PM hudson.util.ExceptionCatchingThreadFactory uncaughtException
WARNING: Thread Computer.threadPoolForRemoting [#3] terminated unexpectedly
java.lang.RuntimeException: Delegated task threw Exception/Error
	at sun.security.ssl.Handshaker.checkThrown(Handshaker.java:1429)
	at sun.security.ssl.SSLEngineImpl.checkTaskThrown(SSLEngineImpl.java:535)
	at sun.security.ssl.SSLEngineImpl.readNetRecord(SSLEngineImpl.java:813)
	at sun.security.ssl.SSLEngineImpl.unwrap(SSLEngineImpl.java:781)
	at javax.net.ssl.SSLEngine.unwrap(SSLEngine.java:624)
	at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.processRead(SSLEngineFilterLayer.java:336)
	at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.onRecv(SSLEngineFilterLayer.java:116)
	at org.jenkinsci.remoting.protocol.ProtocolStack$Ptr.onRecv(ProtocolStack.java:669)
	at org.jenkinsci.remoting.protocol.NetworkLayer.onRead(NetworkLayer.java:138)
	at org.jenkinsci.remoting.protocol.impl.NIONetworkLayer.ready(NIONetworkLayer.java:148)
	at org.jenkinsci.remoting.protocol.IOHub$OnReady.run(IOHub.java:697)
	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.NullPointerException
	at sun.security.ssl.SunX509KeyManagerImpl.getAliases(SunX509KeyManagerImpl.java:359)
	at sun.security.ssl.SunX509KeyManagerImpl.getClientAliases(SunX509KeyManagerImpl.java:308)
	at sun.security.ssl.SunX509KeyManagerImpl.chooseClientAlias(SunX509KeyManagerImpl.java:218)
	at sun.security.ssl.SunX509KeyManagerImpl.chooseEngineClientAlias(SunX509KeyManagerImpl.java:241)
	at sun.security.ssl.ClientHandshaker.serverHelloDone(ClientHandshaker.java:806)
	at sun.security.ssl.ClientHandshaker.processMessage(ClientHandshaker.java:348)
	at sun.security.ssl.Handshaker.processLoop(Handshaker.java:979)
	at sun.security.ssl.Handshaker$1.run(Handshaker.java:919)
	at sun.security.ssl.Handshaker$1.run(Handshaker.java:916)
	at java.security.AccessController.doPrivileged(Native Method)
	at sun.security.ssl.Handshaker$DelegatedTask.run(Handshaker.java:1369)
	at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.processRead(SSLEngineFilterLayer.java:371)
	... 9 more
 
                                                            

In some cases this can lead to a stuck thread, so better option is to catch, log and close the connection

This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)

scm_issue_link@java.net (JIRA)

unread,

Sep 19, 2016, 7:11:02 AM9/19/16

to jenkinsc...@googlegroups.com

SCM/JIRA link daemon commented on

Code changed in jenkins
User: Stephen Connolly
Path:
src/main/java/org/jenkinsci/remoting/protocol/IOHub.java
src/main/java/org/jenkinsci/remoting/protocol/impl/BIONetworkLayer.java
src/main/java/org/jenkinsci/remoting/protocol/impl/NIONetworkLayer.java
http://jenkins-ci.org/commit/remoting/a208126b40b51d2dd10a2bbf05581f371f0db92c
Log:
[FIXED JENKINS-38344] Catch uncaught exceptions, log and close connection

scm_issue_link@java.net (JIRA)

unread,

Sep 19, 2016, 7:11:06 AM9/19/16

to jenkinsc...@googlegroups.com

SCM/JIRA link daemon resolved as Fixed

Jenkins /

Catch and log any uncaught exceptions

Change By:	SCM/JIRA link daemon
Status:	Open Resolved
Resolution:	Fixed

scm_issue_link@java.net (JIRA)

unread,

Sep 21, 2016, 7:08:03 AM9/21/16

to jenkinsc...@googlegroups.com

SCM/JIRA link daemon commented on

Code changed in jenkins
User: Stephen Connolly
Path:
src/main/java/org/jenkinsci/remoting/protocol/IOHub.java
src/main/java/org/jenkinsci/remoting/protocol/impl/BIONetworkLayer.java

http://jenkins-ci.org/commit/remoting/c3d64699ce1f639560eee2234ffb19389a839233
Log:
~~JENKINS-38344~~ Rethrow Errors

scm_issue_link@java.net (JIRA)

unread,

Sep 21, 2016, 7:12:01 AM9/21/16

to jenkinsc...@googlegroups.com

SCM/JIRA link daemon commented on

Code changed in jenkins
User: Stephen Connolly
Path:

src/main/java/org/jenkinsci/remoting/protocol/impl/BIONetworkLayer.java
http://jenkins-ci.org/commit/remoting/4aa76cff9c80b7f30460b6d5b36dcb4c7f5bb828
Log:
~~JENKINS-38344~~ EOFException does not need to be caught

scm_issue_link@java.net (JIRA)

unread,

Sep 21, 2016, 8:52:02 AM9/21/16

to jenkinsc...@googlegroups.com

SCM/JIRA link daemon commented on