[JIRA] (JENKINS-49480) Close forcibly channel on StreamCorruptedException

2 views
Skip to first unread message

batmat@batmat.net (JIRA)

unread,
Feb 9, 2018, 9:58:02 AM2/9/18
to jenkinsc...@googlegroups.com
Baptiste Mathus created an issue
 
Jenkins / Improvement JENKINS-49480
Close forcibly channel on StreamCorruptedException
Issue Type: Improvement Improvement
Assignee: Unassigned
Components: remoting
Created: 2018-02-09 14:57
Priority: Major Major
Reporter: Baptiste Mathus

On some cases, it can happen that the connection ends up in a very bad state, and it could throw a StreamCorruptedException and some stack trace like :

WARNING: Failed to construct Command
java.io.StreamCorruptedException: invalid stream header: 436C6173
    at java.io.ObjectInputStream.readStreamHeader(ObjectInputStream.java:857)
    at java.io.ObjectInputStream.<init>(ObjectInputStream.java:349)
    at hudson.remoting.ObjectInputStreamEx.<init>(ObjectInputStreamEx.java:48)
    at hudson.remoting.AbstractByteBufferCommandTransport.processCommand(AbstractByteBufferCommandTransport.java:201)
    at hudson.remoting.AbstractByteBufferCommandTransport.receive(AbstractByteBufferCommandTransport.java:188)

In such cases, there's few chance that the application will be written/designed to recover.

In this case, Remoting should probably just forcibly terminate the connection, so that it gets reestablished cleanly from scratch.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
Atlassian logo

o.v.nenashev@gmail.com (JIRA)

unread,
Feb 9, 2018, 10:08:01 AM2/9/18
to jenkinsc...@googlegroups.com
Oleg Nenashev commented on Improvement JENKINS-49480
 
Re: Close forcibly channel on StreamCorruptedException

Actually it is supposed to close the connection even now.

Baptiste Mathus could you provide more information about the use-case when it does not happen? Repro steps would be useful

rysteboe@cloudbees.com (JIRA)

unread,
Feb 9, 2018, 12:55:02 PM2/9/18
to jenkinsc...@googlegroups.com
Rebecca Ysteboe started work on Improvement JENKINS-49480
 
Change By: Rebecca Ysteboe
Status: Open In Progress

rysteboe@cloudbees.com (JIRA)

unread,
Feb 9, 2018, 12:55:03 PM2/9/18
to jenkinsc...@googlegroups.com

rysteboe@cloudbees.com (JIRA)

unread,
Feb 9, 2018, 3:01:03 PM2/9/18
to jenkinsc...@googlegroups.com
Rebecca Ysteboe commented on Improvement JENKINS-49480
 
Re: Close forcibly channel on StreamCorruptedException

I do not understand the circumstances under which the channel would not terminate. It's simple enough to put in an additional channel termination command, but I suspect that it would not work.

jthompson@cloudbees.com (JIRA)

unread,
Oct 29, 2018, 6:06:02 PM10/29/18
to jenkinsc...@googlegroups.com
Jeff Thompson closed an issue as Cannot Reproduce
 

The defect report does not provide sufficient information for reproduction or action. Please re-open if you can provide sufficient information.

Change By: Jeff Thompson
Status: In Progress Closed
Resolution: Cannot Reproduce
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
Reply all
Reply to author
Forward
0 new messages