[JIRA] [github-plugin] (JENKINS-33908) github plugin generates lots of undesired threaddumps on recreate webhooks

27 views
Skip to first unread message

sorin.sbarnea@gmail.com (JIRA)

unread,
Mar 30, 2016, 11:54:01 AM3/30/16
to jenkinsc...@googlegroups.com
Sorin Sbarnea created an issue
 
Jenkins / Bug JENKINS-33908
github plugin generates lots of undesired threaddumps on recreate webhooks
Issue Type: Bug Bug
Assignee: Kirill Merkushev
Components: github-plugin
Created: 2016/Mar/30 3:53 PM
Priority: Minor Minor
Reporter: Sorin Sbarnea

It seems that recreation of webhooks generated LOTs of errors inside the logs when it should not do this.

Failure to remove something that is not there in the first place....

Mar 30, 2016 3:43:11 PM org.jenkinsci.plugins.github.webhook.WebhookManager$2 applyNullSafe
WARNING: Failed to add GitHub webhook for GitHubRepositoryName[host=github.com,username=xxx,repository=yyy]
org.kohsuke.github.GHException: Failed to delete post-commit hook
	at org.jenkinsci.plugins.github.webhook.WebhookManager$10.applyNullSafe(WebhookManager.java:311)
	at org.jenkinsci.plugins.github.webhook.WebhookManager$10.applyNullSafe(WebhookManager.java:305)
	at org.jenkinsci.plugins.github.util.misc.NullSafePredicate.apply(NullSafePredicate.java:19)
Caused by: java.io.FileNotFoundException: {"message":"Not Found","documentation_url":"https://developer.github.com/v3"}
	at org.kohsuke.github.Requester.handleApiError(Requester.java:527)
	at org.kohsuke.github.Requester._to(Requester.java:257)

Imagine how this looks when you have 50 repositories, not one.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
Atlassian logo

hflambo@boostrack.com (JIRA)

unread,
Apr 15, 2016, 11:33:01 AM4/15/16
to jenkinsc...@googlegroups.com
H F commented on Bug JENKINS-33908
 
Re: github plugin generates lots of undesired threaddumps on recreate webhooks

Same story here.. WFH?

pr 15, 2016 3:24:06 PM org.jenkinsci.plugins.github.webhook.WebhookManager$2 applyNullSafe
WARNING: Failed to add GitHub webhook for GitHubRepositoryName[host=github.com,username=boostrack,repository=zim-service]
org.kohsuke.github.GHException: Failed to delete post-commit hook
	at org.jenkinsci.plugins.github.webhook.WebhookManager$10.applyNullSafe(WebhookManager.java:311)
	at org.jenkinsci.plugins.github.webhook.WebhookManager$10.applyNullSafe(WebhookManager.java:305)
	at org.jenkinsci.plugins.github.util.misc.NullSafePredicate.apply(NullSafePredicate.java:19)
	at com.google.common.collect.Iterators$7.computeNext(Iterators.java:649)
	at com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:143)
	at com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:138)
	at com.google.common.collect.Iterators$7.computeNext(Iterators.java:647)
	at com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:143)
	at com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:138)
	at com.google.common.collect.Lists.newArrayList(Lists.java:138)
	at com.google.common.collect.Lists.newArrayList(Lists.java:119)
	at org.jenkinsci.plugins.github.util.FluentIterableWrapper.toList(FluentIterableWrapper.java:137)
	at org.jenkinsci.plugins.github.webhook.WebhookManager$2.applyNullSafe(WebhookManager.java:176)
	at org.jenkinsci.plugins.github.webhook.WebhookManager$2.applyNullSafe(WebhookManager.java:149)
	at org.jenkinsci.plugins.github.util.misc.NullSafeFunction.apply(NullSafeFunction.java:18)
	at com.google.common.collect.Iterators$8.next(Iterators.java:812)
	at com.google.common.collect.Iterators$7.computeNext(Iterators.java:648)
	at com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:143)
	at com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:138)
	at com.google.common.collect.Iterators$7.computeNext(Iterators.java:647)
	at com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:143)
	at com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:138)
	at com.google.common.collect.Lists.newArrayList(Lists.java:138)
	at com.google.common.collect.Lists.newArrayList(Lists.java:119)
	at org.jenkinsci.plugins.github.util.FluentIterableWrapper.toList(FluentIterableWrapper.java:137)
	at org.jenkinsci.plugins.github.webhook.WebhookManager$1.run(WebhookManager.java:101)
	at hudson.util.SequentialExecutionQueue$QueueEntry.run(SequentialExecutionQueue.java:119)
	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
	at java.util.concurrent.FutureTask.run(FutureTask.java:262)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
	at java.lang.Thread.run(Thread.java:745)
Caused by: java.io.FileNotFoundException: {"message":"Not Found","documentation_url":"https://developer.github.com/v3"}
	at org.kohsuke.github.Requester.handleApiError(Requester.java:527)
	at org.kohsuke.github.Requester._to(Requester.java:257)
	at org.kohsuke.github.Requester.to(Requester.java:203)
	at org.kohsuke.github.Requester.to(Requester.java:191)
	at org.kohsuke.github.GHHook.delete(GHHook.java:46)
	at org.jenkinsci.plugins.github.webhook.WebhookManager$10.applyNullSafe(WebhookManager.java:308)
	... 32 more
Caused by: java.io.FileNotFoundException: https://api.github.com/repos/boostrack/zim-service/hooks/8082065
	at com.squareup.okhttp.internal.huc.HttpURLConnectionImpl.getInputStream(HttpURLConnectionImpl.java:240)
	at com.squareup.okhttp.internal.huc.DelegatingHttpsURLConnection.getInputStream(DelegatingHttpsURLConnection.java:210)
	at com.squareup.okhttp.internal.huc.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:25)
	at org.kohsuke.github.Requester.parse(Requester.java:483)
	at org.kohsuke.github.Requester._to(Requester.java:236)
	... 36 more

Apr 15, 2016 3:24:06 PM org.jenkinsci.plugins.ghprb.GhprbTrigger start

lanwen@yandex.ru (JIRA)

unread,
Apr 20, 2016, 7:36:03 AM4/20/16
to jenkinsc...@googlegroups.com

why it recreates hooks so often? Do you resave your jobs?
What kind of jobs do you have? What scopes have your creds to manage hooks?

hflambo@boostrack.com (JIRA)

unread,
Apr 22, 2016, 9:57:02 AM4/22/16
to jenkinsc...@googlegroups.com
H F commented on Bug JENKINS-33908

Kirill Merkushev Thanks for your reply..

No sure what do you mean with "why it recreates hooks so often?" .. it only comes to my mind that on Manage Jenkins there"s something to create on Gihub side the job webhooks?

The scopes (I guess you mean oauth scopes?) and yes.. access token has allowed scopes for manage hooks etc..

hflambo@boostrack.com (JIRA)

unread,
Apr 22, 2016, 10:09:01 AM4/22/16
to jenkinsc...@googlegroups.com
H F commented on Bug JENKINS-33908

We also see some time:

WARNING: Failed to remove hook from GitHubRepositoryName[host=github.com,username=wkda,repository=classifieds-service]
java.lang.NullPointerException: There is no credentials with admin access to manage hooks on GitHubRepositoryName[host=github.com,username=wkda,repository=classifieds-service]
        at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:231)
        at org.jenkinsci.plugins.github.webhook.WebhookManager.unregisterFor(WebhookManager.java:118)
        at com.cloudbees.jenkins.Cleaner.doRun(Cleaner.java:72)
        at hudson.triggers.SafeTimerTask.run(SafeTimerTask.java:50)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
        at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:745)

#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x00007ff91bd52e01, pid=14452, tid=140707534501632
#
# JRE version: Java(TM) SE Runtime Environment (8.0_60-b27) (build 1.8.0_60-b27)
# Java VM: Java HotSpot(TM) 64-Bit Server VM (25.60-b23 mixed mode linux-amd64 compressed oops)
# Problematic frame:
# J 5534 C2 com.trilead.ssh2.crypto.cipher.AES.encryptBlock([[I)V (1195 bytes) @ 0x00007ff91bd52e01 [0x00007ff91bd52a00+0x401]
#
# Failed to write core dump. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# /tmp/hs_err_pid14452.log
#
# If you would like to submit a bug report, please visit:
#   http://bugreport.java.com/bugreport/crash.jsp
#

And yes.. Jenkins goes to the Pub

hflambo@boostrack.com (JIRA)

unread,
Apr 22, 2016, 10:10:05 AM4/22/16
to jenkinsc...@googlegroups.com
H F edited a comment on Bug JENKINS-33908
We also see  this  some  time  times :  (maybe it  is related)  

{code}
{code}


And yes.. Jenkins goes to the Pub

hflambo@boostrack.com (JIRA)

unread,
Apr 22, 2016, 10:14:01 AM4/22/16
to jenkinsc...@googlegroups.com
H F updated an issue
 
Change By: H F
Attachment: Screen Shot 2016-01-13 at 11.33.05.png

hflambo@boostrack.com (JIRA)

unread,
Apr 22, 2016, 10:14:02 AM4/22/16
to jenkinsc...@googlegroups.com

hflambo@boostrack.com (JIRA)

unread,
Apr 22, 2016, 10:15:01 AM4/22/16
to jenkinsc...@googlegroups.com
H F updated an issue
Change By: H F
Attachment: Screen Shot 2016-04-22 at 16.11.42.png

lanwen@yandex.ru (JIRA)

unread,
Apr 22, 2016, 10:23:01 AM4/22/16
to jenkinsc...@googlegroups.com
Kirill Merkushev commented on Bug JENKINS-33908
 
Re: github plugin generates lots of undesired threaddumps on recreate webhooks

Jenkins will try to manage hooks in 2 cases:

  • You manually press the btn in global config.
  • You save job configuration (with GH trigger enabled or disabled)

So normally it can't produce lot of such logs by itself. What jobs do you use with this trigger?

And did you read the message:


"There is no credentials with admin access to manage hooks on"

? Please check your scopes twice. It should have admin:hooks scope.

hflambo@boostrack.com (JIRA)

unread,
Apr 22, 2016, 10:33:04 AM4/22/16
to jenkinsc...@googlegroups.com
H F commented on Bug JENKINS-33908

Ohh Thanks for your reply.
regarding Oauth scope i think they are present? Please see attached screenshot.

Regarding the flow .. it is the following:

User pushes code to github branch/ creates a PR +> github webhook calls jenkins -> jenkins create comment on PR --> triggers jenkins job build ---> jenkins reports status of build sucess or failure ---> github allow to merge or not (button) based on the "build status" ... if failure button is disabled .. other way merge button shows up green for merging

Jobs are just re-saved when there are changes made.. but might be that during troubleshooting / testing they can be saved several time ... (dows it make a difference? Why it would cause troubles ?)

Thanks & regards

hflambo@boostrack.com (JIRA)

unread,
Apr 22, 2016, 10:34:04 AM4/22/16
to jenkinsc...@googlegroups.com
H F edited a comment on Bug JENKINS-33908
Ohh Thanks for your reply.
regarding Oauth scope i think they are present? Please see attached screenshot.

Regarding the flow .. it is the following:

User pushes code to github branch/ creates a PR +> github webhook calls jenkins -> jenkins create comment on PR --> triggers jenkins job build ---> jenkins reports status of build sucess or failure ---> github allow to merge or not (button) based on the "build status"  ... if failure button is disabled .. other way merge button shows up green for merging

Jobs are just re-saved when there are changes made.. but might be that during troubleshooting / testing they can be saved several  time  times  ... ( dows does  it make a difference? Why it would cause troubles ?)

Thanks & regards

lanwen@yandex.ru (JIRA)

unread,
Apr 22, 2016, 4:40:01 PM4/22/16
to jenkinsc...@googlegroups.com

Please make sure that user which owns token also have admin rights on this repo.

About jobs i mean which type - pipeline|freestyle|maven?

hflambo@boostrack.com (JIRA)

unread,
Apr 22, 2016, 6:05:02 PM4/22/16
to jenkinsc...@googlegroups.com
H F edited a comment on Bug JENKINS-33908
We also see this some times: (maybe it  is related) 

{code}
WARNING: Failed to remove hook from GitHubRepositoryName[host=github.com,username=
wkda bea ,repository= classifieds zim -service]
java.lang.NullPointerException: There is no credentials with admin access to manage hooks on GitHubRepositoryName[host=github.com,username=
wkda bea ,repository= classifieds zim -service]

gentoo.integer@gmail.com (JIRA)

unread,
Dec 11, 2016, 7:56:02 PM12/11/16
to jenkinsc...@googlegroups.com
Kanstantsin Shautsou closed an issue as Incomplete
 
Change By: Kanstantsin Shautsou
Status: Open Closed
Resolution: Incomplete
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages