[JIRA] [workflow-plugin] (JENKINS-27057) CME in WorkflowRun.logsToCopy

14 показвания
Преминаване към първото непрочетено съобщение

jglick@cloudbees.com (JIRA)

непрочетено,
27.09.2015 г., 10:35:0227.09.15 г.
до jenkinsc...@googlegroups.com
Jesse Glick started work on Bug JENKINS-27057
 
Change By: Jesse Glick
Status: Open In Progress
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
Atlassian logo

jglick@cloudbees.com (JIRA)

непрочетено,
27.09.2015 г., 10:35:0227.09.15 г.
до jenkinsc...@googlegroups.com
Jesse Glick commented on Bug JENKINS-27057
 
Re: CME in WorkflowRun.logsToCopy

Observed to fail more consistently when applying a fix for JENKINS-30055.

szubster@gmail.com (JIRA)

непрочетено,
17.11.2015 г., 2:38:0217.11.15 г.
до jenkinsc...@googlegroups.com
Tomasz Szuba commented on Bug JENKINS-27057
 
Re: CME in WorkflowRun.logsToCopy

Recently same CME started to appear on my local instance, but with different stacktrace.
It is coming up about once in 5 runs.

org.jenkinsci.plugins.workflow.cps.steps.ParallelStepException: Parallel step my-step failed
	at org.jenkinsci.plugins.workflow.cps.steps.ParallelStep$ResultHandler$Callback.checkAllDone(ParallelStep.java:153)
	at org.jenkinsci.plugins.workflow.cps.steps.ParallelStep$ResultHandler$Callback.onFailure(ParallelStep.java:119)
	at org.jenkinsci.plugins.workflow.cps.CpsBodyExecution$FailureAdapter.receive(CpsBodyExecution.java:294)
	at com.cloudbees.groovy.cps.impl.ThrowBlock$1.receive(ThrowBlock.java:68)
	at com.cloudbees.groovy.cps.impl.ConstantBlock.eval(ConstantBlock.java:21)
	at com.cloudbees.groovy.cps.Next.step(Next.java:58)
	at com.cloudbees.groovy.cps.Continuable.run0(Continuable.java:145)
	at org.jenkinsci.plugins.workflow.cps.CpsThread.runNextChunk(CpsThread.java:164)
	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.run(CpsThreadGroup.java:274)
	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.access$000(CpsThreadGroup.java:74)
	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:183)
	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:181)
	at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$2.call(CpsVmExecutorService.java:47)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:112)
	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
Caused by: org.jenkinsci.plugins.workflow.cps.steps.ParallelStepException: Parallel step step-1 failed
	... 21 more
Caused by: org.jenkinsci.plugins.workflow.cps.steps.ParallelStepException: Parallel step step-2 failed
	... 21 more
Caused by: org.jenkinsci.plugins.workflow.cps.steps.ParallelStepException: Parallel step step-3 failed
	... 21 more
Caused by: org.jenkinsci.plugins.workflow.cps.steps.ParallelStepException: Parallel step step-4 failed
	... 21 more
Caused by: org.jenkinsci.plugins.workflow.cps.steps.ParallelStepException: Parallel step step-5 failed
	... 21 more
Caused by: org.jenkinsci.plugins.workflow.cps.steps.ParallelStepException: Parallel step step-6 failed
	... 21 more
Caused by: org.jenkinsci.plugins.workflow.cps.steps.ParallelStepException: Parallel step step-7 failed
	at org.jenkinsci.plugins.workflow.cps.steps.ParallelStep$ResultHandler$Callback.checkAllDone(ParallelStep.java:153)
	at org.jenkinsci.plugins.workflow.cps.steps.ParallelStep$ResultHandler$Callback.onSuccess(ParallelStep.java:110)
	at org.jenkinsci.plugins.workflow.cps.CpsBodyExecution$SuccessAdapter.receive(CpsBodyExecution.java:311)
	at com.cloudbees.groovy.cps.Outcome.resumeFrom(Outcome.java:73)
	at com.cloudbees.groovy.cps.Continuable.run0(Continuable.java:137)
	... 14 more
Caused by: java.lang.RuntimeException: Failed to serialize org.jenkinsci.plugins.workflow.job.WorkflowRun#logsToCopy for class org.jenkinsci.plugins.workflow.job.WorkflowRun
	at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:215)
	at hudson.util.RobustReflectionConverter$2.visit(RobustReflectionConverter.java:183)
	at com.thoughtworks.xstream.converters.reflection.PureJavaReflectionProvider.visitSerializableFields(PureJavaReflectionProvider.java:138)
	at hudson.util.RobustReflectionConverter.doMarshal(RobustReflectionConverter.java:168)
	at hudson.util.RobustReflectionConverter.marshal(RobustReflectionConverter.java:109)
	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:43)
	at com.thoughtworks.xstream.core.TreeMarshaller.start(TreeMarshaller.java:82)
	at com.thoughtworks.xstream.core.AbstractTreeMarshallingStrategy.marshal(AbstractTreeMarshallingStrategy.java:37)
	at com.thoughtworks.xstream.XStream.marshal(XStream.java:1026)
	at com.thoughtworks.xstream.XStream.marshal(XStream.java:1015)
	at com.thoughtworks.xstream.XStream.toXML(XStream.java:988)
	at hudson.XmlFile.write(XmlFile.java:178)
	at hudson.model.Run.save(Run.java:1899)
	at hudson.util.PersistedList.onModified(PersistedList.java:173)
	at hudson.util.PersistedList._onModified(PersistedList.java:181)
	at hudson.util.PersistedList.add(PersistedList.java:72)
	at org.jenkinsci.plugins.workflow.job.WorkflowRun.onCheckout(WorkflowRun.java:623)
	at org.jenkinsci.plugins.workflow.job.WorkflowRun.access$1100(WorkflowRun.java:107)
	at org.jenkinsci.plugins.workflow.job.WorkflowRun$SCMListenerImpl.onCheckout(WorkflowRun.java:773)
	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:123)
	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:83)
	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:73)
	at org.jenkinsci.plugins.workflow.steps.AbstractSynchronousNonBlockingStepExecution$1$1.call(AbstractSynchronousNonBlockingStepExecution.java:49)
	at hudson.security.ACL.impersonate(ACL.java:213)
	at org.jenkinsci.plugins.workflow.steps.AbstractSynchronousNonBlockingStepExecution$1.run(AbstractSynchronousNonBlockingStepExecution.java:47)
	... 5 more
Caused by: java.util.ConcurrentModificationException
	at java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:711)
	at java.util.LinkedHashMap$LinkedEntryIterator.next(LinkedHashMap.java:744)
	at java.util.LinkedHashMap$LinkedEntryIterator.next(LinkedHashMap.java:742)
	at com.thoughtworks.xstream.converters.collections.MapConverter.marshal(MapConverter.java:75)
	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:84)
	at hudson.util.RobustReflectionConverter.marshallField(RobustReflectionConverter.java:224)
	at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:211)
	... 31 more

szubster@gmail.com (JIRA)

непрочетено,
17.11.2015 г., 2:39:0117.11.15 г.
до jenkinsc...@googlegroups.com
Tomasz Szuba updated an issue
 
Jenkins / Bug JENKINS-27057
CME in WorkflowRun.logsToCopy
Change By: Tomasz Szuba
Priority: Minor Critical

szubster@gmail.com (JIRA)

непрочетено,
27.11.2015 г., 2:01:0227.11.15 г.
до jenkinsc...@googlegroups.com
Tomasz Szuba updated an issue
Change By: Tomasz Szuba
Comment:
Recently same CME started to appear on my local instance, but with different stacktrace.
It is coming up about once in 5 runs.

{code:none}
{code}

scm_issue_link@java.net (JIRA)

непрочетено,
11.01.2016 г., 13:37:0311.01.16 г.
до jenkinsc...@googlegroups.com
SCM/JIRA link daemon commented on Bug JENKINS-27057
 
Re: CME in WorkflowRun.logsToCopy

Code changed in jenkins
User: Jesse Glick
Path:
job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java
http://jenkins-ci.org/commit/workflow-plugin/6140881717bf937ecb42bf77ec11dcc208bedd0c
Log:
[FIXED JENKINS-27057] Made logsToCopy a concurrent map, since WorkflowRun.save can be called from various threads.
The mutations are all guarded by WorkflowRun.completed, so we just need to allow serialization to see a snapshot.
(There was already a race condition in the case of abrupt shutdown, but at worst these should result in duplicated log text.)

scm_issue_link@java.net (JIRA)

непрочетено,
11.01.2016 г., 13:37:0411.01.16 г.
до jenkinsc...@googlegroups.com
SCM/JIRA link daemon resolved as Fixed
Change By: SCM/JIRA link daemon
Status: In Progress Resolved
Resolution: Fixed

scm_issue_link@java.net (JIRA)

непрочетено,
13.01.2016 г., 10:34:0113.01.16 г.
до jenkinsc...@googlegroups.com

Code changed in jenkins
User: Jesse Glick
Path:

aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/EchoStepTest.java
job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java
http://jenkins-ci.org/commit/workflow-plugin/6de84edb0dd337b2179cb3f1bca1de396c10907d
Log:

JENKINS-27057 Correcting mistake in 6140881717bf937ecb42bf77ec11dcc208bedd0c.
Log text was being doubly copied.

scm_issue_link@java.net (JIRA)

непрочетено,
13.01.2016 г., 10:34:0113.01.16 г.
до jenkinsc...@googlegroups.com

Code changed in jenkins
User: Jesse Glick
Path:
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/EchoStepTest.java
job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java

scm_issue_link@java.net (JIRA)

непрочетено,
5.04.2016 г., 16:12:155.04.16 г.
до jenkinsc...@googlegroups.com

Code changed in jenkins
User: Jesse Glick
Path:
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/EchoStepTest.java

JENKINS-27057 Correcting mistake in 6140881717bf937ecb42bf77ec11dcc208bedd0c.
Log text was being doubly copied.
Originally-Committed-As: 6de84edb0dd337b2179cb3f1bca1de396c10907d

scm_issue_link@java.net (JIRA)

непрочетено,
5.04.2016 г., 16:32:075.04.16 г.
до jenkinsc...@googlegroups.com

Code changed in jenkins
User: Jesse Glick
Path:

job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java
http://jenkins-ci.org/commit/workflow-job-plugin/16131b6e9a8fa11a3ef682eaffbea0c62e2fd694


Log:
[FIXED JENKINS-27057] Made logsToCopy a concurrent map, since WorkflowRun.save can be called from various threads.
The mutations are all guarded by WorkflowRun.completed, so we just need to allow serialization to see a snapshot.
(There was already a race condition in the case of abrupt shutdown, but at worst these should result in duplicated log text.)

Originally-Committed-As: 6140881717bf937ecb42bf77ec11dcc208bedd0c

scm_issue_link@java.net (JIRA)

непрочетено,
5.04.2016 г., 16:32:105.04.16 г.
до jenkinsc...@googlegroups.com

Code changed in jenkins
User: Jesse Glick
Path:

aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/EchoStepTest.java
http://jenkins-ci.org/commit/workflow-multibranch-plugin/68c93d030ae6aaf46f84979d5277af4a4eb90248
Log:

JENKINS-27057 Correcting mistake in 6140881717bf937ecb42bf77ec11dcc208bedd0c.
Log text was being doubly copied.
Originally-Committed-As: 6de84edb0dd337b2179cb3f1bca1de396c10907d

scm_issue_link@java.net (JIRA)

непрочетено,
5.04.2016 г., 16:32:295.04.16 г.
до jenkinsc...@googlegroups.com

Code changed in jenkins
User: Jesse Glick
Path:

job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java
http://jenkins-ci.org/commit/workflow-job-plugin/ec0193002871a982cb8fcdbb17561ecbfdf90933
Log:

JENKINS-27057 Correcting mistake in 6140881717bf937ecb42bf77ec11dcc208bedd0c.
Log text was being doubly copied.
Originally-Committed-As: 6de84edb0dd337b2179cb3f1bca1de396c10907d
Отговор до всички
Отговор до автора
Препращане
0 нови съобщения