[JIRA] (JENKINS-50731) Private methods of super class are "missing" in sub class

34 views
Skip to first unread message

r.fuereder@xortex.com (JIRA)

unread,
Apr 11, 2018, 5:22:02 AM4/11/18
to jenkinsc...@googlegroups.com
Reinhold Füreder updated an issue
 
Jenkins / Bug JENKINS-50731
Private methods of super class are "missing" in sub class
Change By: Reinhold Füreder
Thanks to the fix of https://issues.jenkins-ci.org/browse/JENKINS-45982 I dared to continue with one of my original approaches using inheritance in shared Jenkins pipeline library classes, but stumbled over this problem.

Re-producer "Jenkinsfile":
{code:java}
#!/usr/bin/env groovy

class A {
  def script
  A(script) { this.script = script }
  def methodThatCallsPrivateMethod() {
    script.echo "In A.methodThatCallsPrivateMethod()"
    privateMethod()
  }
  private def privateMethod() {
    script.echo "In A.privateMethod()"
  }
}

class B extends A {
  B(script) { super(script) }
}

node {

  stage('A') {
    new A(this).methodThatCallsPrivateMethod()
  }

  stage('B') {
    new B(this).methodThatCallsPrivateMethod() // ! This will subsequently fails fail the pipeline
  }

}
{code}

Current log/error:
{noformat}
[Pipeline] {
[Pipeline] stage
[Pipeline] { (A)
[Pipeline] echo
In A.methodThatCallsPrivateMethod()
[Pipeline] echo
In A.privateMethod()
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (B)
[Pipeline] echo
In A.methodThatCallsPrivateMethod()
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline
hudson.remoting.ProxyException: groovy.lang.MissingMethodException: No signature of method: B.privateMethod() is applicable for argument types: () values: []
at org.codehaus.groovy.runtime.ScriptBytecodeAdapter.unwrap(ScriptBytecodeAdapter.java:58)
at org.codehaus.groovy.runtime.callsite.PogoMetaClassSite.call(PogoMetaClassSite.java:54)
at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
at org.kohsuke.groovy.sandbox.impl.Checker$1.call(Checker.java:157)
at org.kohsuke.groovy.sandbox.GroovyInterceptor.onMethodCall(GroovyInterceptor.java:23)
at org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.SandboxInterceptor.onMethodCall(SandboxInterceptor.java:133)
at org.kohsuke.groovy.sandbox.impl.Checker$1.call(Checker.java:155)
at org.kohsuke.groovy.sandbox.impl.Checker.checkedCall(Checker.java:159)
at com.cloudbees.groovy.cps.sandbox.SandboxInvoker.methodCall(SandboxInvoker.java:17)
at A.methodThatCallsPrivateMethod(WorkflowScript:8)
at WorkflowScript.run(WorkflowScript:26)
at ___cps.transform___(Native Method)
at com.cloudbees.groovy.cps.impl.ContinuationGroup.methodCall(ContinuationGroup.java:57)
at com.cloudbees.groovy.cps.impl.FunctionCallBlock$ContinuationImpl.dispatchOrArg(FunctionCallBlock.java:109)
at com.cloudbees.groovy.cps.impl.FunctionCallBlock$ContinuationImpl.fixName(FunctionCallBlock.java:77)
at sun.reflect.GeneratedMethodAccessor204.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at com.cloudbees.groovy.cps.impl.ContinuationPtr$ContinuationImpl.receive(ContinuationPtr.java:72)
at com.cloudbees.groovy.cps.impl.ConstantBlock.eval(ConstantBlock.java:21)
at com.cloudbees.groovy.cps.Next.step(Next.java:83)
at com.cloudbees.groovy.cps.Continuable$1.call(Continuable.java:174)
at com.cloudbees.groovy.cps.Continuable$1.call(Continuable.java:163)
at org.codehaus.groovy.runtime.GroovyCategorySupport$ThreadCategoryInfo.use(GroovyCategorySupport.java:122)
at org.codehaus.groovy.runtime.GroovyCategorySupport.use(GroovyCategorySupport.java:261)
at com.cloudbees.groovy.cps.Continuable.run0(Continuable.java:163)
at org.jenkinsci.plugins.workflow.cps.SandboxContinuable.access$101(SandboxContinuable.java:34)
at org.jenkinsci.plugins.workflow.cps.SandboxContinuable.lambda$run0$0(SandboxContinuable.java:59)
at org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.GroovySandbox.runInSandbox(GroovySandbox.java:108)
at org.jenkinsci.plugins.workflow.cps.SandboxContinuable.run0(SandboxContinuable.java:58)
at org.jenkinsci.plugins.workflow.cps.CpsThread.runNextChunk(CpsThread.java:174)
at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.run(CpsThreadGroup.java:332)
at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.access$200(CpsThreadGroup.java:83)
at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:244)
at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:232)
at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$2.call(CpsVmExecutorService.java:64)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:131)
at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:59)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Finished: FAILURE
{noformat}

Workaround that works
* Changing visibility of {{A.privateMethod()}} from {{private}} to anything else, e.g. {{protected}} or removing the modifier.
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
Atlassian logo

r.fuereder@xortex.com (JIRA)

unread,
Apr 11, 2018, 5:22:02 AM4/11/18
to jenkinsc...@googlegroups.com
Reinhold Füreder created an issue
Issue Type: Bug Bug
Assignee: Unassigned
Components: workflow-cps-global-lib-plugin
Created: 2018-04-11 09:21
Priority: Major Major
Reporter: Reinhold Füreder

Thanks to the fix of https://issues.jenkins-ci.org/browse/JENKINS-45982 I dared to continue with one of my original approaches using inheritance in shared Jenkins pipeline library classes, but stumbled over this problem.

Re-producer "Jenkinsfile":

#!/usr/bin/env groovy

class A {
  def script
  A(script) { this.script = script }
  def methodThatCallsPrivateMethod() {
    script.echo "In A.methodThatCallsPrivateMethod()"
    privateMethod()
  }
  private def privateMethod() {
    script.echo "In A.privateMethod()"
  }
}

class B extends A {
  B(script) { super(script) }
}

node {

  stage('A') {
    new A(this
).methodThatCallsPrivateMethod()
  }

  stage('B') {
    new B(this).methodThatCallsPrivateMethod() // ! This will subsequently fails the pipeline
  }

}

Current log/error:

Workaround that works

  • Changing visibility of A.privateMethod() from private to anything else, e.g. protected or removing the modifier.

r.fuereder@xortex.com (JIRA)

unread,
Apr 11, 2018, 5:24:02 AM4/11/18
to jenkinsc...@googlegroups.com
Reinhold Füreder updated an issue
Change By: Reinhold Füreder
Thanks to the fix of https://issues.jenkins-ci.org/browse/JENKINS-45982 I dared to continue with one of my original approaches using inheritance in shared Jenkins pipeline library classes, but stumbled over this problem.

Re-producer "Jenkinsfile":
{code:java}

#!/usr/bin/env groovy

class A {
  def script
  A(script) { this.script = script }
  def methodThatCallsPrivateMethod() {
    script.echo "In A.methodThatCallsPrivateMethod()"
    privateMethod()
  }
  private def privateMethod() {
    script.echo "In A.privateMethod()"
  }
}

class B extends A {
  B(script) { super(script) }
}

node {

  stage('A') {
    new A(this).methodThatCallsPrivateMethod()
  }

  stage('B') {
    new B(this).methodThatCallsPrivateMethod() // ! This will subsequently fail the pipeline
  }

}
{code}

Current log/error:
{noformat}
{noformat}

 * Workaround that works :*
* Changing visibility of {{A.privateMethod()}} from {{private}} to anything else, e.g. {{protected}} or removing the modifier.

r.fuereder@xortex.com (JIRA)

unread,
Apr 11, 2018, 5:30:03 AM4/11/18
to jenkinsc...@googlegroups.com
Reinhold Füreder updated an issue
Change By: Reinhold Füreder
Environment: The latest and greatest, e.g. Jenkins (core) 2.115, workflow-cps 2.47

r.fuereder@xortex.com (JIRA)

unread,
Apr 11, 2018, 5:32:02 AM4/11/18
to jenkinsc...@googlegroups.com

r.fuereder@xortex.com (JIRA)

unread,
Apr 11, 2018, 7:30:02 AM4/11/18
to jenkinsc...@googlegroups.com
Reinhold Füreder updated an issue
Change By: Reinhold Füreder
Thanks to the fix of https://issues.jenkins-ci.org/browse/ JENKINS-45982 I dared to continue with one of my original approaches using inheritance in shared Jenkins pipeline library classes, but stumbled over this problem.
*Workaround that works:*

* Changing visibility of {{A.privateMethod()}} from {{private}} to anything else, e.g. {{protected}} or removing the modifier.

r.fuereder@xortex.com (JIRA)

unread,
Apr 11, 2018, 7:32:02 AM4/11/18
to jenkinsc...@googlegroups.com
Reinhold Füreder updated an issue
Change By: Reinhold Füreder
Component/s: workflow-cps-plugin
Component/s: workflow-cps-global-lib-plugin

andrew.bayer@gmail.com (JIRA)

unread,
Apr 12, 2018, 1:23:02 PM4/12/18
to jenkinsc...@googlegroups.com
Andrew Bayer commented on Bug JENKINS-50731
 
Re: Private methods of super class are "missing" in sub class

Well, that one's interesting. Can't be sure of exactly what's happening, but it doesn't surprise me - a lot of things around inheritance are, as you've noticed, fairly nonfunctional. =)

jon.sten@gmail.com (JIRA)

unread,
Jun 11, 2018, 7:08:02 AM6/11/18
to jenkinsc...@googlegroups.com
Jon Sten commented on Bug JENKINS-50731

Might be due to this bug in groovy, apparently private methods and fields isn't handled very well in groovy...
Reply all
Reply to author
Forward
0 new messages