[JIRA] [core] (JENKINS-33319) Tests using Jenkins Rule throw exception about TcpSlaveAgentListener (also probably servlet context restart in production)

[stephenconnolly@java.net (JIRA)]

stephenconnolly created an issue

Jenkins / JENKINS-33319 Tests using Jenkins Rule throw exception about TcpSlaveAgentListener (also probably servlet context restart in production) Issue Type: Bug Assignee: Unassigned Components: core Created: 04/Mar/16 10:04 AM Priority: Minor Reporter: stephenconnolly When running the tests I see this alot... Mar 04, 2016 10:02:07 AM hudson.TcpSlaveAgentListener shutdown WARNING: Failed to close down TCP port java.io.IOException: No such file or directory at sun.nio.ch.NativeThread.signal(Native Method) at sun.nio.ch.ServerSocketChannelImpl.implCloseSelectableChannel(ServerSocketChannelImpl.java:283) at java.nio.channels.spi.AbstractSelectableChannel.implCloseChannel(AbstractSelectableChannel.java:234) at java.nio.channels.spi.AbstractInterruptibleChannel.close(AbstractInterruptibleChannel.java:115) at hudson.TcpSlaveAgentListener.shutdown(TcpSlaveAgentListener.java:119) at jenkins.model.Jenkins.cleanUp(Jenkins.java:2789) at org.jvnet.hudson.test.JenkinsRule.after(JenkinsRule.java:460) at org.jvnet.hudson.test.JenkinsRule$2.evaluate(JenkinsRule.java:526) ... Add Comment

This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)

[stephenconnolly@java.net (JIRA)]

stephenconnolly assigned an issue to stephenconnolly

Jenkins / JENKINS-33319 Tests using Jenkins Rule throw exception about TcpSlaveAgentListener (also probably servlet context restart in production)

Change By: stephenconnolly Assignee: stephenconnolly

Add Comment

[stephenconnolly@java.net (JIRA)]

stephenconnolly started work on JENKINS-33319

Change By: stephenconnolly Status: Open In Progress

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon resolved as Fixed

Jenkins / JENKINS-33319 Tests using Jenkins Rule throw exception about TcpSlaveAgentListener (also probably servlet context restart in production)

Change By: SCM/JIRA link daemon Status: In Progress Resolved Resolution: Fixed

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-33319

Re: Tests using Jenkins Rule throw exception about TcpSlaveAgentListener (also probably servlet context restart in production) Code changed in jenkins User: Stephen Connolly Path: core/src/main/java/hudson/TcpSlaveAgentListener.java http://jenkins-ci.org/commit/jenkins/2a61f30250f930b579424dea9682a09e03e7d9db Log: [FIXED JENKINS-33319] Premtively wake the acceptor thread to let it close cleanly Also adds a Ping Agent protocol that could be used by nagios monitoring, etc. to verify that the slave agent listener is alive We use the ping agent protocol to ensure that the acceptor thread wakes up, loops and sees that the shutdown is started that prevents the socket close exception from being thrown

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-33319

Re: Tests using Jenkins Rule throw exception about TcpSlaveAgentListener (also probably servlet context restart in production)

Code changed in jenkins User: Stephen Connolly Path: core/src/main/java/hudson/TcpSlaveAgentListener.java

http://jenkins-ci.org/commit/jenkins/ad3ccffc0043998b940bfafd63971ca4d89fcaa0 Log: JENKINS-33319 fix javadoc comment

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-33319

Re: Tests using Jenkins Rule throw exception about TcpSlaveAgentListener (also probably servlet context restart in production)

Code changed in jenkins User: Stephen Connolly Path: core/src/main/java/hudson/TcpSlaveAgentListener.java

http://jenkins-ci.org/commit/jenkins/14af3036f727e3c6f04328ac2a529b5f3fc2b718 Log: Merge pull request #2082 from stephenc/jenkins-33319

[FIXED JENKINS-33319] Premtively wake the acceptor thread to let it close cleanly

Compare: https://github.com/jenkinsci/jenkins/compare/9cb52bf42e48...14af3036f727

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-33319

Re: Tests using Jenkins Rule throw exception about TcpSlaveAgentListener (also probably servlet context restart in production)

Code changed in jenkins User: Stephen Connolly Path: core/src/main/java/hudson/TcpSlaveAgentListener.java

http://jenkins-ci.org/commit/jenkins/738800ea5ea7dbb75a7644d9d0f8d0cb6a62330c Log: [FIXED JENKINS-33319] Fix up @since tags post merge

Add Comment

[dogfood@java.net (JIRA)]

dogfood commented on JENKINS-33319

Re: Tests using Jenkins Rule throw exception about TcpSlaveAgentListener (also probably servlet context restart in production)

Integrated in jenkins_main_trunk #4484 [FIXED JENKINS-33319] Premtively wake the acceptor thread to let it (Revision 2a61f30250f930b579424dea9682a09e03e7d9db) JENKINS-33319 fix javadoc comment (Revision ad3ccffc0043998b940bfafd63971ca4d89fcaa0) Result = SUCCESS stephen connolly : 2a61f30250f930b579424dea9682a09e03e7d9db Files : core/src/main/java/hudson/TcpSlaveAgentListener.java stephen connolly : ad3ccffc0043998b940bfafd63971ca4d89fcaa0 Files : core/src/main/java/hudson/TcpSlaveAgentListener.java

Add Comment

[dogfood@java.net (JIRA)]

dogfood commented on JENKINS-33319

Re: Tests using Jenkins Rule throw exception about TcpSlaveAgentListener (also probably servlet context restart in production)

Integrated in jenkins_main_trunk #4485 [FIXED JENKINS-33319] Fix up @since tags post merge (Revision 738800ea5ea7dbb75a7644d9d0f8d0cb6a62330c) Result = SUCCESS stephen connolly : 738800ea5ea7dbb75a7644d9d0f8d0cb6a62330c Files : core/src/main/java/hudson/TcpSlaveAgentListener.java

Add Comment

[stephenconnolly@java.net (JIRA)]

stephenconnolly closed an issue as Fixed

Jenkins / JENKINS-33319

Tests using Jenkins Rule throw exception about TcpSlaveAgentListener (also probably servlet context restart in production)

Change By: stephenconnolly Status: Resolved Closed

Add Comment

This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)