[JIRA] (JENKINS-37585) Allow support for "alpha", "beta" and "RC" versions of jenkins-core

0 views
Skip to first unread message

rarabaolaza@cloudbees.com (JIRA)

unread,
Aug 22, 2016, 6:51:01 AM8/22/16
to jenkinsc...@googlegroups.com
Raul Arabaolaza created an issue
 
Jenkins / Improvement JENKINS-37585
Allow support for "alpha", "beta" and "RC" versions of jenkins-core
Issue Type: Improvement Improvement
Assignee: Raul Arabaolaza
Components: plugin-compat-tester
Created: 2016/Aug/22 10:50 AM
Priority: Minor Minor
Reporter: Raul Arabaolaza

The PCT can not be run against jenkins versions that embed a RC, alpha or beta version of
```jenkins-core```, trying to do that results in:

```
Exception in thread "main" java.io.IOException: no jenkins-core.jar in jenkins.war
at org.jenkins.tools.test.PluginCompatTester.scanWAR(PluginCompatTester.java:517)
at org.jenkins.tools.test.PluginCompatTester.testPlugins(PluginCompatTester.java:158)
at org.jenkins.tools.test.PluginCompatTesterCli.main(PluginCompatTesterCli.java:110)
```

The reason is that the method scanWar in PluginCompatTester uses the following code to locate the jenkins-core war

Matcher m = Pattern.compile("WEB-INF/lib/jenkins-core-([0-9.]+(?:-[0-9.]+)?(?:-SNAPSHOT)?)[.]jar").matcher(name);
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
Atlassian logo

rarabaolaza@cloudbees.com (JIRA)

unread,
Aug 22, 2016, 6:52:01 AM8/22/16
to jenkinsc...@googlegroups.com
Raul Arabaolaza updated an issue
Change By: Raul Arabaolaza
The PCT can not be run against jenkins versions that embed a RC _RC_ , alpha _alpha_ or beta _beta_ version of
``` {{ jenkins-core ``` }} , trying to do that results in:
``` {code}
Exception in thread "main" java.io.IOException: no jenkins-core.jar in jenkins.war
     at org.jenkins.tools.test.PluginCompatTester.scanWAR(PluginCompatTester.java:517)
     at org.jenkins.tools.test.PluginCompatTester.testPlugins(PluginCompatTester.java:158)
     at org.jenkins.tools.test.PluginCompatTesterCli.main(PluginCompatTesterCli.java:110)
```

The reason is that the method scanWar in PluginCompatTester uses the following code to locate the
{{ jenkins-core }} war

{code:java}

Matcher m = Pattern.compile("WEB-INF/lib/jenkins-core-([0-9.]+(?:-[0-9.]+)?(?:-SNAPSHOT)?)[.]jar").matcher(name);
{code}

rarabaolaza@cloudbees.com (JIRA)

unread,
Aug 22, 2016, 6:53:01 AM8/22/16
to jenkinsc...@googlegroups.com
Raul Arabaolaza updated an issue
The PCT can not be run against jenkins versions that embed a _RC_, _alpha_ or _beta_ version of
{{jenkins-core}}, trying to do that results in:

{code}
Exception in thread "main" java.io.IOException: no jenkins-core.jar in jenkins.war
     at org.jenkins.tools.test.PluginCompatTester.scanWAR(PluginCompatTester.java:517)
     at org.jenkins.tools.test.PluginCompatTester.testPlugins(PluginCompatTester.java:158)
     at org.jenkins.tools.test.PluginCompatTesterCli.main(PluginCompatTesterCli.java:110)
``` {code}

The reason is that the method scanWar in PluginCompatTester uses the following code to locate the {{jenkins-core}} war

{code:java}
Matcher m = Pattern.compile("WEB-INF/lib/jenkins-core-([0-9.]+(?:-[0-9.]+)?(?:-SNAPSHOT)?)[.]jar").matcher(name);
{code}


rarabaolaza@cloudbees.com (JIRA)

unread,
Aug 22, 2016, 7:07:01 AM8/22/16
to jenkinsc...@googlegroups.com
Raul Arabaolaza started work on Improvement JENKINS-37585
 
Change By: Raul Arabaolaza
Status: Open In Progress

rarabaolaza@cloudbees.com (JIRA)

unread,
Aug 22, 2016, 10:22:01 AM8/22/16
to jenkinsc...@googlegroups.com
Change By: Raul Arabaolaza
Status: In Progress Review

scm_issue_link@java.net (JIRA)

unread,
Aug 23, 2016, 12:39:01 PM8/23/16
to jenkinsc...@googlegroups.com
SCM/JIRA link daemon commented on Improvement JENKINS-37585
 
Re: Allow support for "alpha", "beta" and "RC" versions of jenkins-core

Code changed in jenkins
User: Raúl Arabaolaza Barquin
Path:
plugins-compat-tester/src/main/java/org/jenkins/tools/test/PluginCompatTester.java
plugins-compat-tester/src/test/java/org/jenkins/tools/test/PluginCompatTesterTest.java
http://jenkins-ci.org/commit/plugin-compat-tester/acdfe7444516044e332fa154cc481c3ecc933e90
Log:
JENKINS-37585 Allow support for "alpha", "beta" and "RC" versions of jenkins-core (#12)

  • JENKINS-37585 Augment the jenkins core Regexp to include alpha, beta and RC
  • JENKINS-37585 Refactor regexp to constant to better test it, make version case insensitive

rarabaolaza@cloudbees.com (JIRA)

unread,
Aug 24, 2016, 3:22:02 AM8/24/16
to jenkinsc...@googlegroups.com
Raul Arabaolaza edited a comment on Improvement JENKINS-37585
Fixed by [ #PR-12 ]

rarabaolaza@cloudbees.com (JIRA)

unread,
Aug 24, 2016, 3:22:02 AM8/24/16
to jenkinsc...@googlegroups.com
 

Fixed by #PR-12
Change By: Raul Arabaolaza
Status: In Review Resolved
Resolution: Fixed

rarabaolaza@cloudbees.com (JIRA)

unread,
Aug 24, 2016, 3:23:01 AM8/24/16
to jenkinsc...@googlegroups.com
Raul Arabaolaza edited a comment on Improvement JENKINS-37585
Reply all
Reply to author
Forward
0 new messages