[JIRA] [core] (JENKINS-29876) NPE when triggering downstream job

0 views
Skip to first unread message

gentoo.integer@gmail.com (JIRA)

unread,
Sep 30, 2015, 6:06:03 PM9/30/15
to jenkinsc...@googlegroups.com
Kanstantsin Shautsou updated an issue
 
Jenkins / Bug JENKINS-29876
NPE when triggering downstream job
Change By: Kanstantsin Shautsou
Summary: NPE when triggering downstream job  (again)
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
Atlassian logo

john.mellor@esentire.com (JIRA)

unread,
Oct 1, 2015, 9:03:03 AM10/1/15
to jenkinsc...@googlegroups.com
John Mellor updated an issue
Change By: John Mellor
Environment: Jenkins 1.621+
Windows 2003 all platforms

gentoo.integer@gmail.com (JIRA)

unread,
Oct 1, 2015, 9:05:03 AM10/1/15
to jenkinsc...@googlegroups.com
Kanstantsin Shautsou updated an issue
Change By: Kanstantsin Shautsou
Labels: dependencies permissions  trigger

gentoo.integer@gmail.com (JIRA)

unread,
Oct 1, 2015, 9:05:03 AM10/1/15
to jenkinsc...@googlegroups.com

gentoo.integer@gmail.com (JIRA)

unread,
Oct 1, 2015, 9:06:02 AM10/1/15
to jenkinsc...@googlegroups.com

scm_issue_link@java.net (JIRA)

unread,
Oct 3, 2015, 3:54:03 PM10/3/15
to jenkinsc...@googlegroups.com
SCM/JIRA link daemon resolved as Fixed
Change By: SCM/JIRA link daemon
Status: In Progress Resolved
Resolution: Fixed

scm_issue_link@java.net (JIRA)

unread,
Oct 3, 2015, 3:54:04 PM10/3/15
to jenkinsc...@googlegroups.com
SCM/JIRA link daemon commented on Bug JENKINS-29876
 
Re: NPE when triggering downstream job

Code changed in jenkins
User: Kanstantsin Shautsou
Path:
core/src/main/java/jenkins/triggers/ReverseBuildTrigger.java
test/src/test/java/jenkins/triggers/ReverseBuildTriggerTest.java
http://jenkins-ci.org/commit/jenkins/45e4e990269325ba1f8bca25959ff8dcaa21f398
Log:
[FIXED JENKINS-29876] CheckForNull job in ReverseBuildTrigger

scm_issue_link@java.net (JIRA)

unread,
Oct 3, 2015, 3:54:06 PM10/3/15
to jenkinsc...@googlegroups.com

Code changed in jenkins
User: Oleg Nenashev
Path:
core/src/main/java/jenkins/triggers/ReverseBuildTrigger.java
test/src/test/java/jenkins/triggers/ReverseBuildTriggerTest.java
http://jenkins-ci.org/commit/jenkins/339dd4ace545187d04a65bedea44b215fd11ba39
Log:
Merge pull request #1842 from KostyaSha/patch-3

[FIXED JENKINS-29876] CheckForNull job in ReverseBuildTrigger

dogfood@java.net (JIRA)

unread,
Oct 3, 2015, 4:59:02 PM10/3/15
to jenkinsc...@googlegroups.com
dogfood commented on Bug JENKINS-29876

Integrated in jenkins_main_trunk #4300
[FIXED JENKINS-29876] CheckForNull job in ReverseBuildTrigger (Revision 45e4e990269325ba1f8bca25959ff8dcaa21f398)

Result = SUCCESS
kanstantsin.sha : 45e4e990269325ba1f8bca25959ff8dcaa21f398
Files :

  • test/src/test/java/jenkins/triggers/ReverseBuildTriggerTest.java
  • core/src/main/java/jenkins/triggers/ReverseBuildTrigger.java

o.v.nenashev@gmail.com (JIRA)

unread,
Oct 3, 2015, 7:16:02 PM10/3/15
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue
 
Change By: Oleg Nenashev
Labels: lts-candidate trigger

gentoo.integer@gmail.com (JIRA)

unread,
Oct 3, 2015, 7:18:02 PM10/3/15
to jenkinsc...@googlegroups.com
Kanstantsin Shautsou updated an issue
Change By: Kanstantsin Shautsou
Labels: lts-candidate  trigger

dbeck@cloudbees.com (JIRA)

unread,
Oct 5, 2015, 11:56:05 AM10/5/15
to jenkinsc...@googlegroups.com
Daniel Beck commented on Bug JENKINS-29876
 
Re: NPE when triggering downstream job

This does not affect 1.625.x LTS as the original change by Kostya which surfaced this issue has been reverted. Integrating it again (+ this fix) will result in behavioral changes without one LTS line, so I doubt that should be done. We'll just have to live that there are entirely too many triggers processed in the 1.625.x line.

dbeck@cloudbees.com (JIRA)

unread,
Oct 5, 2015, 11:58:01 AM10/5/15
to jenkinsc...@googlegroups.com

gentoo.integer@gmail.com (JIRA)

unread,
Oct 5, 2015, 12:46:01 PM10/5/15
to jenkinsc...@googlegroups.com

LTS is not required imho, let's test this fix in master and get during next LTS or some minor LTS update...

scm_issue_link@java.net (JIRA)

unread,
Oct 6, 2015, 8:19:04 AM10/6/15
to jenkinsc...@googlegroups.com

Code changed in jenkins
User: tfennelly
Path:
changelog.html
core/src/main/java/hudson/Util.java
core/src/main/java/hudson/console/ConsoleLogFilter.java
core/src/main/java/hudson/model/Label.java
core/src/main/java/hudson/model/Queue.java
core/src/main/java/hudson/model/Run.java
core/src/main/java/hudson/slaves/SlaveComputer.java
core/src/main/java/hudson/tasks/BuildWrappers.java
core/src/main/java/jenkins/triggers/ReverseBuildTrigger.java
core/src/main/resources/lib/layout/task.jelly
core/src/test/java/hudson/FilePathTest.java
core/src/test/java/hudson/LauncherTest.java
core/src/test/java/hudson/util/IsOverriddenTest.java
core/src/test/java/hudson/util/ProcessTreeTest.java
test/src/test/groovy/hudson/model/AbstractProjectTest.groovy
test/src/test/groovy/jenkins/model/PeepholePermalinkTest.groovy
test/src/test/java/hudson/console/ConsoleLogFilterTest.java
test/src/test/java/hudson/model/DirectoryBrowserSupportTest.java
test/src/test/java/hudson/model/NodeTest.java
test/src/test/java/hudson/model/QueueTest.java
test/src/test/java/hudson/slaves/DummyCloudImpl.java
test/src/test/java/hudson/slaves/JNLPLauncherTest.java
test/src/test/java/hudson/tasks/EnvVarsInConfigTasksTest.java
test/src/test/java/hudson/tasks/ShellTest.java
test/src/test/java/hudson/tools/JDKInstallerTest.java
test/src/test/java/hudson/util/ProcessTreeKillerTest.java
test/src/test/java/jenkins/triggers/ReverseBuildTriggerTest.java
http://jenkins-ci.org/commit/jenkins/955eb7274a02e3549493cd2e1e0de785a0893784
Log:
Merge branch 'master' into plugin-manager-dependants


  • [FIXED JENKINS-29876] CheckForNull job in ReverseBuildTrigger
  • Noting JENKINS-30084 in changelog
    JENKINS-30084 remove extra space
    JENKINS-30084 address feedbacks
    JENKINS-30084 indent back
    JENKINS-30084 fixing test
    JENKINS-30084 fixing test
    JENKINS-30084 enhancing test case
    JENKINS-30084 test added to make sure a flyweight task can be blocked at last minute
    JENKINS-30084 fix regression when flyweight task is blocked by upstream/downstream project
    JENKINS-30084 some more polish
    ...

matthew.bates@connexta.com (JIRA)

unread,
Dec 13, 2016, 6:32:05 PM12/13/16
to jenkinsc...@googlegroups.com
Matthew Bates reopened an issue
 

This looks like it's back, in Jenkins 2.19.4

Warning: you have no plugins providing access control for builds, so falling back to legacy behavior of permitting any downstream builds to be triggered
FATAL: null
java.lang.NullPointerException
at hudson.model.Result.isBetterOrEqualTo(Result.java:130)
at jenkins.triggers.ReverseBuildTrigger.shouldTrigger(ReverseBuildTrigger.java:139)
at jenkins.triggers.ReverseBuildTrigger.access$000(ReverseBuildTrigger.java:89)
at jenkins.triggers.ReverseBuildTrigger$1.shouldTriggerBuild(ReverseBuildTrigger.java:146)
at hudson.tasks.BuildTrigger.execute(BuildTrigger.java:247)
at hudson.model.AbstractBuild$AbstractBuildExecution.cleanUp(AbstractBuild.java:681)
at hudson.maven.MavenModuleSetBuild$MavenModuleSetBuildExecution.cleanUp(MavenModuleSetBuild.java:1093)
at hudson.model.Run.execute(Run.java:1767)
at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:544)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:404)
Finished: UNSTABLE

Change By: Matthew Bates
Resolution: Fixed
Status: Resolved Reopened
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
Atlassian logo

gentoo.integer@gmail.com (JIRA)

unread,
Dec 13, 2016, 7:25:03 PM12/13/16
to jenkinsc...@googlegroups.com
Kanstantsin Shautsou commented on Bug JENKINS-29876
 
Re: NPE when triggering downstream job

Your stacktrace ends in Result.java please firstly check and ensure that it the same issues before commenting.

dbeck@cloudbees.com (JIRA)

unread,
Dec 13, 2016, 7:33:03 PM12/13/16
to jenkinsc...@googlegroups.com
Daniel Beck resolved as Fixed
 

That looks more like JENKINS-23191. Make sure saving the job config (and selecting a threshold) doesn't fix it, then file a new issue and link to JENKINS-23191.

Change By: Daniel Beck
Status: Reopened Resolved
Resolution: Fixed
Reply all
Reply to author
Forward
0 new messages