How to prevent saving project's configuration if there are configuration failures?

[Kirill]

Hi folks,

I added few mandatory fields to my build step's config.jelly with the validation that ensures validation errors appearance if mandatory fields are empty.
Is there a way to prohibit saving the job if it's configuration contains validation errors?

Regards,
Kirill.

[Ulli Hafner]

I don’t think that this is possible.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/741882c1-dc50-4a21-9023-8e6621ba3383%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Baptiste Mathus]

+1.

Btw, maybe this is something to add as input for the work going on on the UX and the way plugin UI is developed?

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/2551FBCA-80C2-4B1A-A576-A4174EEB7795%40gmail.com.

[Christopher Orr]

You can always create a job config programmatically, write config.xml
directly to disk, or upload config via the CLI.

So basically there's no way of preventing bad config from being entered
— plugins should make a reasonable effort at runtime to sanity check the
config.

-Chris

On 17/03/15 21:55, Baptiste Mathus wrote:
> +1.
>
> Btw, maybe this is something to add as input for the work going on on
> the UX and the way plugin UI is developed?
>
> Le 17 mars 2015 23:36, "Ulli Hafner" <ullrich...@gmail.com

> <mailto:ullrich...@gmail.com>> a écrit :

>
> I don’t think that this is possible.
>
>> Am 17.03.2015 um 16:48 schrieb Kirill <yam...@gmail.com

>> <mailto:yam...@gmail.com>>:

[Ulli Hafner]

> Am 18.03.2015 um 06:24 schrieb Christopher Orr <ch...@orr.me.uk>:
>
> You can always create a job config programmatically, write config.xml directly to disk, or upload config via the CLI.
>
> So basically there's no way of preventing bad config from being entered — plugins should make a reasonable effort at runtime to sanity check the config.

This is a different thing. A plug-in should always check the input data on the application layer.

But additionally, the UI layer should never allow the creation of invalid configurations. This is one of the main reasons that there is an UI layer.

>
> -Chris
>
>
> On 17/03/15 21:55, Baptiste Mathus wrote:
>> +1.
>>
>> Btw, maybe this is something to add as input for the work going on on
>> the UX and the way plugin UI is developed?
>>
>> Le 17 mars 2015 23:36, "Ulli Hafner" <ullrich...@gmail.com
>> <mailto:ullrich...@gmail.com>> a écrit :
>>
>> I don’t think that this is possible.
>>
>>> Am 17.03.2015 um 16:48 schrieb Kirill <yam...@gmail.com
>>> <mailto:yam...@gmail.com>>:
>>>
>>> Hi folks,
>>>
>>> I added few mandatory fields to my build step's config.jelly with
>>> the validation that ensures validation errors appearance if
>>> mandatory fields are empty.
>>> Is there a way to prohibit saving the job if it's configuration
>>> contains validation errors?
>>>
>>> Regards,
>>> Kirill.
>

> --
> You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

> To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/55090C25.10807%40orr.me.uk.

[Jesse Glick]

On Tue, Mar 17, 2015 at 6:36 PM, Ulli Hafner <ullrich...@gmail.com> wrote:
> I don’t think that this is possible.

Correct: https://issues.jenkins-ci.org/browse/JENKINS-19584

[Kirill]

Thanks a million! 100% clear now.

среда, 18 марта 2015 г., 17:10:37 UTC+2 пользователь Jesse Glick написал:

[Kanstantsin Shautsou]

Wouldn't throw new FormException() from constructor/setter work to not accept Describeable re-recreation?