Bulk addition of Jenkinsfiles to selected plugins

Oliver Gondža

unread,

Jun 15, 2018, 9:19:39 AM6/15/18

to jenkin...@googlegroups.com

Hello,

As you might have noticed I have created PRs to add Jenkinsfiles to 120+
plugin repositories. Those are usually plugins that did not have the
Jenkinsfile created since jenkins.ci.cloudbees.com was discontinued for
plugins.

Dear maintainers, please consider merging them or speak to me in case of
any concerns.

Thank you!
--
oliver

Martin Weber

unread,

Jun 15, 2018, 3:48:00 PM6/15/18

to jenkin...@googlegroups.com

Oops, I was planning to *remove* my jenkinsfile as it always fails the tests
on windows. (It needs cmake installed in PATH to succeed).
Is ther a way to disable the tests on windows?

Plugin ID: cmakebuilder

Martin

--
E-Mails sollten Text sein, Text und nur Text.
Wenn Gott gewollt hätte, dass E-Mails in HTML geschrieben würden,
endeten Gebete traditionell mit </amen>.

Slide

unread,

Jun 15, 2018, 3:58:51 PM6/15/18

to jenkin...@googlegroups.com

You can use buildPlugin(platforms: ['linux']) to have it only build on Linux.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/3558181.YytU7SoKfB%40linux.
For more options, visit https://groups.google.com/d/optout.

Jesse Glick

unread,

Jun 15, 2018, 4:07:45 PM6/15/18

to Jenkins Dev

On Fri, Jun 15, 2018 at 9:19 AM, Oliver Gondža <ogo...@gmail.com> wrote:
> Dear maintainers, please consider merging them

Beware that if Oliver lacked write permission to the repo, then the
PRs will not have been built, which could result in build failures
after merge. Generally it is best for someone with write permission to
file such a PR, so they can iterate until the build actually passes.

Martin Weber

unread,

Jun 15, 2018, 4:08:24 PM6/15/18

to jenkin...@googlegroups.com

Am Freitag, 15. Juni 2018, 21:58:33 CEST schrieb Slide:
> You can use buildPlugin(platforms: ['linux']) to have it only build on
> Linux.

Will do, thank you!

Martin Weber

unread,

Jun 21, 2018, 3:18:49 PM6/21/18

to jenkin...@googlegroups.com

Am Freitag, 15. Juni 2018, 21:58:33 CEST schrieb Slide:

> You can use buildPlugin(platforms: ['linux']) to have it only build on
> Linux.

That did not help. Apparently, even on the linux nodes, cmake is no longer
installed. The plugin needs cmake installed in PATH to make the tests succeed.

Any hints?

Plugin ID: cmakebuilder

Slide

unread,

Jun 21, 2018, 3:51:35 PM6/21/18

to jenkin...@googlegroups.com

It doesn't look like buildPlugin supports adding any tools or anything like that, so it seems like you won't be able to use buildPlugin directly without some additional support.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/2603694.lTrYKerxst%40linux.

Jesse Glick

unread,

Jun 21, 2018, 3:55:36 PM6/21/18

to Jenkins Dev

On Thu, Jun 21, 2018 at 3:51 PM Slide <slide...@gmail.com> wrote:
> It doesn't look like buildPlugin supports adding any tools or anything like that

Deliberately. Use the `docker` label (instead of `linux`) and write
your tests to use the `docker-fixtures` library or otherwise
programmatically construct their runtime environment.

Joseph P

unread,

Jun 22, 2018, 3:05:06 PM6/22/18

to Jenkins Developers

Easy to say, better to give examples. Thank you!

Jesse Glick

unread,

Jun 22, 2018, 4:04:32 PM6/22/18

to Jenkins Dev

On Fri, Jun 22, 2018 at 3:05 PM Joseph P <jose...@gmail.com> wrote:
> Easy to say, better to give examples. Thank you!

`mercurial-plugin` is an example I have personally worked on. There, a
Docker container allows us to run tests against specific versions of
Mercurial. (Some older tests remain which run only if Mercurial is
installed locally, so these are skipped on CI.)

Oleg Nenashev

unread,

Jun 25, 2018, 5:26:00 AM6/25/18

to Jenkins Developers

Generally it is best for someone with write permission to
file such a PR, so they can iterate until the build actually passes.

Yes, this is a serious weak spot of such bulk change.

If it was discussed in advance, we could have granted the permissions.

The change itself is very reasonable, of course.

ogondza

unread,

Jul 10, 2018, 2:58:59 AM7/10/18

to Jenkins Developers

On Monday, June 25, 2018 at 11:26:00 AM UTC+2, Oleg Nenashev wrote:

Generally it is best for someone with write permission to
file such a PR, so they can iterate until the build actually passes.

Yes, this is a serious weak spot of such bulk change.
If it was discussed in advance, we could have granted the permissions.

Pity, did not occurred to me beforehand. The ironic part is I would have to gain the permissions to some of the repos to merge the PRs if maintainers does nor respond.

ogondza

unread,

Jul 10, 2018, 3:22:29 AM7/10/18

to Jenkins Developers

Gentle reminder to maintainers of remaining 92 plugins, the pull requests[1] are ready to be reviewed and merged. Note that I will eventually do so myself (unless I hear that I should not) if there is not reply from the maintainer. Thanks for understanding.

[1]

```

```

--

oliver

ogondza

unread,

Jul 17, 2018, 9:31:09 AM7/17/18

to Jenkins Developers

I would like to thank all the maintainers that have helped to get this change in their plugins. Unfortunately, there is still 85 open PRs with no reaction from anyone. I am hereby formally asking for permission to merge this single change in plugins in case there was no response in the PR. Those where the discussion is ongoing will be coordinated with maintainer, of course. I have added this as a topic to the Governance Meeting tomorrow. Feel free to speak up here or on the call.

Thank you.

--

oliver

Slide

unread,

Jul 17, 2018, 9:32:20 AM7/17/18

to jenkin...@googlegroups.com

+1 from me!

--

You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/75abd786-1b70-4d54-b337-c0813ed84c56%40googlegroups.com.

Jesse Glick

unread,

Jul 17, 2018, 9:49:43 AM7/17/18

to Jenkins Dev

On Tue, Jul 17, 2018 at 9:31 AM ogondza <ogo...@gmail.com> wrote:
> permission to merge this single change in plugins in case there was no response in the PR

+1, I cannot imagine how this could be construed as interfering with
the plugin maintainer (if there is one). I would just advise that you
monitor the status of the `master` job, in cases in which you lacked
write permission to the repository and thus your `Jenkinsfile` was not
already tested.

Oleg Nenashev

unread,

Jul 17, 2018, 10:34:04 AM7/17/18

to JenkinsCI Developers

+1, I see no big deal if it gets integrated.

The most of the plugins in the list are abandoned or semi-abandoned.

I have approved some pull requests, but it many cases I doubt that maintainers will be able to respond even if you ping them directly.

Best regards,

Oleg

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/6f_wKvfpESk/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr2O2qCrs6-5edpLgwpjrjub161U50K%2B1ma%2B7R4kU%3D14hA%40mail.gmail.com.

Reply all

Reply to author

Forward