[PATCH 1/2] tools: jailhouse: Do not dump console on enabling errors

0 views
Skip to first unread message

Jan Kiszka

unread,
Apr 28, 2017, 2:19:13 AM4/28/17
to Jailhouse, Ralf Ramsauer
We cannot reliably tell apart errors that happen before we call into the
hypervisor binary from those that happen after that. The latters may
have left some relevant messages in the console buffer, but the former
can make us dump confusing messages from a previous Jailhouse run.

Better let the user decide if the console content should be shown via an
explicit invocation of "jailhouse console".

Reported-and-suggested-by: Ralf Ramsauer <ralf.r...@oth-regensburg.de>
Signed-off-by: Jan Kiszka <jan.k...@siemens.com>
---
tools/jailhouse.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tools/jailhouse.c b/tools/jailhouse.c
index c23bb3bd..bc96b099 100644
--- a/tools/jailhouse.c
+++ b/tools/jailhouse.c
@@ -234,10 +234,8 @@ static int enable(int argc, char *argv[])
fd = open_dev();

err = ioctl(fd, JAILHOUSE_ENABLE, config);
- if (err) {
+ if (err)
perror("JAILHOUSE_ENABLE");
- dump_console(fd, true);
- }

close(fd);
free(config);
Reply all
Reply to author
Forward
0 new messages