[PATCH 01/21] arm: Avoid assignment in if clause

2 views
Skip to first unread message

Jan Kiszka

unread,
Sep 29, 2016, 4:22:48 PM9/29/16
to jailho...@googlegroups.com
Better readability, less risk to confuse with comparisons.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>
---
hypervisor/arch/arm/irqchip.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hypervisor/arch/arm/irqchip.c b/hypervisor/arch/arm/irqchip.c
index 8acf702..dfdc6ee 100644
--- a/hypervisor/arch/arm/irqchip.c
+++ b/hypervisor/arch/arm/irqchip.c
@@ -243,7 +243,8 @@ int irqchip_init(void)
gicd_base = GICD_BASE;
gicd_size = GICD_SIZE;

- if ((err = arch_map_device(gicd_base, gicd_base, gicd_size)) != 0)
+ err = arch_map_device(gicd_base, gicd_base, gicd_size);
+ if (err)
return err;

for (i = 3; i >= 0; i--) {
--
2.1.4

Reply all
Reply to author
Forward
0 new messages