[siemens/jailhouse] 425f61: tools: fix missing hardware-check after make insta...

6 views
Skip to first unread message

GitHub

unread,
Jun 23, 2016, 2:42:44 AM6/23/16
to jailho...@googlegroups.com
Branch: refs/heads/coverity_scan
Home: https://github.com/siemens/jailhouse
Commit: 425f61a96683fc2f9371180a4da55bab88f7b258
https://github.com/siemens/jailhouse/commit/425f61a96683fc2f9371180a4da55bab88f7b258
Author: Georg Schiesser <georg.s...@opentech.at>
Date: 2016-05-20 (Fri, 20 May 2016)

Changed paths:
M tools/Makefile

Log Message:
-----------
tools: fix missing hardware-check after make install

Add the new hardware-check script to the HELPERS, such that
"make install" will install it properly, just like the other
scripts, into: $DESTDIR/usr/local/libexec/jailhouse/

Signed-off-by: Georg Schiesser <georg.s...@opentech.at>
Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: 314922e8bb720d917e44906600a29ef6185b74ac
https://github.com/siemens/jailhouse/commit/314922e8bb720d917e44906600a29ef6185b74ac
Author: Xuguo Wang <hudd...@gmail.com>
Date: 2016-05-31 (Tue, 31 May 2016)

Changed paths:
M inmates/lib/cmdline.c

Log Message:
-----------
inmates/lib: cmdline.c

There is no point in checking for *p == 0 in the while loop,
after over the blanks, then checking for the parameters, if
find, return true, otherwise continue check the parameters,
if to the end of the cmdline, return false.

Signed-off-by: Xuguo Wang <hudd...@gmail.com>
[Jan: also removed curly braces]
Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: 3cfdd3aba4bb9a91bef54298522812ffcc22b3af
https://github.com/siemens/jailhouse/commit/3cfdd3aba4bb9a91bef54298522812ffcc22b3af
Author: Ralf Ramsauer <ra...@ramses-pyramidenbau.de>
Date: 2016-06-13 (Mon, 13 Jun 2016)

Changed paths:
M tools/jailhouse-config-create

Log Message:
-----------
tools: simplify python statement

Signed-off-by: Ralf Ramsauer <ra...@ramses-pyramidenbau.de>
Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: fe6decf9d3b9a4fd8412f2dbc0d939b965dcc073
https://github.com/siemens/jailhouse/commit/fe6decf9d3b9a4fd8412f2dbc0d939b965dcc073
Author: Jan Kiszka <jan.k...@siemens.com>
Date: 2016-06-13 (Mon, 13 Jun 2016)

Changed paths:
M hypervisor/arch/x86/amd_iommu.c
M hypervisor/arch/x86/include/asm/amd_iommu.h

Log Message:
-----------
x86: Add missing include to amd_iommu.h

Reported by header-check script: We need this in the header due to the
use of struct jailhouse_memory. Consequently, we can remove the include
from the corresponding amd_iommu.c.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: 6b7bef821e30d07f3a922c60ba34da623b2a0b31
https://github.com/siemens/jailhouse/commit/6b7bef821e30d07f3a922c60ba34da623b2a0b31
Author: cyng93 <cyn...@gmail.com>
Date: 2016-06-15 (Wed, 15 Jun 2016)

Changed paths:
A Documentation/setup-on-banana-pi-arm-board.md
M README.md

Log Message:
-----------
Documentation: Move BananaPi-related docs out

This patch move BananaPi-related documentation out from `README.md` to
`Documentation/setup-on-banana-pi-arm-board.md`

Signed-off-by: CHING-YI NG <cyn...@gmail.com>
[Jan: removed some blank lines from README.md]
Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: 60121418e65109e6280d6aa591d6558b66dab70b
https://github.com/siemens/jailhouse/commit/60121418e65109e6280d6aa591d6558b66dab70b
Author: cyng93 <cyn...@gmail.com>
Date: 2016-06-15 (Wed, 15 Jun 2016)

Changed paths:
M Documentation/setup-on-banana-pi-arm-board.md

Log Message:
-----------
Documentation: More BananaPi documentation

This patch include more details about how to setup Jailhouse on a BananaPi-M1 board.

Basically this documentation covered:
1. Installation of Bananian(BananaPi offical OS) on BananaPi
2. Modifying U-boot configuration on BananaPi to run Jailhouse.
3. Update Bananian to newer kernel so Jailhouse could works.
- Compiling Kernel.
- Installing Kernel.
4. Installing Jailhouse on BananaPi.
5. Simple demo/test: Running Jailhouse with Freertos-cell on BananaPi.

Signed-off-by: CHING-YI NG <cyn...@gmail.com>
[Jan: removed external media link showing FUSE selection - not needed]
Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: a9f949b08350538dd52d28c4477f4fcb902b3848
https://github.com/siemens/jailhouse/commit/a9f949b08350538dd52d28c4477f4fcb902b3848
Author: Jan Kiszka <jan.k...@siemens.com>
Date: 2016-06-15 (Wed, 15 Jun 2016)

Changed paths:
M Documentation/setup-on-banana-pi-arm-board.md

Log Message:
-----------
Documentation: Rewrap Banana Pi README to 80 chars

For better readability in the absence of a markdown viewer.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: da353b5769a2a2266f206c1d0e53402e4b99386c
https://github.com/siemens/jailhouse/commit/da353b5769a2a2266f206c1d0e53402e4b99386c
Author: Jan Kiszka <jan.k...@siemens.com>
Date: 2016-06-16 (Thu, 16 Jun 2016)

Changed paths:
M hypervisor/arch/arm/asm-defines.c
M hypervisor/arch/arm/entry.S
M hypervisor/arch/arm/include/asm/percpu.h
M hypervisor/arch/arm/setup.c

Log Message:
-----------
arm: Use asm-defines.h for struct per_cpu members

Port the logic over from x86 and also drop CHECK_ASSUMPTION here.

The only slightly ugly detail: the PERCPU_SIZE_SHIFT define is now
duplicated in both asm/percpu.h instances because there is no good
generic header yet to hold it. Can be cleaned up later on.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: fd447ceecb0e2555d017c3b73c9bd5d9b62f1436
https://github.com/siemens/jailhouse/commit/fd447ceecb0e2555d017c3b73c9bd5d9b62f1436
Author: Jan Kiszka <jan.k...@siemens.com>
Date: 2016-06-16 (Thu, 16 Jun 2016)

Changed paths:
M hypervisor/arch/arm/smp-vexpress.c

Log Message:
-----------
arm: Add missing printk.h include

Some implicit inclusion disappeared.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: 7c2644bf2bd841b5d97a8f94856eb57b753a2ef9
https://github.com/siemens/jailhouse/commit/7c2644bf2bd841b5d97a8f94856eb57b753a2ef9
Author: Jan Kiszka <jan.k...@siemens.com>
Date: 2016-06-16 (Thu, 16 Jun 2016)

Changed paths:
M hypervisor/arch/arm/gic-v3.c

Log Message:
-----------
arm: Fix build warning in gic-v3

Leftover from the mmio_perform_access refactoring.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: 315273ebcf6d3cc2c28bc3744118fb2f66a72a54
https://github.com/siemens/jailhouse/commit/315273ebcf6d3cc2c28bc3744118fb2f66a72a54
Author: Jan Kiszka <jan.k...@siemens.com>
Date: 2016-06-16 (Thu, 16 Jun 2016)

Changed paths:
M hypervisor/arch/arm/include/asm/irqchip.h

Log Message:
-----------
arm: Remove unneeded include from irqchip.h

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: 0e82670826fd2283d7eb032a3eb11ccf8013c815
https://github.com/siemens/jailhouse/commit/0e82670826fd2283d7eb032a3eb11ccf8013c815
Author: Jan Kiszka <jan.k...@siemens.com>
Date: 2016-06-16 (Thu, 16 Jun 2016)

Changed paths:
M hypervisor/arch/arm/include/asm/irqchip.h
M hypervisor/arch/arm/irqchip.c

Log Message:
-----------
arm: Un-inline spi_in_cell

To big to be inlined, and we also want to avoid dereferencing struct
cell in the header due to upcoming include reordering.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: 03475882880dc5ae49d0852c628a8b8958be80ac
https://github.com/siemens/jailhouse/commit/03475882880dc5ae49d0852c628a8b8958be80ac
Author: Jan Kiszka <jan.k...@siemens.com>
Date: 2016-06-16 (Thu, 16 Jun 2016)

Changed paths:
M hypervisor/arch/arm/include/asm/irqchip.h
M hypervisor/arch/arm/irqchip.c

Log Message:
-----------
arm: Remove write-only priority field from pending_irq

We do not support interrupt priorities so far, and we may have to model
them differently into queues once we do. Remove the de facto unused
field.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: 3b6a758cb690553583fab3156bce14114775e726
https://github.com/siemens/jailhouse/commit/3b6a758cb690553583fab3156bce14114775e726
Author: Jan Kiszka <jan.k...@siemens.com>
Date: 2016-06-16 (Thu, 16 Jun 2016)

Changed paths:
M hypervisor/arch/arm/gic-v2.c
M hypervisor/arch/arm/gic-v3.c
M hypervisor/arch/arm/include/asm/irqchip.h
M hypervisor/arch/arm/irqchip.c

Log Message:
-----------
arm: Remove maintenance flag from pending_irq.type.sgi

It was always cleared.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: d62540a7a2a5a6c769550bd250c359bea3910795
https://github.com/siemens/jailhouse/commit/d62540a7a2a5a6c769550bd250c359bea3910795
Author: Jan Kiszka <jan.k...@siemens.com>
Date: 2016-06-16 (Thu, 16 Jun 2016)

Changed paths:
M hypervisor/arch/arm/gic-v2.c
M hypervisor/arch/arm/gic-v3.c
M hypervisor/arch/arm/include/asm/irqchip.h
M hypervisor/arch/arm/irqchip.c

Log Message:
-----------
arm: Remove hw flag from pending_irq

Can be derived from virt_id.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: 05c1d67e0a7913f967a49a76de8cf93dafba1489
https://github.com/siemens/jailhouse/commit/05c1d67e0a7913f967a49a76de8cf93dafba1489
Author: Jan Kiszka <jan.k...@siemens.com>
Date: 2016-06-16 (Thu, 16 Jun 2016)

Changed paths:
M hypervisor/arch/arm/gic-v2.c
M hypervisor/arch/arm/include/asm/irqchip.h
M hypervisor/arch/arm/irqchip.c

Log Message:
-----------
arm: Remove cpuid from pending_irq

Was always set to 0.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: 35a46c75c5eb577c9c780340cdbc92d844d1eaca
https://github.com/siemens/jailhouse/commit/35a46c75c5eb577c9c780340cdbc92d844d1eaca
Author: Jan Kiszka <jan.k...@siemens.com>
Date: 2016-06-16 (Thu, 16 Jun 2016)

Changed paths:
M hypervisor/arch/arm/gic-v2.c
M hypervisor/arch/arm/gic-v3.c
M hypervisor/arch/arm/include/asm/irqchip.h
M hypervisor/arch/arm/irqchip.c

Log Message:
-----------
arm: Remove irq field from pending_irq

Always identical to virt_id.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: b77b9793126fd278ec3839cbead5bf21a389bdd0
https://github.com/siemens/jailhouse/commit/b77b9793126fd278ec3839cbead5bf21a389bdd0
Author: Jan Kiszka <jan.k...@siemens.com>
Date: 2016-06-16 (Thu, 16 Jun 2016)

Changed paths:
M hypervisor/arch/arm/include/asm/irqchip.h
M hypervisor/arch/arm/irqchip.c

Log Message:
-----------
arm: Remove return code from irqchip_inject_pending

It's always 0.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: f5dcc13bcf89d190d35b99cf79a8586ea7c1a93d
https://github.com/siemens/jailhouse/commit/f5dcc13bcf89d190d35b99cf79a8586ea7c1a93d
Author: Jan Kiszka <jan.k...@siemens.com>
Date: 2016-06-16 (Thu, 16 Jun 2016)

Changed paths:
M hypervisor/arch/arm/include/asm/irqchip.h
M hypervisor/arch/arm/irqchip.c

Log Message:
-----------
arm: Remove unused return code of irqchip_set_pending

No caller evaluated it so far, and none of them has a use case for it.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: 35b1928d4977040a4a9f4fc1f2a093882182a953
https://github.com/siemens/jailhouse/commit/35b1928d4977040a4a9f4fc1f2a093882182a953
Author: Jan Kiszka <jan.k...@siemens.com>
Date: 2016-06-16 (Thu, 16 Jun 2016)

Changed paths:
M hypervisor/arch/arm/gic-v2.c
M hypervisor/arch/arm/gic-v3.c
M hypervisor/arch/arm/include/asm/irqchip.h
M hypervisor/arch/arm/irqchip.c

Log Message:
-----------
arm: Disable maintenance interrupt on successful injection

We enable the maintenance interrupt when all list registers are in use.
However, there was no disabling of it again. Apparently, it rarely
triggered in the field, otherwise we would have seen a lot of
maintenance interrupt storms, thus locked-up systems.

This introduces another callback to enable or disable the maintenance
interrupt. It is now controlled by irqchip_inject_pending, the function
that is also called when handling a maintenance interrupt.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: 9fc9f67f05c9fbe872f647a0d47f54e7dbb9b90f
https://github.com/siemens/jailhouse/commit/9fc9f67f05c9fbe872f647a0d47f54e7dbb9b90f
Author: Jan Kiszka <jan.k...@siemens.com>
Date: 2016-06-16 (Thu, 16 Jun 2016)

Changed paths:
M hypervisor/arch/arm/gic-v2.c
M hypervisor/arch/arm/gic-v3.c
M hypervisor/arch/arm/irqchip.c

Log Message:
-----------
arm: Make sure to not queue interrupt that were rejected as duplicates

If the inject_irq callback detect that an interrupt is already queued
in some list register, do not insert it into the software queue, thus
coalesce the event like real hardware does.

The change in the return code of inject_irq is more cosmetic, to reflect
the meaning better.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: 8b121b498b6e2f204c9b128b42e5423118be220b
https://github.com/siemens/jailhouse/commit/8b121b498b6e2f204c9b128b42e5423118be220b
Author: Jan Kiszka <jan.k...@siemens.com>
Date: 2016-06-16 (Thu, 16 Jun 2016)

Changed paths:
M hypervisor/arch/arm/gic-v2.c
M hypervisor/arch/arm/gic-v3.c
M hypervisor/arch/arm/include/asm/irqchip.h
M hypervisor/arch/arm/include/asm/percpu.h
M hypervisor/arch/arm/irqchip.c

Log Message:
-----------
arm: Convert software queue of pending interrupts into a ring

This massively simplifies the code and reduces the memory usage in
struct per_cpu. However, adding interrupt priorities later on may
require another rework.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: c8a9a6f84885c366160a394aaaf08715e426eaf4
https://github.com/siemens/jailhouse/commit/c8a9a6f84885c366160a394aaaf08715e426eaf4
Author: Jan Kiszka <jan.k...@siemens.com>
Date: 2016-06-16 (Thu, 16 Jun 2016)

Changed paths:
M hypervisor/arch/arm/control.c
M hypervisor/arch/arm/gic-common.c
M hypervisor/arch/arm/include/asm/irqchip.h
M hypervisor/arch/arm/irqchip.c

Log Message:
-----------
arm: Remove try_inject parameter from irqchip_set_pending

We can only perform injection (and we also always want to) if target
CPU equals caller CPU, and this is better checked inside the function.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: e24bab3f5e70d877d470659569f22e2838813d0f
https://github.com/siemens/jailhouse/commit/e24bab3f5e70d877d470659569f22e2838813d0f
Author: Jan Kiszka <jan.k...@siemens.com>
Date: 2016-06-16 (Thu, 16 Jun 2016)

Changed paths:
M hypervisor/arch/arm/irqchip.c

Log Message:
-----------
arm: Enable maintenance interrupt also from irqchip_set_pending

In case we set an interrupt pending for the local CPU and cannot queue
it with the hardware, make sure the maintenance interrupt is on.
Otherwise, we risk to delay guest interrupts or cause the guest to get
stuck.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: 6f28047e0f4d78af4a712e6f1f2824e9a030a888
https://github.com/siemens/jailhouse/commit/6f28047e0f4d78af4a712e6f1f2824e9a030a888
Author: Jan Kiszka <jan.k...@siemens.com>
Date: 2016-06-16 (Thu, 16 Jun 2016)

Changed paths:
M hypervisor/arch/arm/gic-v2.c
M hypervisor/arch/arm/gic-v3.c

Log Message:
-----------
arm: Enable / disable maintenance interrupt in distributor

We did not get any maintenance interrupts so far because we didn't
enable the source in the distributor so far. Fix this, but also disable
it again when shutting down.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: 0d6e739275f949d52ecdc0086d9cee7ee2a67162
https://github.com/siemens/jailhouse/commit/0d6e739275f949d52ecdc0086d9cee7ee2a67162
Author: Jan Kiszka <jan.k...@siemens.com>
Date: 2016-06-16 (Thu, 16 Jun 2016)

Changed paths:
M hypervisor/arch/arm/gic-common.c

Log Message:
-----------
arm: Protect hypervisor used SGIs and PPIs from cell changes

We must not allow the cells to manipulate distributor registers or
register bits related to the hypervisor SGIs or the maintenance
interrupt.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: 643704b3f70d674198b6e7c0406fa477675780af
https://github.com/siemens/jailhouse/commit/643704b3f70d674198b6e7c0406fa477675780af
Author: Jan Kiszka <jan.k...@siemens.com>
Date: 2016-06-16 (Thu, 16 Jun 2016)

Changed paths:
M hypervisor/arch/arm/irqchip.c

Log Message:
-----------
arm: Make cpu_init and cpu_reset callbacks mandatory

No need for checking them to be NULL, we need them in both
implementations.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: f21a0a9e05dec0ef94742452fa44c5446c2d5c06
https://github.com/siemens/jailhouse/commit/f21a0a9e05dec0ef94742452fa44c5446c2d5c06
Author: Jan Kiszka <jan.k...@siemens.com>
Date: 2016-06-16 (Thu, 16 Jun 2016)

Changed paths:
M hypervisor/arch/arm/irqchip.c

Log Message:
-----------
arm: Reject unknown GIC versions

We would likely crash anyway due to irqchip containing only NULL
pointers.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: cb69df65432fd50a4a09faf91ade768c442d1a45
https://github.com/siemens/jailhouse/commit/cb69df65432fd50a4a09faf91ade768c442d1a45
Author: Jan Kiszka <jan.k...@siemens.com>
Date: 2016-06-16 (Thu, 16 Jun 2016)

Changed paths:
M hypervisor/arch/arm/gic-v2.c
M hypervisor/arch/arm/gic-v3.c
M hypervisor/arch/arm/irqchip.c

Log Message:
-----------
arm: Consolidate gic_irqchip to irqchip

Likely, we will never support alternative irqchips to the GIC (only
cascaded ones). So this copying-over is not required.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: ce2fd7f789ae43a26548ad4ada9503bc2a35780d
https://github.com/siemens/jailhouse/commit/ce2fd7f789ae43a26548ad4ada9503bc2a35780d
Author: Jan Kiszka <jan.k...@siemens.com>
Date: 2016-06-18 (Sat, 18 Jun 2016)

Changed paths:
M tools/Makefile

Log Message:
-----------
tools: Include EXTRA_CFLAGS into build

This allows to pass in additional flags or override existing ones, just
like it is already possible for the parts under Kbuild control.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: 872cc198b05531017682f30fafa26e9988656e38
https://github.com/siemens/jailhouse/commit/872cc198b05531017682f30fafa26e9988656e38
Author: Jan Kiszka <jan.k...@siemens.com>
Date: 2016-06-18 (Sat, 18 Jun 2016)

Changed paths:
M Kbuild
M tools/Makefile

Log Message:
-----------
Enforce zero warnings

Break the build in case of warnings. Can still be temporarily
overwritten by appending EXTRA_CFLAGS=-Wno-error to a build.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: b38a2025e17539c7f013bb0c3336eb8ec557e649
https://github.com/siemens/jailhouse/commit/b38a2025e17539c7f013bb0c3336eb8ec557e649
Author: Jan Kiszka <jan.k...@siemens.com>
Date: 2016-06-20 (Mon, 20 Jun 2016)

Changed paths:
M .gitignore

Log Message:
-----------
gitignore: Remove user-specific rules

A project's .gitignore should be about project-specific rules, shared by
everyone compiling it. So, instead of adding more and more rules for
user-specific editors or tools, remove them completely and no longer
accept new ones. Users can easily define local rules, see gitignore man
page.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Commit: 0c791ccd130199552fd95822c2e0cb6e04b1348d
https://github.com/siemens/jailhouse/commit/0c791ccd130199552fd95822c2e0cb6e04b1348d
Author: Jan Kiszka <jan.k...@siemens.com>
Date: 2016-06-23 (Thu, 23 Jun 2016)

Changed paths:
M hypervisor/arch/arm/gic-common.c

Log Message:
-----------
arm: Fix byte-wise write access to GICD_ITARGETSRn

While expanding byte accesses to full words, we forgot to adjust the
address as well. This led to unaligned word accesses on writes, followed
by hypervisor aborts.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>


Compare: https://github.com/siemens/jailhouse/compare/5c2c2445bec0...0c791ccd1301
Reply all
Reply to author
Forward
0 new messages