Getting "TypeError" javascript error when trying to edit record from a list (admin console)

[Alexander Obuhovich]

In-Portal uses getFrame method to reach it's main window (when working with Admin Console) by intellectually traversing through all opened windows and frames (see "getFrame" javascript method).

However this "getFrame" method can return a reference outside Admin Console frameset at all. For example to a window/tab, that had a link to an Admin Console.

There are 2 ways to prevent this:

1. don't check for window.opener when we're already in frameset main window
2. check if found window.location.hostname of found window is the same as one we're started traversing with (basically same domain+base_path)

Without this if you're opening in-portal windows using links on other websites and not by directly typing url you might see problem described above.

--
Best Regards,

http://www.in-portal.com
http://www.alex-time.com

[Dmitry A.]

Thanks for submitting it here Alex.

Here is a task for it:

1277: "TypeError" Javascript error cased by getFrame in Admin - http://tracker.in-portal.org/view.php?id=1277 

DA 

[Alexander Obuhovich]

Here is the patch. Ready for testing.

DA 

--
You received this message because you are subscribed to the Google Groups "In-Portal Bugs Team" group.
To view this discussion on the web visit https://groups.google.com/d/msg/in-portal-bugs/-/C5CvCL4QFOcJ.
To post to this group, send email to in-port...@googlegroups.com.
To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en.

[Dmitry A.]

Patch tested good - please commit

DA 

[Alexander Obuhovich]

Thanks for testing, but you forgot to set "reviewed & tested" status in In-Portal Issue Tracker. I've set it manually on your behalf.

On Wed, May 30, 2012 at 8:48 AM, Dmitry A. <dand...@gmail.com> wrote:

Patch tested good - please commit

DA 

--

You received this message because you are subscribed to the Google Groups "In-Portal Bugs Team" group.

To view this discussion on the web visit https://groups.google.com/d/msg/in-portal-bugs/-/UaoCyiEUf8oJ.

To post to this group, send email to in-port...@googlegroups.com.
To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en.

[Dmitry A.]

Thanks - looks good!

DA