Wrong Link in Link Approve Email

[Phil -- wbtc.fr --]

Hi guys,

in LINK.APPROVE e-mail, we have  <inp2:l_LinkLink template="__default__"/>   to display a direct link for the user to see his link.

The URL is wrong, because it have "admin" in it: http://sitename.com/admin/link-detail , and the user have an error message instead of his link.

p

[Dmitry A.]

Hi Phil,

Please try to describe the complete scenario.

Thanks

[Phil -- wbtc.fr --]

Hi Dmitry,

1- setup up "link.add.pending" for an in-link category
2- create a new link from front-end inside this category (after being logged of course)
3- approve the link in admin
4- user receive the "link.approve" email, with buggy link

Just tested before posting on beta512, and discovered the bug on v510.

p

2011/2/4 Dmitry A. <dand...@gmail.com>

Hi Phil,

Please try to describe the complete scenario.

 Thanks

--
You received this message because you are subscribed to the Google Groups "In-Portal Bugs Team" group.
To post to this group, send email to in-port...@googlegroups.com.
To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en.

[Dmitry A.]

Thanks Phil, much better report now!

[Phil -- wbtc.fr --]

hehe you're welcome :)

2011/2/4 Dmitry A. <dand...@gmail.com>

Thanks Phil, much better report now!

--

[Alexander Obuhovich]

I guess tag LinkLink should be changed (actually ItemLink should be called, since LinkLink is just an alias to it), to apply this additional parameters, during link building, when called from Admin Console:

$params['index_file'] = 'index.php';

$params['prefix'] = '_FRONT_END_';

if ($this->Application->ConfigValue('UseModRewrite')) {

$params['__MOD_REWRITE__'] = 1;

}

--
Best Regards,

http://www.in-portal.com
http://www.alex-time.com

[Phil -- wbtc.fr --]

this look like a begining of a patch, I can test it if you tell me where it should be inserted

2011/2/4 Alexander Obuhovich <aik....@gmail.com>

[Dmitry A.]

Hi Phil,

Here is a patch - please test for all type of Items (Link, Article, Product). Also, check if it still works okay when no approval needed and . Basically, it's very widely used tag for all Catalog Items and needs to be properly tested.

Alex, I have checked on all places which call for kCatDBTagProcessor::ItemLink method and looks like most are for the Fron-end so I decided to make the change in there instead 4 copies (1 for each module). Please review the code and let me know what you think.

DA

[Alexander Obuhovich]

Actually patch doesn't check for Admin as I've proposed and adds that 3 parameters always.

Did you checked that this has no side effect on Front-end when mod-rewrite is enabled and when it's not enabled?

--

You received this message because you are subscribed to the Google Groups "In-Portal Bugs Team" group.
To post to this group, send email to in-port...@googlegroups.com.
To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en.

[Dmitry A.]

Yes, you are right Alex,

Please find updated Patch.

Phil, please test on your end too and let us know so we can create a task for this.

DA

[Alexander Obuhovich]

Also isset around each parameter isn't necessary, since nobody gives any additional parameters (except template) to LinkLink tag anyway.

DA

--

You received this message because you are subscribed to the Google Groups "In-Portal Bugs Team" group.
To post to this group, send email to in-port...@googlegroups.com.
To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en.

[Dmitry A.]

Actually, I have checked and there are 3 places where kCatDBTagProcessor::ItemLink method is called from the same Class.

2 out of 3 have no much parameters passed while kCatDBTagProcessor::PageBrowseLink passed some it's own stuff and is called from Admin of course. Not that it's params will be overwritten in this case, I am more worries about future changes which might or might not occur of course...

DA

[Phil -- wbtc.fr --]

your first patch was working well for email link but was adding
"_FRONT_END_" in url of all links on front end, immediatly after TLD
and before the first "/"

2011/2/6 Dmitry A. <dand...@gmail.com>:

[Dmitry A.]

I had the same results.

Let's see what my 2nd patch does.

DA

[Phil -- wbtc.fr --]

yup, actually no bug encountered, tested again.

2011/2/6 Dmitry A. <dand...@gmail.com>:

> I had the same results.
> Let's see what my 2nd patch does.
>
> DA
>

[Dmitry A.]

Here is a task for this:

995: Incorrect Catalog Item Detail Url is build in Emails when triggered from Admin

http://tracker.in-portal.org/view.php?id=995

DA