Near to impossible to get 404 Not Found page with new Rewrite Listeners

[Alexander Obuhovich]

In new rewrite listener engine it's near to impossible to get 404 Not Found page in case if at least one part of url was interpreted by rewrite listener. For example in if have urls in format "/friends/<friend_name>" (friend detail page) and we have "/friends" (friend list). At parsing start we look for "friends" at url start if so, then appropriate FriendRewriteListener begins to parse. If there are no more url parts, then show list. If there is more part, then threat it as friend name and display it's page. In case if friend not found we should normally display "404 Not Found", but instead we do nothing and assuming, that next rewrite listener will take care of that, because it really could do that, who knows.

To solve this problem I propose to let rewrite listener mark url parts, that are processed by it (part order number). At the end in case if total processed part count doesn't match count part in url we will automatically show 404 Not Found page.

--
Best Regards,

http://www.in-portal.com
http://www.alex-time.com

[Dmitry A.]

Well, it's quite deep, but I suppose you are right here.

Question is where we are adding this 5.1.0?

Remember we have the following task for this release:

459: Improve Mod-rewrite Listener by separating into Parsing and
Building methods

http://tracker.in-portal.org/view.php?id=459

Cheers.

[Alexander Obuhovich]

I think, that we should address this issue at some point, since it's no good, when all urls on the site shows something, even broken ones.

For example http://www.website.com/articles/not_found_article.html and http://www.website.com/articles.html will lead to the same page and Google doesn't like that.

--
You received this message because you are subscribed to the Google Groups "In-Portal Bugs Team" group.
To post to this group, send email to in-port...@googlegroups.com.
To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en.

[Phil -- wbtc.fr --]

and in many subcategories you can type /rtrsfoihrepofk and it display /. page

2010/12/13 Alexander Obuhovich <aik....@gmail.com>:

[Dmitry A.]

Yes, it's been sitting there for almost a year already :)

Alex, what are your forecast on this in terms development time and afford?  I am asking since I believe you have the most expertise in ModRewrite Listeners at this point.

Thanks!

DA

[Alexander Obuhovich]

It's about 1.5 hours to implement.

--

You received this message because you are subscribed to the Google Groups "In-Portal Bugs Team" group.
To post to this group, send email to in-port...@googlegroups.com.
To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en.

[Dmitry A.]

Thanks for quoting, Alex.

What is your opinion on when we should spend time and include this in, 5.1.x or 5.2.x?

DA

[Alexander Obuhovich]

It is too small to be placed in 5.2.0, so 5.1.x is right place for it.

DA

--

You received this message because you are subscribed to the Google Groups "In-Portal Bugs Team" group.
To post to this group, send email to in-port...@googlegroups.com.
To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en.

[Alexander Obuhovich]

Do we need to create a task here?

[Dmitry A.]

Yes, we DEFINITELY need this to be resolved. I have already came across this not too long ago in one of my projects.

Here is a task:

1026: Impossible to get "404 Not Found" page with Rewrite Listeners

http://tracker.in-portal.org/view.php?id=1026

DA