Incorrect check for "variables_order" setting during installation

[Alexander Obuhovich]

We recently (in 5.2.0) introduced system setting step where PHP settings are checked to ensure that In-Portal can work on a given server.

1. I've noticed that we are checking if "variables_order" setting contains "GPC" string. But what we should be checking if each of "G", "P" and "C" letters are present in that variable no matter of their order.

Also "S" letter (for $_SERVER) presence should be checked as well.

2. Then additional check must be added for "request_order" setting. If it's value not empty, then check for "GP" presence in it. If it's value is empty, then check for "GP" presence in "variables_order" instead.

More info here: http://www.php.net/manual/en/ini.core.php#ini.variables-order

--
Best Regards,

http://www.in-portal.com
http://www.alex-time.com

[Dmitry A.]

Hi Alex,

Thank you for detailed info on this.

Please proceed with this task / patch.

DA

[Alexander Obuhovich]

Here is the task: http://tracker.in-portal.org/view.php?id=1419

--
You received this message because you are subscribed to the Google Groups "In-Portal Bugs Team" group.
To view this discussion on the web visit https://groups.google.com/d/msg/in-portal-bugs/-/q4gktqOnZzUJ.
To post to this group, send email to in-port...@googlegroups.com.
To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en.

[Alexander Obuhovich]

Here is the patch.

Ready for testing.

[Alexander Obuhovich]

Here is screenshot of "System Requirements" step now. I think it looks much more understandable, then before.

[Phil]

Hi,

why not having system requ. explanations as a popup hint, near each line, instead of this long right column list?

just an idea to improve looking :)

p

Envoyé avec Sparrow

Pièces jointes :

- sys_requirements_step_w_description.png

[Dmitry A.]

Thank you Alex - you've done amazing job with translating.

A few very minor adjustments, but overall quality is very good - thanks again!

DA

[Alexander Obuhovich]

Yes, we can do as hints too. Just need to imagine how these hints might look like, because we don't use hints at all during installation.

To view this discussion on the web visit https://groups.google.com/d/msg/in-portal-bugs/-/LHO25SGgvEcJ.

To post to this group, send email to in-port...@googlegroups.com.
To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en.

[Phil]

like hints in admin, with blue rounded question mark, or just a link to hover "read more...".

Envoyé avec Sparrow

[Alexander Obuhovich]

Since we use same approach for all description on all installation wizard step, then it would be time consuming to move all descriptions into hints right now.

If you have time you of course can do that by moving texts from "/core/install/steps_db.xml" file into corresponding templates from "/core/install/step_templates/" folder.