libpano updated

139 views
Skip to first unread message

D M German

unread,
Jan 5, 2011, 7:27:32 AM1/5/11
to hugi...@googlegroups.com

I have added the Thoby projection for the Nikkor 10.5. It is now in
subversion. I have called it after Michel Thoby who was able to
empirically find it. If this projection helps with other lenses, I'll
add parameters to it.

The input projection number is 20.

Would the hugin developers add it to it? the libpano optimizer should be
capable of dealing with this new projection.

My very preliminary tests seem to imply it is working as expected. Once
it is available in hugin I'll be able to do more testing.

-dmg


--
--
Daniel M. German
http://turingmachine.org/
http://silvernegative.com/
dmg (at) uvic (dot) ca
replace (at) with @ and (dot) with .

Jeffrey Martin

unread,
Jan 5, 2011, 7:49:01 AM1/5/11
to hugi...@googlegroups.com
This is fantastic. Nice work Daniel! And a big thanks to Michel Thoby!

Kornel Benko

unread,
Jan 5, 2011, 9:51:50 AM1/5/11
to hugi...@googlegroups.com

Am Mittwoch, 5. Januar 2011 schrieb D M German:

> I have added the Thoby projection for the Nikkor 10.5. It is now in

> subversion. I have called it after Michel Thoby who was able to

> empirically find it. If this projection helps with other lenses, I'll

> add parameters to it.

>

> The input projection number is 20.

>

> Would the hugin developers add it to it? the libpano optimizer should be

> capable of dealing with this new projection.

>

> My very preliminary tests seem to imply it is working as expected. Once

> it is available in hugin I'll be able to do more testing.

>

>

>

> -dmg

Nice, but dump.h should be commited too :)

...

/usr/bin/gcc -Dpano13_EXPORTS -D__Ansi__ -O3 -DNDEBUG -fPIC -I/usr/src/panotools/trunk/libpano -o CMakeFiles/pano13.dir/dump.c.o -c /usr/src/panotools/trunk/libpano/dump.c

/usr/src/panotools/trunk/libpano/dump.c:31: fatal error: dump.h: Datei oder Verzeichnis nicht gefunden

Kornel

signature.asc

dmg

unread,
Jan 5, 2011, 1:41:43 PM1/5/11
to hugi...@googlegroups.com
On Wed, Jan 5, 2011 at 6:51 AM, Kornel Benko <Kornel...@berlin.de> wrote:
> Nice, but dump.h should be commited too :)
>
> ...

Done


--
--dmg

---
Daniel M. German
http://turingmachine.org

Andreas Metzler

unread,
Jan 5, 2011, 1:47:30 PM1/5/11
to hugi...@googlegroups.com
D M German <d...@uvic.ca> wrote:
> I have added the Thoby projection for the Nikkor 10.5. It is now in
> subversion.
[...]

Hello,
FYI the respective commit contains a couple of unrelated and probably
unintional changes:

ametzler@argenau:~/SVN/upstream/libpano$ lsdiff /tmp/1306.diff
debian/control
debian/compat
debian/libpano13-bin.install
debian/TODO
debian/libpano13-bin.docs
debian/watch
debian/changelog
debian/patches/10_workaround_libtool_link_as_needed_bug
debian/patches/series
debian/patches/20_bumpsoname.diff
debian/copyright
debian/libpano13-dev.install
debian/rules
debian/README.source
debian/libpano13-2.install
panorama.h
doc/stitch.txt
math.c
adjust.c
PTcommon.c
ChangeLog
filter.h
parser.c
CMakeLists.txt
dump.c

* There does not seem to be a point in adding an (outdated) debian/
subdirectory, I guess this was an error?

* The change to PTcommon.c is not explained in commit message or
changelog.

-------------------------------
--- PTcommon.c (Revision 1305)
+++ PTcommon.c (Revision 1306)
@@ -533,6 +533,7 @@
newX = (int)(Dx2 + 0.5 + sw2);
newY = (int)(Dy2 + 0.5 + sh2);

+ #ifdef XXXXX
if (newX != x || newY != y) {
printf(" X,Y: %7.1f,%7.1f (%5d,%5d) -> OUT: %9.1f, %9.1f inv -> %9.1f %9.1f (%5d, %5d) -- error %5d,%5d\n",
x_d, y_d,
@@ -544,6 +545,7 @@
newY - y
);
}
+ #endif
// If this assertion fails, there is an error. The question is, how big? See the values above.
// it is possible that the error is so small that it does not matter.
/*
-------------------------------

thanks, cu andreas
--
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'

dmg

unread,
Jan 5, 2011, 1:57:58 PM1/5/11
to hugi...@googlegroups.com
To be honest, I don't know how it got in. I noticed after the commit,
but it was too late last night.
I am going to delete it. I must have added it by accident.

On Wed, Jan 5, 2011 at 10:47 AM, Andreas Metzler
<amet...@downhill.at.eu.org> wrote:
>
>
> * There does not seem to be a point in adding an (outdated) debian/
>  subdirectory, I guess this was an error?
>

The change to PTcommon.h? Debugging code. I want to know how stable
the transformations are.

dmg

unread,
Jan 5, 2011, 2:03:09 PM1/5/11
to hugi...@googlegroups.com
I have committed the changes to SVN.

Andreas Metzler

unread,
Jan 6, 2011, 3:26:39 AM1/6/11
to hugi...@googlegroups.com
dmg <d...@uvic.ca> wrote:
> I have committed the changes to SVN.
[...]

Thank you very much.

cu andreas

Reply all
Reply to author
Forward
0 new messages