Where in Git are the 3.7 controls in masterfiles?

13 views
Skip to first unread message

Aleksey Tsalolikhin

unread,
Sep 27, 2016, 11:09:50 PM9/27/16
to help-cfengine
Hello,

Mike Weilgart and I found the following comment in controls/3.7/cf_agent.cf confusing:

      # This should normally be set to an interval like 1-5 mins
      # We set it to one initially to avoid confusion.

      ifelapsed => "1";

The confusing part is that ifelapsed does not take an interval on the RHS, it takes an integer value that is the minimum time which should have passed since the last time the promise was verified.

I wanted to propose a pull request to clarify this, but I can't find the "3.7" directory in https://github.com/cfengine/masterfiles/tree/master/controls

Where are the 3.7 controls in Git, please?

Best,
-at

-- 
Need training on CFEngine, Git or Time Management?  Email trai...@verticalsysadmin.com.

nick.a...@cfengine.com

unread,
Sep 27, 2016, 11:30:23 PM9/27/16
to help-cfengine, Aleksey Tsalolikhin
https://github.com/cfengine/masterfiles/blob/master/controls/cf_agent.cf

In 3.8 controls and the stdlib version splits were removed.

Thanks for the forthcoming pr ;-)

Sent from my android device.
--
You received this message because you are subscribed to the Google Groups "help-cfengine" group.
To unsubscribe from this group and stop receiving emails from it, send an email to help-cfengin...@googlegroups.com.
To post to this group, send email to help-c...@googlegroups.com.
Visit this group at https://groups.google.com/group/help-cfengine.
For more options, visit https://groups.google.com/d/optout.

Aleksey Tsalolikhin

unread,
Sep 28, 2016, 1:08:39 AM9/28/16
to Nick Anderson, help-cfengine
Man... cracking the whip....  Thanks, Nick.  :)   




On Tue, Sep 27, 2016 at 8:30 PM, <nick.a...@cfengine.com> wrote:
https://github.com/cfengine/masterfiles/blob/master/controls/cf_agent.cf

In 3.8 controls and the stdlib version splits were removed.

Thanks for the forthcoming pr ;-)

Sent from my android device.


-----Original Message-----
From: Aleksey Tsalolikhin <ale...@verticalsysadmin.com>
To: help-cfengine <help-cfengine@googlegroups.com>
Sent: Tue, 27 Sep 2016 10:09 PM
Subject: [help-cfengine] Where in Git are the 3.7 controls in masterfiles?

Hello,

Mike Weilgart and I found the following comment in controls/3.7/cf_agent.cf confusing:

      # This should normally be set to an interval like 1-5 mins
      # We set it to one initially to avoid confusion.

      ifelapsed => "1";

The confusing part is that ifelapsed does not take an interval on the RHS, it takes an integer value that is the minimum time which should have passed since the last time the promise was verified.

I wanted to propose a pull request to clarify this, but I can't find the "3.7" directory in https://github.com/cfengine/masterfiles/tree/master/controls

Where are the 3.7 controls in Git, please?

Best,
-at

-- 
Need training on CFEngine, Git or Time Management?  Email trai...@verticalsysadmin.com.

--
You received this message because you are subscribed to the Google Groups "help-cfengine" group.
To unsubscribe from this group and stop receiving emails from it, send an email to help-cfengine+unsubscribe@googlegroups.com.
Reply all
Reply to author
Forward
0 new messages