Issue 71 in peaberry: java.lang.IllegalAccessError when using LdapFilter

[peab...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 71 by jerome.j...@gmail.com: java.lang.IllegalAccessError when
using LdapFilter
http://code.google.com/p/peaberry/issues/detail?id=71

The line

AttributeFilter ldap = Filters.ldap("(module=three)");

produce the following Stack trace

Exception in thread "main" java.lang.IllegalAccessError: tried to access
class org.osgi.framework.FrameworkUtil$FilterImpl from class
org.ops4j.peaberry.internal.FrameworkUtil
at
org.ops4j.peaberry.internal.FrameworkUtil.createFilter(FrameworkUtil.java:76)
at
org.ops4j.peaberry.util.ldap.LdapAttributeFilter.<init>(LdapAttributeFilter.java:39)
at org.ops4j.peaberry.util.Filters.ldap(Filters.java:43)
at Test.main(Test.java:11)

Using Peaberry 1.2

[peab...@googlecode.com]

Comment #1 on issue 71 by romain.g...@gmail.com:

java.lang.IllegalAccessError when using LdapFilter
http://code.google.com/p/peaberry/issues/detail?id=71

I think the issue comes from the jarjar plugin configuration

[peab...@googlecode.com]

Comment #2 on issue 71 by romain.g...@gmail.com:

java.lang.IllegalAccessError when using LdapFilter
http://code.google.com/p/peaberry/issues/detail?id=71

I would like to know why there are those specific rules:

<rule>
<pattern>org.osgi.framework.Filter</pattern>
<result>org.ops4j.peaberry.internal.Filter</result>
</rule>
<rule>
<pattern>org.osgi.framework.FrameworkUtil</pattern>
<result>org.ops4j.peaberry.internal.FrameworkUtil</result>
</rule>
<rule>
<pattern>org.osgi.framework.InvalidSyntaxException</pattern>

<result>org.ops4j.peaberry.internal.InvalidSyntaxException</result>
</rule>

[peab...@googlecode.com]

Comment #3 on issue 71 by mccu...@gmail.com: java.lang.IllegalAccessError

when using LdapFilter
http://code.google.com/p/peaberry/issues/detail?id=71

There was a feature request for the filter code to work outside of OSGi, so
we embed a filter implementation plus its API - since neither the API or
implementation are exposed outside of the bundle it is meant to be jarjar'd
so that it is truly independent whether running inside OSGi or part of a
classic Java classpath.

It looks like the jarjar repackaging is missing the filter subclass, which
would explain the exception.

[peab...@googlecode.com]

Comment #4 on issue 71 by romain.g...@gmail.com:

java.lang.IllegalAccessError when using LdapFilter
http://code.google.com/p/peaberry/issues/detail?id=71

So clearly if you remove those rules everything work fine. Those rules are
here to make filter available outside maven environment?

[peab...@googlecode.com]

Comment #5 on issue 71 by mccu...@gmail.com: java.lang.IllegalAccessError

when using LdapFilter
http://code.google.com/p/peaberry/issues/detail?id=71

The main reason to jarjar the filter implementation is to avoid classpath
conflicts when running outside of OSGi, and to avoid exposing a dependency
on a full OSGi implementation when we really only require the LDAP filter.

[peab...@googlecode.com]

Comment #6 on issue 71 by romain.g...@gmail.com:

java.lang.IllegalAccessError when using LdapFilter
http://code.google.com/p/peaberry/issues/detail?id=71

Yes the error comes from the missing inner class. Jarjar does not handle
the inner class or something like that with this configuration.
Are you sure that this configuration will be enough because if you have a
look to the Filter class it required the ServiceReference and then by
transitivity Bundle and ...

Romain

[peab...@googlecode.com]

Comment #7 on issue 71 by romain.g...@gmail.com:

java.lang.IllegalAccessError when using LdapFilter
http://code.google.com/p/peaberry/issues/detail?id=71

I'm able to reproduce the issue with an integration test (pax exam) added
in the peaberry.activation.test project.
----
Tests in error:
testLdap(org.ops4j.peaberry.util.FiltersTest):
org/osgi/framework/FrameworkUtil$FilterImpl

Tests run: 11, Failures: 0, Errors: 1, Skipped: 0
----

Romain

[peab...@googlecode.com]

Comment #8 on issue 71 by romain.g...@gmail.com:

java.lang.IllegalAccessError when using LdapFilter
http://code.google.com/p/peaberry/issues/detail?id=71

I have updated the pea

[peab...@googlecode.com]

Comment #9 on issue 71 by romain.g...@gmail.com:

java.lang.IllegalAccessError when using LdapFilter
http://code.google.com/p/peaberry/issues/detail?id=71

I have updated the jarjar configuration as follow:
<rule>
<pattern>org.osgi.framework.FrameworkUtil*</pattern>
<result>org.ops4j.peaberry.internal.FrameworkUtil@1</result>
</rule>
By this way all the inner classes are moved but I still have the same
exception.

[peab...@googlecode.com]

Comment #10 on issue 71 by mccu...@gmail.com: java.lang.IllegalAccessError

when using LdapFilter
http://code.google.com/p/peaberry/issues/detail?id=71

I've added a basic test and a fix to the jarjar config - make sure you
rebuild from the top-level directory.

[peab...@googlecode.com]

Comment #11 on issue 71 by romain.g...@gmail.com:

java.lang.IllegalAccessError when using LdapFilter
http://code.google.com/p/peaberry/issues/detail?id=71

Ok everything works on my side I think the issue can be close.
May I suggest you something?
I think the new peaberry integration test project for this test in
particular should not depends on 'osgi.core'.
I have created a patch that reorganize this dependency.

Romain.

Attachments:
reorganize_osgi_core_dependency.patch 26.7 KB

[peab...@googlecode.com]

Updates:
Status: Fixed

Comment #12 on issue 71 by mccu...@gmail.com: java.lang.IllegalAccessError

when using LdapFilter
http://code.google.com/p/peaberry/issues/detail?id=71

peaberry.tests/pom.xml currently excludes compile/system/provided scope
dependencies in the surefire configuration, to make sure inherited compile
dependencies don't accidentally leak onto the test classpath:


http://maven.apache.org/plugins/maven-surefire-plugin/examples/configuring-classpath.html#Removing_Dependency_Classpath_Elements

But yes, probably worth cleaning up the parent dependencies to avoid such a
leak in the first place.