"@grant none" (or auto-detected none) combined with JQuery == Bad News

[Jay Rossiter / Signe]

I saw a lot of complaints on the addons page about how scripts that @require
jquery weren't working. I started encountering the same issue when I got
upgraded last night. At first, I thought that it was RES (Reddit Enhancement
Suite) that was causing the problems, but it turns out that it was a small
script that I had written that was also running. This is the problem in short:

When using @grant none, or auto-detect with no GM_* functions, the @required
version of JQuery is stomping on the one that's loaded in the "unsafeWindow"
namespace (because they're now the same). By adding a simple "@grant GM_log",
all of the problems disappear because JQuery is being loaded in the sandboxed
window.

So, either all scripts need to add a @grant line to continue working, or
the new auto-detection needs to be reconsidered. IMO, continuing with the old
behavior and only using the unsandboxed behavior when "@grant none" is
specified seems to be the best idea for backwards compatibility.

--
Jay Rossiter http://www.cothlamadh.net/
503.896.6187 si...@cothlamadh.net

[Anthony Lieuallen]

https://github.com/greasemonkey/greasemonkey/issues/1614