Contributing: eclipse README outdated?

[Freddy Boucher]

Hi,

I followed the eclipse README to setup a working environment to contribute but it fails with the following errors:

• ArrayHelper cannot be resolved
  
• ArrayHelper cannot be resolved to a variable
  
• Coercions cannot be resolved
  
• ConsoleLogger cannot be resolved
  
• DoNotInline cannot be resolved to a type
  
• HasNoSideEffects cannot be resolved to a type
  
• The import javaemul cannot be resolved
  
• The import javaemul.internal cannot be resolved
  
• UncheckedCast cannot be resolved to a type
  

I tried with a clean Eclipse Oxygen.1 Release (4.7.1)

Is the README outdated? Did I miss a step?

Thanks

[Thomas Broyer]

It's highly probable that the provided Eclipse configuration (in this case eclipse/user/.classpath) is outdated.

It looks like you'd have to add "core/super/com/google/gwt/emul" ("core" being "user" actually on disk) as a source root but only whitelist javaemul/internal/**/*.java , and blacklist **/EmulatedCharset.java, **/HashCodes.java, **/ConsoleLogger.java, **/NativeRegExp.java and **/SuperDevModeLogger.java (according to user/build.xml line 101)

[Freddy Boucher]

As always, you spotted it right! (except for the blacklist: only **/EmulatedCharset.java is necessary)

I will submit a patch for .eclipse/user/.classpath.

But just to know, Google doesn't use Eclipse internally? 

I'm an IntelliJ user, it would be great to have a REAME for IntelliJ.

Anyway Thanks so much!

[Thomas Broyer]

On Wednesday, October 11, 2017 at 10:34:56 AM UTC+2, Freddy Boucher wrote:

As always, you spotted it right! (except for the blacklist: only **/EmulatedCharset.java is necessary)

I will submit a patch for .eclipse/user/.classpath.

Great!

 

But just to know, Google doesn't use Eclipse internally? 

They most importantly don't use the provided Eclipse projects/settings and Ant build; they use their own tooling based on Blaze (their internal build tool, part of which is open sourced as Bazel, with specific Eclipse and IDEA/Android Studio plugins) AFAIK, Googlers are then free to pick the editor/IDE of their choice.

I'm an IntelliJ user, it would be great to have a REAME for IntelliJ.

Importing the Eclipse projects into IntelliJ has worked relatively well for me. I only use IntelliJ as an "editor" though, and use Ant to compile and run tests.

I'm not opposed to having a README explaining how to import those projects into IntelliJ though.

[Jens]

For IntelliJ I once did create a patch to add project files for IntelliJ

https://gwt-review.googlesource.com/c/gwt/+/12380

But I guess these files are slightly outdated as well nowadays.

— J

[Freddy Boucher]

I'm working on https://gwt-review.googlesource.com/c/gwt/+/14430

I rebased the original commit and makes some changes. 

But now when I want to push, I get "you have no 'forge author' permission"

remote: ERROR:  In commit c6a95320212d24d053cb0016b8d82d30f3238b1b

remote: ERROR:  author email address stefan....@gmail.com

remote: ERROR:  does not match your user account and you have no 'forge author' permission.

remote: ERROR:

remote: ERROR:  The following addresses are currently registered:

remote: ERROR:    freddy....@gmail.com

remote: ERROR:

remote: ERROR:  To register an email address, please visit:

remote: ERROR:  https://gwt-review.googlesource.com/#/settings/contact

Should I push my change as a totally new fix (and amend the author to get rid of the original author)?

Thanks

[Thomas Broyer]

That's the reason I'd prefer that IntelliJ users use the Eclipse files (and tell IntelliJ to keep the .classpath in sync). It's already a PITA whenever we make dependency updates to even remember to update the Eclipse files, if we also need to update the IntelliJ ones, I'd bet one of those will be forgotten (if only because the one doing the update only use one IDE, and will probably forget about the other)

If someone finds the time (and motivation) to finally port the Ant build to Gradle, then maybe we could get rid of the IDE-specific files.

[Thomas Broyer]

I think you have no other choice than to use your own email address as the author (you could use "Stefan Weiss + Freddy Boucher" as the author "name" though; note that the committer will likely be rewritten eventually, so that's also the only way to get credits for your work).

But please keep the same Change-Id.

(and it looks like you pushed a new review, with a new Change-Id, while I was writing this; maybe you could re-push with the old Change-Id, to update the original review, and then abandon the one you just created?)

[Freddy Boucher]

I think you have no other choice than to use your own email address as the author (you could use "Stefan Weiss + Freddy Boucher" as the author "name" though; note that the committer will likely be rewritten eventually, so that's also the only way to get credits for your work).

But please keep the same Change-Id.

(and it looks like you pushed a new review, with a new Change-Id, while I was writing this; maybe you could re-push with the old Change-Id, to update the original review, and then abandon the one you just created?)

Done!