Removed EXPERIMENTAL flag from GWT validation. Cleaned up all JavaDoc comments to reflect this c... (issue1811803)

82 views
Skip to first unread message

id...@google.com

unread,
Aug 16, 2012, 6:50:24 PM8/16/12
to nch...@google.com, cromw...@google.com, google-web-tool...@googlegroups.com, re...@gwt-code-reviews-hr.appspotmail.com
Reviewers: Nick Chalko, cromwellian,

Description:
Removed EXPERIMENTAL flag from GWT validation. Cleaned up all JavaDoc
comments to reflect this change.


Please review this at http://gwt-code-reviews.appspot.com/1811803/

Affected files:
M
user/src/com/google/gwt/validation/client/AbstractGwtValidatorFactory.java
M
user/src/com/google/gwt/validation/client/AbstractValidationMessageResolver.java
M user/src/com/google/gwt/validation/client/BaseMessageInterpolator.java
M
user/src/com/google/gwt/validation/client/DefaultTraversableResolver.java
M
user/src/com/google/gwt/validation/client/GwtConstraintValidatorFactory.java
M user/src/com/google/gwt/validation/client/GwtMessageInterpolator.java
M user/src/com/google/gwt/validation/client/GwtValidation.java
M
user/src/com/google/gwt/validation/client/GwtValidationProviderResolver.java
M
user/src/com/google/gwt/validation/client/ProviderValidationMessageResolver.java
M
user/src/com/google/gwt/validation/client/UserValidationMessagesResolver.java
M user/src/com/google/gwt/validation/client/ValidationMessageResolver.java
M
user/src/com/google/gwt/validation/client/constraints/AbstractDecimalMaxValidator.java
M
user/src/com/google/gwt/validation/client/constraints/AbstractDecimalMinValidator.java
M
user/src/com/google/gwt/validation/client/constraints/AbstractDigitsValidator.java
M
user/src/com/google/gwt/validation/client/constraints/AbstractMaxValidator.java
M
user/src/com/google/gwt/validation/client/constraints/AbstractMinValidator.java
M
user/src/com/google/gwt/validation/client/constraints/AbstractSizeValidator.java
M
user/src/com/google/gwt/validation/client/constraints/AssertFalseValidator.java
M
user/src/com/google/gwt/validation/client/constraints/AssertTrueValidator.java
M
user/src/com/google/gwt/validation/client/constraints/DecimalMaxValidatorForNumber.java
M
user/src/com/google/gwt/validation/client/constraints/DecimalMaxValidatorForString.java
M
user/src/com/google/gwt/validation/client/constraints/DecimalMinValidatorForNumber.java
M
user/src/com/google/gwt/validation/client/constraints/DecimalMinValidatorForString.java
M
user/src/com/google/gwt/validation/client/constraints/DigitsValidatorForNumber.java
M
user/src/com/google/gwt/validation/client/constraints/DigitsValidatorForString.java
M
user/src/com/google/gwt/validation/client/constraints/FutureValidatorForDate.java
M
user/src/com/google/gwt/validation/client/constraints/MaxValidatorForNumber.java
M
user/src/com/google/gwt/validation/client/constraints/MaxValidatorForString.java
M
user/src/com/google/gwt/validation/client/constraints/MinValidatorForNumber.java
M
user/src/com/google/gwt/validation/client/constraints/MinValidatorForString.java
M
user/src/com/google/gwt/validation/client/constraints/NotGwtCompatibleValidator.java
M
user/src/com/google/gwt/validation/client/constraints/NotNullValidator.java
M user/src/com/google/gwt/validation/client/constraints/NullValidator.java
M
user/src/com/google/gwt/validation/client/constraints/PastValidatorForDate.java
M
user/src/com/google/gwt/validation/client/constraints/PatternValidator.java
M
user/src/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfBoolean.java
M
user/src/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfByte.java
M
user/src/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfChar.java
M
user/src/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfDouble.java
M
user/src/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfFloat.java
M
user/src/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfInt.java
M
user/src/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfLong.java
M
user/src/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfObject.java
M
user/src/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfShort.java
M
user/src/com/google/gwt/validation/client/constraints/SizeValidatorForCollection.java
M
user/src/com/google/gwt/validation/client/constraints/SizeValidatorForMap.java
M
user/src/com/google/gwt/validation/client/constraints/SizeValidatorForString.java
M
user/src/com/google/gwt/validation/client/impl/AbstractGwtSpecificValidator.java
M user/src/com/google/gwt/validation/client/impl/AbstractGwtValidator.java
M user/src/com/google/gwt/validation/client/impl/BaseGwtConfiguration.java
M
user/src/com/google/gwt/validation/client/impl/ConstraintDescriptorImpl.java
M user/src/com/google/gwt/validation/client/impl/ConstraintFinderImpl.java
M user/src/com/google/gwt/validation/client/impl/ConstraintOrigin.java
M
user/src/com/google/gwt/validation/client/impl/ConstraintValidatorContextImpl.java
M
user/src/com/google/gwt/validation/client/impl/ConstraintViolationImpl.java
M user/src/com/google/gwt/validation/client/impl/Group.java
M user/src/com/google/gwt/validation/client/impl/GroupChain.java
M user/src/com/google/gwt/validation/client/impl/GroupChainGenerator.java
M user/src/com/google/gwt/validation/client/impl/GroupValidator.java
M user/src/com/google/gwt/validation/client/impl/GwtBeanDescriptor.java
M
user/src/com/google/gwt/validation/client/impl/GwtBeanDescriptorImpl.java
M user/src/com/google/gwt/validation/client/impl/GwtConfiguration.java
M user/src/com/google/gwt/validation/client/impl/GwtSpecificValidator.java
M user/src/com/google/gwt/validation/client/impl/GwtValidationContext.java
M user/src/com/google/gwt/validation/client/impl/GwtValidatorContext.java
M
user/src/com/google/gwt/validation/client/impl/MessageInterpolatorContextImpl.java
M user/src/com/google/gwt/validation/client/impl/NodeImpl.java
M
user/src/com/google/gwt/validation/client/impl/NullUserValidationMessageResolver.java
M user/src/com/google/gwt/validation/client/impl/PathImpl.java
M
user/src/com/google/gwt/validation/client/impl/PropertyDescriptorImpl.java
M user/src/com/google/gwt/validation/client/impl/Validation.java
M
user/src/com/google/gwt/validation/client/impl/metadata/BeanMetadata.java
M
user/src/com/google/gwt/validation/client/impl/metadata/MessageAndPath.java
M
user/src/com/google/gwt/validation/client/impl/metadata/ValidationGroupsMetadata.java
M
user/src/com/google/gwt/validation/client/spi/BaseConfigurationState.java
M user/src/com/google/gwt/validation/client/spi/GwtConfigurationState.java
M user/src/com/google/gwt/validation/client/spi/GwtValidationProvider.java
M user/src/com/google/gwt/validation/rebind/AbstractCreator.java
M user/src/com/google/gwt/validation/rebind/BeanHelper.java
M user/src/com/google/gwt/validation/rebind/BeanHelperCache.java
M
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java
M user/src/com/google/gwt/validation/rebind/Util.java
M user/src/com/google/gwt/validation/rebind/ValidatorCreator.java
M user/src/com/google/gwt/validation/rebind/ValidatorGenerator.java
M
user/src/com/google/gwt/validation/super/com/google/gwt/validation/client/GwtMessageInterpolator.java


nch...@google.com

unread,
Aug 16, 2012, 7:01:37 PM8/16/12
to id...@google.com, cromw...@gmail.com, google-web-tool...@googlegroups.com, re...@gwt-code-reviews-hr.appspotmail.com
lgtm


http://gwt-code-reviews.appspot.com/1811803/diff/1/user/src/com/google/gwt/validation/client/GwtValidation.java
File user/src/com/google/gwt/validation/client/GwtValidation.java
(right):

http://gwt-code-reviews.appspot.com/1811803/diff/1/user/src/com/google/gwt/validation/client/GwtValidation.java#newcode31
user/src/com/google/gwt/validation/client/GwtValidation.java:31: *
Define the Validator you want, explicitly listing the class and groups
the classes

http://gwt-code-reviews.appspot.com/1811803/

jens.ne...@gmail.com

unread,
Aug 17, 2012, 4:18:05 AM8/17/12
to id...@google.com, nch...@google.com, cromw...@gmail.com, google-web-tool...@googlegroups.com, re...@gwt-code-reviews-hr.appspotmail.com
Nice, any chance that it will make its way into 2.5 Final?

http://gwt-code-reviews.appspot.com/1811803/

Ray Cromwell

unread,
Aug 20, 2012, 1:46:28 PM8/20/12
to google-web-tool...@googlegroups.com, id...@google.com, nch...@google.com, cromw...@gmail.com, re...@gwt-code-reviews-hr.appspotmail.com
We are discussing right now cherry picking it into 2.5

On Fri, Aug 17, 2012 at 1:18 AM, <jens.ne...@gmail.com> wrote:
> Nice, any chance that it will make its way into 2.5 Final?
>
>
> http://gwt-code-reviews.appspot.com/1811803/
>
> --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reply all
Reply to author
Forward
0 new messages