TreeItem patch proposal - L&F

[Pavel]

Hi Everyone,

I played around with TreeItem a bit and I think this would be a good
look&feel improvement.
Here is a screenshot:
http://pavelgj.googlepages.com/tree-sample.jpg

Here is the patch:
http://pavelgj.googlepages.com/TreeItem-Pavel.patch

Plus these images:
http://pavelgj.googlepages.com/tree_open.gif
http://pavelgj.googlepages.com/tree_closed.gif
http://pavelgj.googlepages.com/tree_connect_tb.gif
http://pavelgj.googlepages.com/tree_connect_tr.gif
http://pavelgj.googlepages.com/tree_connect_trb.gif

Let me know what you think.

Thanks,

Pavel Jbanov

[Bruce Johnson]

Looks nice. It seems like the kind of thing that should be optional, though. In other UIs that do this, I've thought that in big/dense trees, the connection lines can become visually heavy.

[David Evans]

The 'lined' approach (for all of its confusing regedit looking
deep,thin tree nonsense) is familiar to many a boss and stuffy
customer.

Seems like Elements like trees would benefit from "theming" or
predefined sets of looks that are more coherent than the average
developer is willing to do with explicit css tho, and I understand why
it makes sense to do in code, but it does seem a little harsh to change
it outright.

perhaps a css file, zip file, and a readme? Or give treeitem the
ability to take paths to the various images via function access?

On Jan 12, 2:57 pm, "Bruce Johnson" <b...@google.com> wrote:
> Looks nice. It seems like the kind of thing that should be optional, though.
> In other UIs that do this, I've thought that in big/dense trees, the
> connection lines can become visually heavy.
>

[Pavel]

Making it optional should be easy to do, but I think turning connection
lines off should be optional.
/**
* Sets show connection lines flag ("on" by default)
*/
public void setConnectionLines(boolean onOff);

Although your way makes more sense in terms of backwards compatibility.

Pavel

Bruce Johnson wrote:
> Looks nice. It seems like the kind of thing that should be optional,
> though. In other UIs that do this, I've thought that in big/dense
> trees, the connection lines can become visually heavy.
>

[gwt.team.rdayal]

I definitely agree with the 'theming' idea.

I wonder if we can maybe have the connection lines always exist in the
tree, but have their visibility off by default using CSS (instead of a
setConnectionLines method).

Rajeev