Re: Add more HtmlUnit platforms/browsers testings

10 views
Skip to first unread message

amitm...@google.com

unread,
Sep 9, 2009, 12:25:56 PM9/9/09
to fl...@google.com, google-web-tool...@googlegroups.com
Hi Frank,

Instead of having individual ant commands for each browser emulation, it
would be better to test all the browsers in parallel using -htmlunit
FF3, FF2, IE6, IE7.

I did not see any changes to JUnitShell.java where it processes the
@DoNotRunWith argument. I assume you would need to make a change there.
Also, would this change require additional annotations on the tests --
the individual tests that fail on a particular browser emulation can be
annotated as such.

Regards,
Amit


http://gwt-code-reviews.appspot.com/64809

Amit Manjhi

unread,
Sep 9, 2009, 2:40:37 PM9/9/09
to Frank Lin, google-web-tool...@googlegroups.com, Freeland Abbott


On Wed, Sep 9, 2009 at 11:19 AM, Frank Lin <fl...@google.com> wrote:
Hi Amit,



On Wed, Sep 9, 2009 at 9:25 AM, <amitm...@google.com> wrote:
Hi Frank,

Instead of having individual ant commands for each browser emulation, it
would be better to test all the browsers in parallel using -htmlunit
FF3, FF2, IE6, IE7.

I would suggest more ant targets rather let ant optimize the parallelism since blaze might be able to shard them better. We might need Freeland's expertise on that.

When all browsers are specified, the parallelism is at the JVM level, not at the ant level. A separate HtmlUnit thread is started to emulate each browser. 

Amit Manjhi

unread,
Sep 9, 2009, 8:02:02 PM9/9/09
to Frank Lin, google-web-tool...@googlegroups.com, Freeland Abbott
For now, it seems fine. It is the same issue when running multiple browsers simultaneously during remoteweb or selenium tests.

On Wed, Sep 9, 2009 at 1:45 PM, Frank Lin <fl...@google.com> wrote:
Just one issue: is it okay to use test.out for all platforms if using '-htmlunit FF3, FF2, IE6, IE7'?
 test.out="${junit.out}/${build.host.platform}-htmlunit-web-mode" 

Frank Lin

unread,
Sep 9, 2009, 11:39:19 PM9/9/09
to Amit Manjhi, google-web-tool...@googlegroups.com, Freeland Abbott
Should the compiled JS code be browser dependent? With multiple threads, it ran out of memory for me couple times. Lastly, if one browser failed, it stops the rest of the tests.

Frank Lin

unread,
Sep 11, 2009, 12:47:49 PM9/11/09
to Amit Manjhi, google-web-tool...@googlegroups.com, Freeland Abbott
Here was what I got when using "-htmlunit FF3,FF2,IE7,IE6" The memory already 2G: -Xmx=2048m

    [junit] Exception in thread "main" java.lang.OutOfMemoryError: Java heap space
    [junit] at java.lang.StringCoding$StringEncoder.encode(StringCoding.java:250)
    [junit] at java.lang.StringCoding.encode(StringCoding.java:290)
    [junit] at java.lang.StringCoding.encode(StringCoding.java:302)
    [junit] at java.lang.String.getBytes(String.java:994)
    [junit] at org.apache.tools.ant.taskdefs.optional.junit.PlainJUnitResultFormatter.endTestSuite(PlainJUnitResultFormatter.java:150)
    [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.fireEndTestSuite(JUnitTestRunner.java:621)
    [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:453)
    [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:912)
    [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:766)
Reply all
Reply to author
Forward
0 new messages