Proposed LauncherDir change, add template bindAddress replacement

Brandon Donnelson

unread,

Oct 12, 2016, 1:17:42 PM10/12/16

to GWT Contributors

What would you think of adding a bindAddress replacement to the template.nocache.js file. __bindAddress__ instead of $window.location.hostname?

Example Source - Used for testing Hack

https://github.com/gwt-plugins/codeserver/blob/master/codeserver/src/main/java/com/google/gwt/dev/codeserver/LauncherDir.java#L127

Reason

Running code server on a local private ip and deploying the web app on a different ip, this simplifies the setup.

Thoughts?

Thanks,

Brandon

Screen Shot 2016-10-12 at 10.09.08 AM.png

Brandon Donnelson

unread,

Oct 12, 2016, 1:25:49 PM10/12/16

to GWT Contributors

GWT Eclipse Plugin (V3) Issue: https://github.com/gwt-plugins/gwt-eclipse-plugin/issues/274

David Becker

unread,

Oct 12, 2016, 1:27:18 PM10/12/16

to GWT Contributors

A while back -bindAddress 0.0.0.0 was changed in GWT 2.8 to use the actual IP address instead of a local hostname to work better when operating in an environment where the local hostname isn't recognized by the client (specifically, things like windows tablets don't seem to recognize the mac myhost.local syntax). This seems like a logical extension of that functionality to cover even more scenarios and sounds good to me.

Brandon Donnelson

unread,

Oct 12, 2016, 6:17:25 PM10/12/16

to GWT Contributors

https://gwt-review.googlesource.com/#/c/17180/

Brandon Donnelson

unread,

Oct 14, 2016, 3:31:29 PM10/14/16

to GWT Contributors

ping

Brandon Donnelson

unread,

Oct 18, 2016, 3:42:49 PM10/18/16

to GWT Contributors

I filed a github for it.

https://github.com/gwtproject/gwt/issues/9446

Reply all

Reply to author

Forward