store as Global Variable

[Jason Laster]

Hey DevTools,

I took a stab at this issue (Right Clicking on an element should show "Store as Global Variable"), this weekend. 

I think I got decently close (patch), but I got tripped up on the connection between tree elements, dom models, and remote objects. I assume I'm supposed to have a reference to a RemoteObjectImpl to be able to save a temporary reference, but I'm not sure how to pull it off. 

Do you have any pointers? 

-- 
Jason Laster
Software Engineer
  Etsy  

[Pavel Feldman]

Please file it as a code review and we'll be able to suggest from there. But overall, you want a WebInspector.ContextMenu.Provider that would provide action applicable to the remote objects. It can live in the sources module for now, it is fine if it wakes it.

Regards

Pavel

--
You received this message because you are subscribed to the Google Groups "Google Chrome Developer Tools" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-chrome-develo...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/google-chrome-developer-tools/CAH_2F5FFUKXX9YoZhD0P1ezw_rXRZgmhgVkP7qc5rrH9YjH5Bg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

[Jason Laster]

Thanks Pavel, I'll create the code review sans the `saveToGlobalVariable` extract.

Is there a good place to dig into extensions like ActionDelegate and ContextMenuProvider?  I did a quick search and could not find much on them ContextMenuProvider.h. 

To view this discussion on the web visit https://groups.google.com/d/msgid/google-chrome-developer-tools/CAEX3KhbJ4iqCT0KKvv_R5h_d%3Dk%3DRjFxPP%3DKNzp-RNPE0jmmN%3DQ%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

--

[Pavel Feldman]

On Mon, Apr 6, 2015 at 4:49 PM, Jason Laster <jason.l...@gmail.com> wrote:

Thanks Pavel, I'll create the code review sans the `saveToGlobalVariable` extract.

Is there a good place to dig into extensions like ActionDelegate and ContextMenuProvider?  I did a quick search and could not find much on them ContextMenuProvider.h. 

Not really, no, you'll have to look at the code :(

 

To view this discussion on the web visit https://groups.google.com/d/msgid/google-chrome-developer-tools/CAH_2F5ESWFpReJX5OWin%3D%3D5A%2BZbV__MybokirztRp-aZ98rcaw%40mail.gmail.com.