Upgrade Jetty and make test server listen only on localhost. (issue 258980043 by kpreid@google.com)

8 views
Skip to first unread message

re...@codereview-hr.appspotmail.com

unread,
Jul 27, 2015, 7:39:01 PM7/27/15
to fel...@gmail.com, kpr...@google.com, google-ca...@googlegroups.com, re...@codereview-hr.appspotmail.com
Reviewers: felix8a,

Description:
Fixes half of <https://github.com/google/caja/issues/1964>, test server
being visible to the network.

The Jetty upgrade is needed because the ancient Jetty version we had
did not allow binding to an address. We are upgrading to Jetty 8, not
Jetty 9, so as to not require Java 8.

Please review this at https://codereview.appspot.com/258980043/

Affected files (+3801, -1641 lines):
M build.xml
M src/com/google/caja/service/CajolingServiceMain.java
M tests/com/google/caja/plugin/BrowserTestCase.java
M tests/com/google/caja/plugin/ModulesBrowserTest.java
M tests/com/google/caja/service/TestHttpServletRequest.java
M tests/com/google/caja/service/TestHttpServletResponse.java
M tests/com/google/caja/util/LocalServer.java
D tests/com/google/caja/util/WrapperResource.java
A + third_party/java/jetty/LICENSE-APACHE-2.0.txt
A third_party/java/jetty/LICENSE-ECLIPSE-1.0.html
D third_party/java/jetty/LICENSES/LICENSE.txt
D third_party/java/jetty/LICENSES/NOTICE.txt
M third_party/java/jetty/README.txt
M third_party/java/jetty/VERSION.txt
A third_party/java/jetty/about.html
D third_party/java/jetty/lib/jetty.jar
D third_party/java/jetty/lib/jetty-6.1.15.jar
A third_party/java/jetty/lib/jetty-continuation.jar
A third_party/java/jetty/lib/jetty-continuation-8.1.17.v20150415.jar
A third_party/java/jetty/lib/jetty-http.jar
A third_party/java/jetty/lib/jetty-http-8.1.17.v20150415.jar
A third_party/java/jetty/lib/jetty-io.jar
A third_party/java/jetty/lib/jetty-io-8.1.17.v20150415.jar
A third_party/java/jetty/lib/jetty-security.jar
A third_party/java/jetty/lib/jetty-security-8.1.17.v20150415.jar
A third_party/java/jetty/lib/jetty-server.jar
A third_party/java/jetty/lib/jetty-server-8.1.17.v20150415.jar
A third_party/java/jetty/lib/jetty-servlet.jar
A third_party/java/jetty/lib/jetty-servlet-8.1.17.v20150415.jar
M third_party/java/jetty/lib/jetty-util.jar
D third_party/java/jetty/lib/jetty-util-6.1.15.jar
A third_party/java/jetty/lib/jetty-util-8.1.17.v20150415.jar
A third_party/java/jetty/lib/servlet-api-3.0.jar
A third_party/java/jetty/notice.html
D third_party/java/jsdk2.1/LICENSE
D third_party/java/jsdk2.1/README
D third_party/java/jsdk2.1/default.cfg
D third_party/java/jsdk2.1/etc/SimpleStartup.java
D third_party/java/jsdk2.1/servlet.jar
D third_party/java/jsdk2.1/startserver
D third_party/java/jsdk2.1/startserver.bat
D third_party/java/jsdk2.1/stopserver
D third_party/java/jsdk2.1/stopserver.bat


fel...@gmail.com

unread,
Jul 27, 2015, 7:54:26 PM7/27/15
to kpr...@google.com, google-ca...@googlegroups.com, re...@codereview-hr.appspotmail.com
Reply all
Reply to author
Forward
0 new messages