Re: Fixes several problems in our support for safe debugging. (issue 226970043 by erights@gmail.com)

2 views
Skip to first unread message

kpr...@google.com

unread,
Apr 20, 2015, 1:48:51 PM4/20/15
to eri...@gmail.com, google-ca...@googlegroups.com, re...@codereview-hr.appspotmail.com
LGTM


https://codereview.appspot.com/226970043/diff/60001/src/com/google/caja/ses/debug.js
File src/com/google/caja/ses/debug.js (right):

https://codereview.appspot.com/226970043/diff/60001/src/com/google/caja/ses/debug.js#newcode86
src/com/google/caja/ses/debug.js:86: [EvalError, RangeError,
ReferenceError, SyntaxError, TypeError, URIError
What happens if this list is out of sync with the whitelist?

If it's silent and bad, add a warning to the whitelist.

Or, perhaps we could derive this list from the whitelist, ensuring it's
in sync?

https://codereview.appspot.com/226970043/
Reply all
Reply to author
Forward
0 new messages