Groups
Sign in
Groups
Google Caja Discuss
Conversations
About
Send feedback
Help
Re: Fixes several problems in our support for safe debugging. (issue 226970043 by erights@gmail.com)
2 views
Skip to first unread message
kpr...@google.com
unread,
Apr 20, 2015, 1:48:51 PM
4/20/15
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Sign in to report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to eri...@gmail.com, google-ca...@googlegroups.com, re...@codereview-hr.appspotmail.com
LGTM
https://codereview.appspot.com/226970043/diff/60001/src/com/google/caja/ses/debug.js
File src/com/google/caja/ses/debug.js (right):
https://codereview.appspot.com/226970043/diff/60001/src/com/google/caja/ses/debug.js#newcode86
src/com/google/caja/ses/debug.js:86: [EvalError, RangeError,
ReferenceError, SyntaxError, TypeError, URIError
What happens if this list is out of sync with the whitelist?
If it's silent and bad, add a warning to the whitelist.
Or, perhaps we could derive this list from the whitelist, ensuring it's
in sync?
https://codereview.appspot.com/226970043/
Reply all
Reply to author
Forward
0 new messages