Issue 1955 in google-caja: Fix remaining uses of Object.prototype.toString.call as a brand test to do something else.

1 view
Skip to first unread message

googl...@googlecode.com

unread,
Feb 15, 2015, 1:54:50 PM2/15/15
to google-ca...@googlegroups.com
Status: New
Owner: kpreid.switchb.org
Labels: Type-Defect Priority-Medium Component-Other Component-Taming
Security

New issue 1955 by erights: Fix remaining uses of
Object.prototype.toString.call as a brand test to do something else.
https://code.google.com/p/google-caja/issues/detail?id=1955

As of this writing, Object.prototype.toString.call(specimen) is still a
reliable brand test on all deployed browsers, but TC39 recently agreed on a
change so that it would no longer be.

Uses in SES fixed at r5708. Remaining uses at least in
cajaTamingGoogleLoader.js and taming-membrane.js, either of which may
actually be safe.


--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

googl...@googlecode.com

unread,
Feb 18, 2015, 6:07:22 PM2/18/15
to google-ca...@googlegroups.com
Updates:
Status: Pending
Owner: kpr...@google.com
Labels: -Component-Other

Comment #1 on issue 1955 by kpr...@google.com: Fix remaining uses of
Object.prototype.toString.call as a brand test to do something else.
https://code.google.com/p/google-caja/issues/detail?id=1955

https://codereview.appspot.com/202140043/

googl...@googlecode.com

unread,
Feb 18, 2015, 6:39:49 PM2/18/15
to google-ca...@googlegroups.com
Updates:
Status: Fixed

Comment #2 on issue 1955 by kpr...@google.com: Fix remaining uses of
Object.prototype.toString.call as a brand test to do something else.
https://code.google.com/p/google-caja/issues/detail?id=1955

@r5710

All other uses of Object.prototype.toString are harmless.
Reply all
Reply to author
Forward
0 new messages