re...@codereview-hr.appspotmail.com
unread,Feb 26, 2015, 7:07:26 PM2/26/15Sign in to reply to author
Sign in to forward
You do not have permission to delete messages in this group
Sign in to report message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to eri...@gmail.com, kpr...@google.com, google-ca...@googlegroups.com, re...@codereview-hr.appspotmail.com
Reviewers: MarkM,
Description:
The test catalog specified running test-success.js in both minified
and unminified mode, but it did not pass on the flag to caja.initialize,
so any problems with minification of the iframe JS would not be caught.
Please review this at
https://codereview.appspot.com/202420043/
Affected files (+1, -1 lines):
M tests/com/google/caja/plugin/test-success.js
Index: tests/com/google/caja/plugin/test-success.js
===================================================================
--- tests/com/google/caja/plugin/test-success.js (revision 5713)
+++ tests/com/google/caja/plugin/test-success.js (working copy)
@@ -24,7 +24,7 @@
caja.initialize(
{
cajaServer: '/caja',
- debug: true,
+ debug: !minifiedMode,
maxAcceptableSeverity: 'NO_KNOWN_EXPLOIT_SPEC_VIOLATION'
},
function() {},