Make test-success actually test minified mode. (issue 202420043 by kpreid@google.com)

0 views
Skip to first unread message

re...@codereview-hr.appspotmail.com

unread,
Feb 26, 2015, 7:07:26 PM2/26/15
to eri...@gmail.com, kpr...@google.com, google-ca...@googlegroups.com, re...@codereview-hr.appspotmail.com
Reviewers: MarkM,

Description:
The test catalog specified running test-success.js in both minified
and unminified mode, but it did not pass on the flag to caja.initialize,
so any problems with minification of the iframe JS would not be caught.

Please review this at https://codereview.appspot.com/202420043/

Affected files (+1, -1 lines):
M tests/com/google/caja/plugin/test-success.js


Index: tests/com/google/caja/plugin/test-success.js
===================================================================
--- tests/com/google/caja/plugin/test-success.js (revision 5713)
+++ tests/com/google/caja/plugin/test-success.js (working copy)
@@ -24,7 +24,7 @@
caja.initialize(
{
cajaServer: '/caja',
- debug: true,
+ debug: !minifiedMode,
maxAcceptableSeverity: 'NO_KNOWN_EXPLOIT_SPEC_VIOLATION'
},
function() {},


eri...@gmail.com

unread,
Feb 26, 2015, 7:09:18 PM2/26/15
to kpr...@google.com, google-ca...@googlegroups.com, re...@codereview-hr.appspotmail.com
Reply all
Reply to author
Forward
0 new messages