Re: support css -webkit- prefix (issue 12434043)

16 views
Skip to first unread message

fel...@gmail.com

unread,
Aug 5, 2013, 3:00:13 PM8/5/13
to mikes...@gmail.com, google-ca...@googlegroups.com, re...@codereview-hr.appspotmail.com

mikes...@gmail.com

unread,
Aug 5, 2013, 3:30:37 PM8/5/13
to fel...@gmail.com, google-ca...@googlegroups.com, re...@codereview-hr.appspotmail.com
LGTM


https://codereview.appspot.com/12434043/diff/1/src/com/google/caja/lang/css/css-extensions-defs.json
File src/com/google/caja/lang/css/css-extensions-defs.json (right):

https://codereview.appspot.com/12434043/diff/1/src/com/google/caja/lang/css/css-extensions-defs.json#newcode123
src/com/google/caja/lang/css/css-extensions-defs.json:123: "as":
"visibility" },
might "as": "backface-visibility" be less of a maintenance hazard?

https://codereview.appspot.com/12434043/diff/1/src/com/google/caja/plugin/sanitizecss.js
File src/com/google/caja/plugin/sanitizecss.js (right):

https://codereview.appspot.com/12434043/diff/1/src/com/google/caja/plugin/sanitizecss.js#newcode845
src/com/google/caja/plugin/sanitizecss.js:845: atIdent = '@keyframes';
ok

https://codereview.appspot.com/12434043/

fel...@gmail.com

unread,
Aug 5, 2013, 6:18:31 PM8/5/13
to mikes...@gmail.com, google-ca...@googlegroups.com, re...@codereview-hr.appspotmail.com
@r5527


https://codereview.appspot.com/12434043/diff/1/src/com/google/caja/lang/css/css-extensions-defs.json
File src/com/google/caja/lang/css/css-extensions-defs.json (right):

https://codereview.appspot.com/12434043/diff/1/src/com/google/caja/lang/css/css-extensions-defs.json#newcode123
src/com/google/caja/lang/css/css-extensions-defs.json:123: "as":
"visibility" },
On 2013/08/05 19:30:37, MikeSamuel wrote:
> might "as": "backface-visibility" be less of a maintenance hazard?

CssSchema doesn't do double indirection, throws an error.

https://codereview.appspot.com/12434043/

kamruzza...@gmail.com

unread,
Aug 11, 2013, 1:21:15 PM8/11/13
to google-ca...@googlegroups.com, fel...@gmail.com, re...@codereview-hr.appspotmail.com, mikes...@gmail.com
Reply all
Reply to author
Forward
0 new messages