Re: Have test links link more directly to github test262 pages. (issue 199650043 by erights@gmail.com)

2 views
Skip to first unread message

eri...@gmail.com

unread,
Feb 15, 2015, 7:11:10 PM2/15/15
to kpreid.sw...@gmail.com, google-ca...@googlegroups.com, re...@codereview-hr.appspotmail.com

https://codereview.appspot.com/199650043/diff/1/src/com/google/caja/ses/useHTMLLogger.js
File src/com/google/caja/ses/useHTMLLogger.js (right):

https://codereview.appspot.com/199650043/diff/1/src/com/google/caja/ses/useHTMLLogger.js#newcode203
src/com/google/caja/ses/useHTMLLogger.js:203: return test;
On 2015/02/15 22:15:54, kpreid2 wrote:
> I don't like that this as it is behaves oppositely to normal relative
URI
> resolution.

What would you suggest instead?


> Given the circumstances, I suggest a condition at this point checking
for
> /^[-+.\w]+:/ (that is, has a URI scheme) and indicate failure (i.e.
return
> something like "data:,Failed%20to%20resolve%20" + test) otherwise.
That'll at
> least make it never return nonsense.

Done.

https://codereview.appspot.com/199650043/diff/1/src/com/google/caja/ses/useHTMLLogger.js#newcode258
src/com/google/caja/ses/useHTMLLogger.js:258: link.href =
'http://es5.github.io/#x' + encodeURIComponent(section);
On 2015/02/15 22:15:54, kpreid2 wrote:
> We can https: here

Done.

https://codereview.appspot.com/199650043/

kpreid.sw...@gmail.com

unread,
Feb 15, 2015, 7:14:31 PM2/15/15
to eri...@gmail.com, google-ca...@googlegroups.com, re...@codereview-hr.appspotmail.com
LGTM
On 2015/02/16 00:11:09, MarkM wrote:
> On 2015/02/15 22:15:54, kpreid2 wrote:
> > I don't like that this as it is behaves oppositely to normal
relative URI
> > resolution.

> What would you suggest instead?

My next paragraph, which you have already implemented, was my
suggestion.

https://codereview.appspot.com/199650043/
Reply all
Reply to author
Forward
0 new messages