aedeploy - tilde

[Miguel Vitorino]

Hi,

If we have a file with a tilde ("~") in it's name, deployment with aedeploy fails:

(gcloud.preview.app.deploy) Error Response: [400] Invalid character in filename: _gopath/src/github.com/cbroglie/mustache/spec/specs/~lambdas.json

It seems GCS doesn't support tildes in paths. 

aedeploy doesnt respect .dockerignore or skip_files section in app.yaml so maybe a simple solution would be to not upload any file/folder with a tilde? 

diff --git a/cmd/aedeploy/aedeploy.go b/cmd/aedeploy/aedeploy.go

index 03c5f60..a67cea1 100644

--- a/cmd/aedeploy/aedeploy.go

+++ b/cmd/aedeploy/aedeploy.go

@@ -202,6 +202,9 @@ func copyTree(dstRoot, dstDir, srcDir string) error {

  if skipFiles[n] {

  continue

  }

+ if strings.Contains(n, "~") {

+ continue

+ }

  s := filepath.Join(srcDir, n)

  if entry.Mode()&os.ModeSymlink == os.ModeSymlink {

  if entry, err = os.Stat(s); err != nil {

I would send a pull request but David said in the past you don't accept them.

Thanks,

Miguel

[Adam Tanner]

I just did a quick test using gsutil and it appears that GCS supports filenames with tildes in them just fine. It looks more like an App Engine limitation at first glance. I'll investigate a bit and see if there's a legitimate reason to not allow them or if it's just a bug.

--
You received this message because you are subscribed to the Google Groups "google-appengine-go" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-appengin...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Miguel Vitorino]

OK, thanks for getting back to me on this. I assumed it was GCS but did no such test.

Miguel Vitorino

Technical Director
Skype: miguel.vitorino

Support UK: +44 (20) 33 896 112

Support US: +1 (646) 350-0511