aetest import error on deploy (classic, not VMs) (v1.9.37)

[Ian Rose]

Hi -

I just updated my Go SDK to 1.9.37 and now I get the following error when trying to deploy.  Here is my command:

appcfg.py update -A fs-staging dist/deploy

and here is the output:

11:38 AM Application: fs-staging (was: None); module: deploy; version: 1
11:38 AM Host: appengine.google.com
11:38 AM Starting update of app: fs-staging, module: deploy, version: 1
11:38 AM Getting current resource limits.
11:38 AM Scanning files on local disk.
11:38 AM Cloning 4 static files.
11:38 AM Cloning 420 application files.
11:39 AM Compilation starting.
11:39 AM Compilation: 409 files left.
11:39 AM Error 422: --- begin server output ---
Compile failed:
2016/05/24 08:39:11 go-app-builder: build timing: 83×compile (32.345s total), 0×link (0 total)
2016/05/24 08:39:11 go-app-builder: failed running compile: exit status 1


google.golang.org/appengine/aetest/instance_classic.go:5: can't find import: "appengine/aetest"
--- end server output ---
11:39 AM Rolling back the update.
Error 422: --- begin server output ---


--- end server output ---

I see that the appengine/aetest file is still present in the 1.9.37 SDK, so I'm a bit confused:

$ find go_appengine-1.9.37 -name aetest
go_appengine-1.9.37/goroot/src/appengine/aetest

Also, `goapp test` still works fine locally, so aetest IS being found by our local unit tests at least...

Perhaps this has something to do with the recent change to how the local SDK uploads files?

- Ian

[Ian Rose]

False alarm.

After further investigation, it appears that this was due to a recent commit (in our code) that introduced a import dependency on "aetest".  Although the aetest package wasn't actually used at all in production code (only in tests) it seems that app engine is unable to resolve the import during remote compilation.  By refactoring things so that aetest is imported by a helper package (which itself is not imported at all other than by tests) I was able to compile & deploy my code.

- Ian